| Message ID | 1606896750-18198-1-git-send-email-loic.poulain@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] mhi: pci_generic: Fix implicit conversion warning | expand |
On Wed, Dec 02, 2020 at 09:12:30AM +0100, Loic Poulain wrote: > Fix the following warning with explicit cast: > > warning: implicit conversion from 'unsigned long long' to > 'dma_addr_t' (aka 'unsigned int') > mhi_cntrl->iova_stop = DMA_BIT_MASK(info->dma_data_width); > > Fixes: 855a70c12021 ("bus: mhi: Add MHI PCI support for WWAN modems") > Signed-off-by: Loic Poulain <loic.poulain@linaro.org> > Reported-by: kernel test robot <lkp@intel.com> > Reviewed-by: Nathan Chancellor <natechancellor@gmail.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Thanks, Mani > --- > v2: Add fixes tag > > drivers/bus/mhi/pci_generic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c > index cfee0db..0912885 100644 > --- a/drivers/bus/mhi/pci_generic.c > +++ b/drivers/bus/mhi/pci_generic.c > @@ -406,7 +406,7 @@ static int mhi_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) > mhi_initialize_controller(mhi_cntrl); > mhi_cntrl->cntrl_dev = &pdev->dev; > mhi_cntrl->iova_start = 0; > - mhi_cntrl->iova_stop = DMA_BIT_MASK(info->dma_data_width); > + mhi_cntrl->iova_stop = (dma_addr_t)DMA_BIT_MASK(info->dma_data_width); > mhi_cntrl->fw_image = info->fw; > mhi_cntrl->edl_image = info->edl; > > -- > 2.7.4 >
On Wed, Dec 02, 2020 at 09:12:30AM +0100, Loic Poulain wrote: > Fix the following warning with explicit cast: > > warning: implicit conversion from 'unsigned long long' to > 'dma_addr_t' (aka 'unsigned int') > mhi_cntrl->iova_stop = DMA_BIT_MASK(info->dma_data_width); > > Fixes: 855a70c12021 ("bus: mhi: Add MHI PCI support for WWAN modems") > Signed-off-by: Loic Poulain <loic.poulain@linaro.org> > Reported-by: kernel test robot <lkp@intel.com> > Reviewed-by: Nathan Chancellor <natechancellor@gmail.com> Applied to mhi-next! Thanks, Mani > --- > v2: Add fixes tag > > drivers/bus/mhi/pci_generic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c > index cfee0db..0912885 100644 > --- a/drivers/bus/mhi/pci_generic.c > +++ b/drivers/bus/mhi/pci_generic.c > @@ -406,7 +406,7 @@ static int mhi_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) > mhi_initialize_controller(mhi_cntrl); > mhi_cntrl->cntrl_dev = &pdev->dev; > mhi_cntrl->iova_start = 0; > - mhi_cntrl->iova_stop = DMA_BIT_MASK(info->dma_data_width); > + mhi_cntrl->iova_stop = (dma_addr_t)DMA_BIT_MASK(info->dma_data_width); > mhi_cntrl->fw_image = info->fw; > mhi_cntrl->edl_image = info->edl; > > -- > 2.7.4 >
diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c index cfee0db..0912885 100644 --- a/drivers/bus/mhi/pci_generic.c +++ b/drivers/bus/mhi/pci_generic.c @@ -406,7 +406,7 @@ static int mhi_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) mhi_initialize_controller(mhi_cntrl); mhi_cntrl->cntrl_dev = &pdev->dev; mhi_cntrl->iova_start = 0; - mhi_cntrl->iova_stop = DMA_BIT_MASK(info->dma_data_width); + mhi_cntrl->iova_stop = (dma_addr_t)DMA_BIT_MASK(info->dma_data_width); mhi_cntrl->fw_image = info->fw; mhi_cntrl->edl_image = info->edl;
Fix the following warning with explicit cast: warning: implicit conversion from 'unsigned long long' to 'dma_addr_t' (aka 'unsigned int') mhi_cntrl->iova_stop = DMA_BIT_MASK(info->dma_data_width); Fixes: 855a70c12021 ("bus: mhi: Add MHI PCI support for WWAN modems") Signed-off-by: Loic Poulain <loic.poulain@linaro.org> Reported-by: kernel test robot <lkp@intel.com> Reviewed-by: Nathan Chancellor <natechancellor@gmail.com> --- v2: Add fixes tag drivers/bus/mhi/pci_generic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4