| Message ID | 20201201123932.12312-8-martin.kepplinger@puri.sm |
|---|---|
| State | New |
| Headers | show |
| Series | imx8mq: updates for the interconnect fabric | expand |
On 1.12.20 14:39, Martin Kepplinger wrote: > Enable INTERCONNECT_IMX8MQ in order to make interconnect more widely > available for testing. I hope that it's not just for testing, but using it. > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> > --- > arch/arm64/configs/defconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index 1fed16950a7c..830c26a95b3d 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -1023,7 +1023,8 @@ CONFIG_OPTEE=y > CONFIG_MUX_MMIO=y > CONFIG_SLIM_QCOM_CTRL=m > CONFIG_SLIM_QCOM_NGD_CTRL=m > -CONFIG_INTERCONNECT=y Why are you removing this line? Thanks, Georgi > +CONFIG_INTERCONNECT_IMX=m > +CONFIG_INTERCONNECT_IMX8MQ=m > CONFIG_INTERCONNECT_QCOM=y > CONFIG_INTERCONNECT_QCOM_MSM8916=m > CONFIG_INTERCONNECT_QCOM_SDM845=m >
On Tue, Dec 01, 2020 at 01:39:32PM +0100, Martin Kepplinger wrote: > Enable INTERCONNECT_IMX8MQ in order to make interconnect more widely > available for testing. > > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> > --- > arch/arm64/configs/defconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof
On Tue, Dec 01, 2020 at 02:15:04PM +0100, Martin Kepplinger wrote: > On 01.12.20 14:10, Georgi Djakov wrote: > > On 1.12.20 14:39, Martin Kepplinger wrote: > > > Enable INTERCONNECT_IMX8MQ in order to make interconnect more widely > > > available for testing. > > > > I hope that it's not just for testing, but using it. > > sure, I just think that most people will use their own config for production > but that's a different story. I can rephrase. > > > > > > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> > > > --- > > > arch/arm64/configs/defconfig | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > > > index 1fed16950a7c..830c26a95b3d 100644 > > > --- a/arch/arm64/configs/defconfig > > > +++ b/arch/arm64/configs/defconfig > > > @@ -1023,7 +1023,8 @@ CONFIG_OPTEE=y > > > CONFIG_MUX_MMIO=y > > > CONFIG_SLIM_QCOM_CTRL=m > > > CONFIG_SLIM_QCOM_NGD_CTRL=m > > > -CONFIG_INTERCONNECT=y > > > > Why are you removing this line? > > savedefconfig removes it. INTERCONNECT_IMX below depends on it. It's save to remove it as other Interconnect options are directly dependant. Best regards, Krzysztof
On Wed, 2 Dec 2020 at 10:03, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On Tue, Dec 01, 2020 at 02:15:04PM +0100, Martin Kepplinger wrote: > > On 01.12.20 14:10, Georgi Djakov wrote: > > > On 1.12.20 14:39, Martin Kepplinger wrote: > > > > Enable INTERCONNECT_IMX8MQ in order to make interconnect more widely > > > > available for testing. > > > > > > I hope that it's not just for testing, but using it. > > > > sure, I just think that most people will use their own config for production > > but that's a different story. I can rephrase. > > > > > > > > > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> > > > > --- > > > > arch/arm64/configs/defconfig | 3 ++- > > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > > > > index 1fed16950a7c..830c26a95b3d 100644 > > > > --- a/arch/arm64/configs/defconfig > > > > +++ b/arch/arm64/configs/defconfig > > > > @@ -1023,7 +1023,8 @@ CONFIG_OPTEE=y > > > > CONFIG_MUX_MMIO=y > > > > CONFIG_SLIM_QCOM_CTRL=m > > > > CONFIG_SLIM_QCOM_NGD_CTRL=m > > > > -CONFIG_INTERCONNECT=y > > > > > > Why are you removing this line? > > > > savedefconfig removes it. INTERCONNECT_IMX below depends on it. > > It's save to remove it as other Interconnect options are directly > dependant. Ugh, my bad, it is not allowed to remove it. My review was too fast. INTERCONNECT_IMX depends on it, so the INTERCONNECT must stay, It is selected by TEGRA_MC which is independent here, so you should keep it. Best regards, Krzysztof
On 02.12.20 09:05, Krzysztof Kozlowski wrote: > On Wed, 2 Dec 2020 at 10:03, Krzysztof Kozlowski <krzk@kernel.org> wrote: >> >> On Tue, Dec 01, 2020 at 02:15:04PM +0100, Martin Kepplinger wrote: >>> On 01.12.20 14:10, Georgi Djakov wrote: >>>> On 1.12.20 14:39, Martin Kepplinger wrote: >>>>> Enable INTERCONNECT_IMX8MQ in order to make interconnect more widely >>>>> available for testing. >>>> >>>> I hope that it's not just for testing, but using it. >>> >>> sure, I just think that most people will use their own config for production >>> but that's a different story. I can rephrase. >>> >>>> >>>>> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> >>>>> --- >>>>> arch/arm64/configs/defconfig | 3 ++- >>>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig >>>>> index 1fed16950a7c..830c26a95b3d 100644 >>>>> --- a/arch/arm64/configs/defconfig >>>>> +++ b/arch/arm64/configs/defconfig >>>>> @@ -1023,7 +1023,8 @@ CONFIG_OPTEE=y >>>>> CONFIG_MUX_MMIO=y >>>>> CONFIG_SLIM_QCOM_CTRL=m >>>>> CONFIG_SLIM_QCOM_NGD_CTRL=m >>>>> -CONFIG_INTERCONNECT=y >>>> >>>> Why are you removing this line? >>> >>> savedefconfig removes it. INTERCONNECT_IMX below depends on it. >> >> It's save to remove it as other Interconnect options are directly >> dependant. > > Ugh, my bad, it is not allowed to remove it. My review was too fast. > INTERCONNECT_IMX depends on it, so the INTERCONNECT must stay, > > It is selected by TEGRA_MC which is independent here, so you should keep it. > thanks for reviewing! Just to be clear: We're talking about defconfig, so if I keep INTERCONNECT that means that I do `make savedefconfig` which removes it (it's of course still enabled, just redundant in defconfig output), and then *manually* add INTERCONNECT. That would indicate that there's a Kconfig bug. thanks, martin
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 1fed16950a7c..830c26a95b3d 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -1023,7 +1023,8 @@ CONFIG_OPTEE=y CONFIG_MUX_MMIO=y CONFIG_SLIM_QCOM_CTRL=m CONFIG_SLIM_QCOM_NGD_CTRL=m -CONFIG_INTERCONNECT=y +CONFIG_INTERCONNECT_IMX=m +CONFIG_INTERCONNECT_IMX8MQ=m CONFIG_INTERCONNECT_QCOM=y CONFIG_INTERCONNECT_QCOM_MSM8916=m CONFIG_INTERCONNECT_QCOM_SDM845=m
Enable INTERCONNECT_IMX8MQ in order to make interconnect more widely available for testing. Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> --- arch/arm64/configs/defconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)