| Message ID | 20201125090608.28442-1-zajec5@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [V2] tty: serial: bcm63xx: lower driver dependencies | expand |
On 11/25/2020 1:06 AM, Rafał Miłecki wrote: > From: Rafał Miłecki <rafal@milecki.pl> > > Hardware supported by bcm63xx is also used by BCM4908 SoCs family that > is ARM64. In future more architectures may need it as well. There is > nothing arch specific breaking compilation so just stick to requiring > COMMON_CLK. > > Signed-off-by: Rafał Miłecki <rafal@milecki.pl> Acked-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian
On Wed, Nov 25, 2020 at 10:08 AM Rafał Miłecki <zajec5@gmail.com> wrote: > From: Rafał Miłecki <rafal@milecki.pl> > > Hardware supported by bcm63xx is also used by BCM4908 SoCs family that > is ARM64. In future more architectures may need it as well. There is > nothing arch specific breaking compilation so just stick to requiring > COMMON_CLK. > > Signed-off-by: Rafał Miłecki <rafal@milecki.pl> NAKed-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > V2: Just drop all ARCH_* dependencies. Thanks Greg! Greg, please stop suggesting to make the user's life harder. > --- a/drivers/tty/serial/Kconfig > +++ b/drivers/tty/serial/Kconfig > @@ -1133,7 +1133,7 @@ config SERIAL_TIMBERDALE > config SERIAL_BCM63XX > tristate "Broadcom BCM63xx/BCM33xx UART support" > select SERIAL_CORE > - depends on MIPS || ARM || COMPILE_TEST > + depends on COMMON_CLK > help > This enables the driver for the onchip UART core found on > the following chipsets: Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On 08.12.2020 11:47, Geert Uytterhoeven wrote: > On Wed, Nov 25, 2020 at 10:08 AM Rafał Miłecki <zajec5@gmail.com> wrote: >> From: Rafał Miłecki <rafal@milecki.pl> >> >> Hardware supported by bcm63xx is also used by BCM4908 SoCs family that >> is ARM64. In future more architectures may need it as well. There is >> nothing arch specific breaking compilation so just stick to requiring >> COMMON_CLK. >> >> Signed-off-by: Rafał Miłecki <rafal@milecki.pl> > > NAKed-by: Geert Uytterhoeven <geert+renesas@glider.be> I'm happy to fix that once maintainers agree on how to handle deps like that and ideally we have if officially documented.
diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index 28f22e58639c..cc67f02f5c32 100644 --- a/drivers/tty/serial/Kconfig +++ b/drivers/tty/serial/Kconfig @@ -1133,7 +1133,7 @@ config SERIAL_TIMBERDALE config SERIAL_BCM63XX tristate "Broadcom BCM63xx/BCM33xx UART support" select SERIAL_CORE - depends on MIPS || ARM || COMPILE_TEST + depends on COMMON_CLK help This enables the driver for the onchip UART core found on the following chipsets: