diff mbox series

[2/2] arm64: dts: imx8mm-beacon-som: Fix PMIC clock error

Message ID 20201125210339.1071419-2-aford173@gmail.com
State Superseded
Headers show
Series None | expand

Commit Message

Adam Ford Nov. 25, 2020, 9:03 p.m. UTC
The PMIC throws an errors because the clock isn't assigned to it.
Fix this by assigning the clocks info.

Fixes:  acb01032e11a ("arm64: defconfig: Enable clock driver for ROHM BD718x7 PMIC")

Signed-off-by: Adam Ford <aford173@gmail.com>

Comments

Krzysztof Kozlowski Nov. 26, 2020, 8:07 a.m. UTC | #1
On Wed, Nov 25, 2020 at 03:03:39PM -0600, Adam Ford wrote:
> The PMIC throws an errors because the clock isn't assigned to it.

> Fix this by assigning the clocks info.

> 

> Fixes:  acb01032e11a ("arm64: defconfig: Enable clock driver for ROHM BD718x7 PMIC")


Hi,

This is not the correct Fixes tag. The defconfig change did not
introduce any bug in DTS. The error message was there before, regardless
of defconfigs. Defconfigs are merely a development or distro aid, not a
definition of working state.

If it really was a bug, then the commit adding DTS is to blame.

Second, I am not sure if there is a bug here to fix - having incomplete
DTS is a bug? Missing device nodes in DTS is a bug?

Also, pay attention to proper white spaces. There is only single
whitespace after ':' and no blank line after entire Fixes tag.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
index 9bdefbba9e90..d897913537ca 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
@@ -111,6 +111,10 @@  pmic@4b {
 		interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
 		rohm,reset-snvs-powered;
 
+		#clock-cells = <0>;
+		clocks = <&osc_32k 0>;
+		clock-output-names = "clk-32k-out";
+
 		regulators {
 			buck1_reg: BUCK1 {
 				regulator-name = "buck1";