Remove duplicate $top_srcdir/include

Message ID	1404822596-8160-1-git-send-email-anders.roxell@linaro.org
State	Accepted
Commit	8f18dbb515fce7b11734b63bfaeaf48be9b71f21
Headers	show Return-Path: <patchwork-forward+bncBD5JHFX53YCBBXGI56OQKGQEEKSEKZQ@linaro.org> Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.180 as permitted sender) client-ip=209.85.128.180; Received-SPF: none (google.com: lng-odp-bounces@lists.linaro.org does not designate permitted sender hosts) client-ip=54.225.227.206; From: Anders Roxell <anders.roxell@linaro.org> To: lng-odp@lists.linaro.org Date: Tue, 8 Jul 2014 14:29:56 +0200 Message-Id: <1404822596-8160-1-git-send-email-anders.roxell@linaro.org> Subject: [lng-odp] [PATCH] Remove duplicate $top_srcdir/include Precedence: list MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: lng-odp-bounces@lists.linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit

Message ID

1404822596-8160-1-git-send-email-anders.roxell@linaro.org

State

Accepted

Commit

8f18dbb515fce7b11734b63bfaeaf48be9b71f21

Headers

Received-SPF: pass (google.com: domain of
	patch+caf_=patchwork-forward=linaro.org@linaro.org designates
	209.85.128.180 as permitted sender) client-ip=209.85.128.180; 
Received-SPF: none (google.com: lng-odp-bounces@lists.linaro.org does not
	designate permitted sender hosts) client-ip=54.225.227.206; 
From: Anders Roxell <anders.roxell@linaro.org>
To: lng-odp@lists.linaro.org
Date: Tue,  8 Jul 2014 14:29:56 +0200
Message-Id: <1404822596-8160-1-git-send-email-anders.roxell@linaro.org>
Subject: [lng-odp] [PATCH] Remove duplicate $top_srcdir/include
Precedence: list
MIME-Version: 1.0
Errors-To: lng-odp-bounces@lists.linaro.org
Sender: lng-odp-bounces@lists.linaro.org
Mailing-list: list patchwork-forward@linaro.org;
	contact patchwork-forward+owners@linaro.org
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

Commit Message

Anders Roxell July 8, 2014, 12:29 p.m. UTC

Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
 Makefile.inc                         | 1 +
 platform/linux-generic/Makefile.am   | 1 +
 platform/linux-keystone2/Makefile.am | 1 +
 test/Makefile.inc                    | 1 +
 4 files changed, 4 insertions(+)
 create mode 100644 Makefile.inc

Comments

Venkatesh Vivekanandan July 8, 2014, 12:35 p.m. UTC | #1

On 8 July 2014 17:59, Anders Roxell <anders.roxell@linaro.org> wrote:

> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
>  Makefile.inc                         | 1 +
>  platform/linux-generic/Makefile.am   | 1 +
>  platform/linux-keystone2/Makefile.am | 1 +
>  test/Makefile.inc                    | 1 +
>  4 files changed, 4 insertions(+)
>  create mode 100644 Makefile.inc
>
> diff --git a/Makefile.inc b/Makefile.inc
> new file mode 100644
> index 0000000..fa3fac4
> --- /dev/null
> +++ b/Makefile.inc
> @@ -0,0 +1 @@
> +DEFAULT_INCLUDES=-I.
> diff --git a/platform/linux-generic/Makefile.am
> b/platform/linux-generic/Makefile.am
> index 34b13d3..749482f 100644
> --- a/platform/linux-generic/Makefile.am
> +++ b/platform/linux-generic/Makefile.am
> @@ -1,3 +1,4 @@
> +include $(top_srcdir)/Makefile.inc
>  LIB   = $(top_builddir)/lib
>
>  dist_pkgdata_DATA = $(LIB)/libodp.la
> diff --git a/platform/linux-keystone2/Makefile.am
> b/platform/linux-keystone2/Makefile.am
> index e9713b2..0cd4be3 100644
> --- a/platform/linux-keystone2/Makefile.am
> +++ b/platform/linux-keystone2/Makefile.am
> @@ -1,3 +1,4 @@
> +include $(top_srcdir)/Makefile.inc
>  LIB   = $(top_builddir)/lib
>
>  dist_pkgdata_DATA = $(LIB)/libodp.la
> diff --git a/test/Makefile.inc b/test/Makefile.inc
> index 1884d16..6747b53 100644
> --- a/test/Makefile.inc
> +++ b/test/Makefile.inc
> @@ -1,3 +1,4 @@
> +include $(top_srcdir)/Makefile.inc
>  LIB   = $(top_builddir)/lib
>  LDADD = $(LIB)/libodp.la
>  AM_CFLAGS += -I$(top_srcdir)/platform/@with_platform@/include/api
> -I$(top_srcdir)/platform/linux-generic/include/api -I$(top_srcdir)/include
>

Patch looks good to me.


> --
> 1.9.1
>
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> http://lists.linaro.org/mailman/listinfo/lng-odp
>

Mike Holmes July 8, 2014, 4:31 p.m. UTC | #2

Reviewed-by mike.holmes@linaro.org



On 8 July 2014 08:35, Venkatesh Vivekanandan <
venkatesh.vivekanandan@linaro.org> wrote:

>
>
>
> On 8 July 2014 17:59, Anders Roxell <anders.roxell@linaro.org> wrote:
>
>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>> ---
>>  Makefile.inc                         | 1 +
>>  platform/linux-generic/Makefile.am   | 1 +
>>  platform/linux-keystone2/Makefile.am | 1 +
>>  test/Makefile.inc                    | 1 +
>>  4 files changed, 4 insertions(+)
>>  create mode 100644 Makefile.inc
>>
>> diff --git a/Makefile.inc b/Makefile.inc
>> new file mode 100644
>> index 0000000..fa3fac4
>> --- /dev/null
>> +++ b/Makefile.inc
>> @@ -0,0 +1 @@
>> +DEFAULT_INCLUDES=-I.
>> diff --git a/platform/linux-generic/Makefile.am
>> b/platform/linux-generic/Makefile.am
>> index 34b13d3..749482f 100644
>> --- a/platform/linux-generic/Makefile.am
>> +++ b/platform/linux-generic/Makefile.am
>> @@ -1,3 +1,4 @@
>> +include $(top_srcdir)/Makefile.inc
>>  LIB   = $(top_builddir)/lib
>>
>>  dist_pkgdata_DATA = $(LIB)/libodp.la
>> diff --git a/platform/linux-keystone2/Makefile.am
>> b/platform/linux-keystone2/Makefile.am
>> index e9713b2..0cd4be3 100644
>> --- a/platform/linux-keystone2/Makefile.am
>> +++ b/platform/linux-keystone2/Makefile.am
>> @@ -1,3 +1,4 @@
>> +include $(top_srcdir)/Makefile.inc
>>  LIB   = $(top_builddir)/lib
>>
>>  dist_pkgdata_DATA = $(LIB)/libodp.la
>> diff --git a/test/Makefile.inc b/test/Makefile.inc
>> index 1884d16..6747b53 100644
>> --- a/test/Makefile.inc
>> +++ b/test/Makefile.inc
>> @@ -1,3 +1,4 @@
>> +include $(top_srcdir)/Makefile.inc
>>  LIB   = $(top_builddir)/lib
>>  LDADD = $(LIB)/libodp.la
>>  AM_CFLAGS += -I$(top_srcdir)/platform/@with_platform@/include/api
>> -I$(top_srcdir)/platform/linux-generic/include/api -I$(top_srcdir)/include
>>
>
> Patch looks good to me.
>
>
>> --
>> 1.9.1
>>
>>
>> _______________________________________________
>> lng-odp mailing list
>> lng-odp@lists.linaro.org
>> http://lists.linaro.org/mailman/listinfo/lng-odp
>>
>
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> http://lists.linaro.org/mailman/listinfo/lng-odp
>
>

Taras Kondratiuk July 8, 2014, 5:55 p.m. UTC | #3

On 07/08/2014 03:29 PM, Anders Roxell wrote:
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
>   Makefile.inc                         | 1 +
>   platform/linux-generic/Makefile.am   | 1 +
>   platform/linux-keystone2/Makefile.am | 1 +
>   test/Makefile.inc                    | 1 +
>   4 files changed, 4 insertions(+)
>   create mode 100644 Makefile.inc

Reviewed-and-Tested-by: Taras Kondratiuk <taras.kondratiuk@linaro.org>

Maxim Uvarov July 9, 2014, 6:47 a.m. UTC | #4

Thanks, applied!

Maxim.

On 07/08/2014 04:29 PM, Anders Roxell wrote:
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
>   Makefile.inc                         | 1 +
>   platform/linux-generic/Makefile.am   | 1 +
>   platform/linux-keystone2/Makefile.am | 1 +
>   test/Makefile.inc                    | 1 +
>   4 files changed, 4 insertions(+)
>   create mode 100644 Makefile.inc
>
> diff --git a/Makefile.inc b/Makefile.inc
> new file mode 100644
> index 0000000..fa3fac4
> --- /dev/null
> +++ b/Makefile.inc
> @@ -0,0 +1 @@
> +DEFAULT_INCLUDES=-I.
> diff --git a/platform/linux-generic/Makefile.am b/platform/linux-generic/Makefile.am
> index 34b13d3..749482f 100644
> --- a/platform/linux-generic/Makefile.am
> +++ b/platform/linux-generic/Makefile.am
> @@ -1,3 +1,4 @@
> +include $(top_srcdir)/Makefile.inc
>   LIB   = $(top_builddir)/lib
>   
>   dist_pkgdata_DATA = $(LIB)/libodp.la
> diff --git a/platform/linux-keystone2/Makefile.am b/platform/linux-keystone2/Makefile.am
> index e9713b2..0cd4be3 100644
> --- a/platform/linux-keystone2/Makefile.am
> +++ b/platform/linux-keystone2/Makefile.am
> @@ -1,3 +1,4 @@
> +include $(top_srcdir)/Makefile.inc
>   LIB   = $(top_builddir)/lib
>   
>   dist_pkgdata_DATA = $(LIB)/libodp.la
> diff --git a/test/Makefile.inc b/test/Makefile.inc
> index 1884d16..6747b53 100644
> --- a/test/Makefile.inc
> +++ b/test/Makefile.inc
> @@ -1,3 +1,4 @@
> +include $(top_srcdir)/Makefile.inc
>   LIB   = $(top_builddir)/lib
>   LDADD = $(LIB)/libodp.la
>   AM_CFLAGS += -I$(top_srcdir)/platform/@with_platform@/include/api -I$(top_srcdir)/platform/linux-generic/include/api -I$(top_srcdir)/include

diff --git a/Makefile.inc b/Makefile.inc
new file mode 100644
index 0000000..fa3fac4
--- /dev/null
+++ b/Makefile.inc
@@ -0,0 +1 @@ 
+DEFAULT_INCLUDES=-I.
diff --git a/platform/linux-generic/Makefile.am b/platform/linux-generic/Makefile.am
index 34b13d3..749482f 100644
--- a/platform/linux-generic/Makefile.am
+++ b/platform/linux-generic/Makefile.am
@@ -1,3 +1,4 @@ 
+include $(top_srcdir)/Makefile.inc
 LIB   = $(top_builddir)/lib
 
 dist_pkgdata_DATA = $(LIB)/libodp.la
diff --git a/platform/linux-keystone2/Makefile.am b/platform/linux-keystone2/Makefile.am
index e9713b2..0cd4be3 100644
--- a/platform/linux-keystone2/Makefile.am
+++ b/platform/linux-keystone2/Makefile.am
@@ -1,3 +1,4 @@ 
+include $(top_srcdir)/Makefile.inc
 LIB   = $(top_builddir)/lib
 
 dist_pkgdata_DATA = $(LIB)/libodp.la
diff --git a/test/Makefile.inc b/test/Makefile.inc
index 1884d16..6747b53 100644
--- a/test/Makefile.inc
+++ b/test/Makefile.inc
@@ -1,3 +1,4 @@ 
+include $(top_srcdir)/Makefile.inc
 LIB   = $(top_builddir)/lib
 LDADD = $(LIB)/libodp.la
 AM_CFLAGS += -I$(top_srcdir)/platform/@with_platform@/include/api -I$(top_srcdir)/platform/linux-generic/include/api -I$(top_srcdir)/include