[5.4,029/158] net/mlx5: Add handling of port type in rule deletion

From: Michael Guralnik <michaelgur@nvidia.com>

From: Michael Guralnik <michaelgur@nvidia.com>

[ Upstream commit 8cbcc5ef2a281f6bb10099f4572a08cb765ffbf4 ]

Handle destruction of rules with port destination type to enable
full destruction of flow.

Without this handling of TX rules the deletion of these rules fails.
Dmesg of flow destruction failure:

[  203.714146] mlx5_core 0000:00:0b.0: mlx5_cmd_check:753:(pid 342): SET_FLOW_TABLE_ENTRY(0x936) op_mod(0x0) failed, status bad parameter(0x3), syndrome (0x144b7a)
[  210.547387] ------------[ cut here ]------------
[  210.548663] refcount_t: decrement hit 0; leaking memory.
[  210.550651] WARNING: CPU: 4 PID: 342 at lib/refcount.c:31 refcount_warn_saturate+0x5c/0x110
[  210.550654] Modules linked in: mlx5_ib mlx5_core ib_ipoib rdma_ucm rdma_cm iw_cm ib_cm ib_umad ib_uverbs ib_core
[  210.550675] CPU: 4 PID: 342 Comm: test Not tainted 5.8.0-rc2+ #116
[  210.550678] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS rel-1.12.1-0-ga5cab58e9a3f-prebuilt.qemu.org 04/01/2014
[  210.550680] RIP: 0010:refcount_warn_saturate+0x5c/0x110
[  210.550685] Code: c6 d1 1b 01 00 0f 84 ad 00 00 00 5b 5d c3 80 3d b5 d1 1b 01 00 75 f4 48 c7 c7 20 d1 15 82 c6 05 a5 d1 1b 01 01 e8 a7 eb af ff <0f> 0b eb dd 80 3d 99 d1 1b 01 00 75 d4 48 c7 c7 c0 cf 15 82 c6 05
[  210.550687] RSP: 0018:ffff8881642e77e8 EFLAGS: 00010282
[  210.550691] RAX: 0000000000000000 RBX: 0000000000000004 RCX: 0000000000000000
[  210.550694] RDX: 0000000000000027 RSI: 0000000000000004 RDI: ffffed102c85ceef
[  210.550696] RBP: ffff888161720428 R08: ffffffff8124c10e R09: ffffed103243beae
[  210.550698] R10: ffff8881921df56b R11: ffffed103243bead R12: ffff8881841b4180
[  210.550701] R13: ffff888161720428 R14: ffff8881616d0000 R15: ffff888161720380
[  210.550704] FS:  00007fc27f025740(0000) GS:ffff888192000000(0000) knlGS:0000000000000000
[  210.550706] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[  210.550708] CR2: 0000557e4b41a6a0 CR3: 0000000002415004 CR4: 0000000000360ea0
[  210.550711] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[  210.550713] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[  210.550715] Call Trace:
[  210.550717]  mlx5_del_flow_rules+0x484/0x490 [mlx5_core]
[  210.550720]  ? mlx5_cmd_set_fte+0xa80/0xa80 [mlx5_core]
[  210.550722]  mlx5_ib_destroy_flow+0x17f/0x280 [mlx5_ib]
[  210.550724]  uverbs_free_flow+0x4c/0x90 [ib_uverbs]
[  210.550726]  destroy_hw_idr_uobject+0x41/0xb0 [ib_uverbs]
[  210.550728]  uverbs_destroy_uobject+0xaa/0x390 [ib_uverbs]
[  210.550731]  __uverbs_cleanup_ufile+0x129/0x1b0 [ib_uverbs]
[  210.550733]  ? uverbs_destroy_uobject+0x390/0x390 [ib_uverbs]
[  210.550735]  uverbs_destroy_ufile_hw+0x78/0x190 [ib_uverbs]
[  210.550737]  ib_uverbs_close+0x36/0x140 [ib_uverbs]
[  210.550739]  __fput+0x181/0x380
[  210.550741]  task_work_run+0x88/0xd0
[  210.550743]  do_exit+0x5f6/0x13b0
[  210.550745]  ? sched_clock_cpu+0x30/0x140
[  210.550747]  ? is_current_pgrp_orphaned+0x70/0x70
[  210.550750]  ? lock_downgrade+0x360/0x360
[  210.550752]  ? mark_held_locks+0x1d/0x90
[  210.550754]  do_group_exit+0x8a/0x140
[  210.550756]  get_signal+0x20a/0xf50
[  210.550758]  do_signal+0x8c/0xbe0
[  210.550760]  ? hrtimer_nanosleep+0x1d8/0x200
[  210.550762]  ? nanosleep_copyout+0x50/0x50
[  210.550764]  ? restore_sigcontext+0x320/0x320
[  210.550766]  ? __hrtimer_init+0xf0/0xf0
[  210.550768]  ? timespec64_add_safe+0x150/0x150
[  210.550770]  ? mark_held_locks+0x1d/0x90
[  210.550772]  ? lockdep_hardirqs_on_prepare+0x14c/0x240
[  210.550774]  __prepare_exit_to_usermode+0x119/0x170
[  210.550776]  do_syscall_64+0x65/0x300
[  210.550778]  ? trace_hardirqs_off+0x10/0x120
[  210.550781]  ? mark_held_locks+0x1d/0x90
[  210.550783]  ? asm_sysvec_apic_timer_interrupt+0xa/0x20
[  210.550785]  ? lockdep_hardirqs_on+0x112/0x190
[  210.550787]  entry_SYSCALL_64_after_hwframe+0x44/0xa9
[  210.550789] RIP: 0033:0x7fc27f1cd157
[  210.550791] Code: Bad RIP value.
[  210.550793] RSP: 002b:00007ffd4db27ea8 EFLAGS: 00000246 ORIG_RAX: 0000000000000023
[  210.550798] RAX: fffffffffffffdfc RBX: ffffffffffffff80 RCX: 00007fc27f1cd157
[  210.550800] RDX: 00007fc27f025740 RSI: 00007ffd4db27eb0 RDI: 00007ffd4db27eb0
[  210.550803] RBP: 0000000000000016 R08: 0000000000000000 R09: 000000000000000e
[  210.550805] R10: 00007ffd4db27dc7 R11: 0000000000000246 R12: 0000000000400c00
[  210.550808] R13: 00007ffd4db285f0 R14: 0000000000000000 R15: 0000000000000000
[  210.550809] irq event stamp: 49399
[  210.550812] hardirqs last  enabled at (49399): [<ffffffff81172d36>] console_unlock+0x556/0x6f0
[  210.550815] hardirqs last disabled at (49398): [<ffffffff81172897>] console_unlock+0xb7/0x6f0
[  210.550818] softirqs last  enabled at (48706): [<ffffffff81e0037b>] __do_softirq+0x37b/0x60c
[  210.550820] softirqs last disabled at (48697): [<ffffffff81c00e2f>] asm_call_on_stack+0xf/0x20
[  210.550822] ---[ end trace ad18c0e6fa846454 ]---
[  210.581862] mlx5_core 0000:00:0c.0: mlx5_destroy_flow_table:2132:(pid 342): Flow table 262150 wasn't destroyed, refcount > 1

Fixes: a7ee18bdee83 ("RDMA/mlx5: Allow creating a matcher for a NIC TX flow table")
Signed-off-by: Michael Guralnik <michaelgur@nvidia.com>
Reviewed-by: Mark Bloch <mbloch@nvidia.com>
Reviewed-by: Maor Gottlieb <maorg@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/net/ethernet/mellanox/mlx5/core/fs_core.c |    7 +++++++
 1 file changed, 7 insertions(+)

Message ID	20201123121821.342313435@linuxfoundation.org
State	Superseded
Headers	show Return-Path: <stable-owner@kernel.org> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, stable@vger.kernel.org, Michael Guralnik <michaelgur@nvidia.com>, Mark Bloch <mbloch@nvidia.com>, Maor Gottlieb <maorg@nvidia.com>, Saeed Mahameed <saeedm@nvidia.com> Subject: [PATCH 5.4 029/158] net/mlx5: Add handling of port type in rule deletion Date: Mon, 23 Nov 2020 13:20:57 +0100 Message-Id: <20201123121821.342313435@linuxfoundation.org> In-Reply-To: <20201123121819.943135899@linuxfoundation.org> References: <20201123121819.943135899@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	None \| expand [5.4,002/158] atm: nicstar: Unmap DMA on send error [5.4,003/158] bnxt_en: read EEPROM A2h address using page 0 [5.4,004/158] devlink: Add missing genlmsg_cancel() in devlink_nl_sb_port_pool_fill() [5.4,005/158] Exempt multicast addresses from five-second neighbor lifetime [5.4,006/158] inet_diag: Fix error path to cancel the meseage in inet_req_diag_fill() [5.4,007/158] ipv6: Fix error path to cancel the meseage [5.4,008/158] lan743x: fix issue causing intermittent kernel log warnings [5.4,009/158] lan743x: prevent entire kernel HANG on open, for some platforms [5.4,010/158] mlxsw: core: Use variable timeout for EMAD retries [5.4,011/158] net: b44: fix error return code in b44_init_one() [5.4,012/158] net: bridge: add missing counters to ndo_get_stats64 callback [5.4,013/158] net: dsa: mv88e6xxx: Avoid VTU corruption on 6097 [5.4,014/158] net: ethernet: ti: cpsw: fix error return code in cpsw_probe() [5.4,015/158] net: Have netpoll bring-up DSA management interface [5.4,016/158] netlabel: fix our progress tracking in netlbl_unlabel_staticlist() [5.4,017/158] netlabel: fix an uninitialized warning in netlbl_unlabel_staticlist() [5.4,018/158] net: lantiq: Wait for the GPHY firmware to be ready [5.4,019/158] net/mlx4_core: Fix init_hca fields offset [5.4,020/158] net: qualcomm: rmnet: Fix incorrect receive packet handling during cleanup [5.4,021/158] net/smc: fix direct access to ib_gid_addr->ndev in smc_ib_determine_gid() [5.4,022/158] net/tls: fix corrupted data in recvmsg [5.4,023/158] net: x25: Increase refcnt of "struct x25_neigh" in x25_rx_call_request [5.4,024/158] page_frag: Recover from memory pressure [5.4,025/158] qed: fix error return code in qed_iwarp_ll2_start() [5.4,026/158] qlcnic: fix error return code in qlcnic_83xx_restart_hw() [5.4,027/158] sctp: change to hold/put transport for proto_unreach_timer [5.4,028/158] tcp: only postpone PROBE_RTT if RTT is < current min_rtt estimate [5.4,029/158] net/mlx5: Add handling of port type in rule deletion [5.4,030/158] net/mlx5: Disable QoS when min_rates on all VFs are zero [5.4,031/158] net: usb: qmi_wwan: Set DTR quirk for MR400 [5.4,032/158] net/ncsi: Fix netlink registration [5.4,033/158] net: ftgmac100: Fix crash when removing driver [5.4,034/158] pinctrl: rockchip: enable gpio pclk for rockchip_gpio_to_irq [5.4,035/158] scsi: ufs: Fix unbalanced scsi_block_reqs_cnt caused by ufshcd_hold() [5.4,036/158] selftests: kvm: Fix the segment descriptor layout to match the actual layout [5.4,037/158] ACPI: button: Add DMI quirk for Medion Akoya E2228T [5.4,038/158] arm64: errata: Fix handling of 1418040 with late CPU onlining [5.4,039/158] arm64: psci: Avoid printing in cpu_psci_cpu_die() [5.4,040/158] arm64: smp: Tell RCU about CPUs that fail to come online [5.4,041/158] vfs: remove lockdep bogosity in __sb_start_write [5.4,042/158] gfs2: fix possible reference leak in gfs2_check_blk_type [5.4,043/158] hwmon: (pwm-fan) Fix RPM calculation [5.4,044/158] compiler.h: fix barrier_data() on clang [5.4,045/158] arm64: dts: allwinner: beelink-gs1: Enable both RGMII RX/TX delay [5.4,046/158] arm64: dts: allwinner: Pine H64: Enable both RGMII RX/TX delay [5.4,047/158] arm64: dts: allwinner: a64: OrangePi Win: Fix ethernet node [5.4,048/158] arm64: dts: allwinner: a64: Pine64 Plus: Fix ethernet node [5.4,049/158] arm64: dts: allwinner: h5: OrangePi PC2: Fix ethernet node [5.4,050/158] ARM: dts: sun8i: r40: bananapi-m2-ultra: Fix ethernet node [5.4,051/158] Revert "arm: sun8i: orangepi-pc-plus: Set EMAC activity LEDs to active high" [5.4,052/158] ARM: dts: sun6i: a31-hummingbird: Enable RGMII RX/TX delay on Ethernet PHY [5.4,053/158] ARM: dts: sun7i: cubietruck: Enable RGMII RX/TX delay on Ethernet PHY [5.4,054/158] ARM: dts: sun7i: bananapi-m1-plus: Enable RGMII RX/TX delay on Ethernet PHY [5.4,055/158] ARM: dts: sun8i: h3: orangepi-plus2e: Enable RGMII RX/TX delay on Ethernet PHY [5.4,056/158] ARM: dts: sun8i: a83t: Enable both RGMII RX/TX delay on Ethernet PHY [5.4,057/158] ARM: dts: sun9i: Enable both RGMII RX/TX delay on Ethernet PHY [5.4,058/158] ARM: dts: sunxi: bananapi-m2-plus: Enable RGMII RX/TX delay on Ethernet PHY [5.4,059/158] arm64: dts: allwinner: a64: bananapi-m64: Enable RGMII RX/TX delay on PHY [5.4,060/158] Input: adxl34x - clean up a data type in adxl34x_probe() [5.4,061/158] MIPS: export has_transparent_hugepage() for modules [5.4,062/158] arm64: dts: allwinner: h5: OrangePi Prime: Fix ethernet node [5.4,063/158] arm64: dts imx8mn: Remove non-existent USB OTG2 [5.4,064/158] arm: dts: imx6qdl-udoo: fix rgmii phy-mode for ksz9031 phy [5.4,065/158] swiotlb: using SIZE_MAX needs limits.h included [5.4,066/158] arm64: dts: imx8mm: fix voltage for 1.6GHz CPU operating point [5.4,067/158] ARM: dts: imx50-evk: Fix the chip select 1 IOMUX [5.4,068/158] Input: resistive-adc-touch - fix kconfig dependency on IIO_BUFFER [5.4,069/158] rfkill: Fix use-after-free in rfkill_resume() [5.4,070/158] RDMA/pvrdma: Fix missing kfree() in pvrdma_register_device() [5.4,071/158] RMDA/sw: Dont allow drivers using dma_virt_ops on highmem configs [5.4,072/158] perf lock: Dont free "lock_seq_stat" if read_count isnt zero [5.4,073/158] tools, bpftool: Add missing close before bpftool net attach exit [5.4,074/158] ip_tunnels: Set tunnel option flag when tunnel metadata is present [5.4,075/158] can: af_can: prevent potential access of uninitialized member in can_rcv() [5.4,076/158] can: af_can: prevent potential access of uninitialized member in canfd_rcv() [5.4,077/158] can: dev: can_restart(): post buffer from the right context [5.4,078/158] can: ti_hecc: Fix memleak in ti_hecc_probe [5.4,079/158] can: mcba_usb: mcba_usb_start_xmit(): first fill skb, then pass to can_put_echo_skb() [5.4,080/158] can: peak_usb: fix potential integer overflow on shift of a int [5.4,081/158] can: flexcan: fix failure handling of pm_runtime_get_sync() [5.4,082/158] can: tcan4x5x: replace depends on REGMAP_SPI with depends on SPI [5.4,083/158] can: tcan4x5x: tcan4x5x_can_probe(): add missing error checking for devm_regmap_init() [5.4,084/158] can: tcan4x5x: tcan4x5x_can_remove(): fix order of deregistration [5.4,085/158] can: m_can: m_can_handle_state_change(): fix state change [5.4,086/158] can: m_can: m_can_class_free_dev(): introduce new function [5.4,087/158] can: m_can: m_can_stop(): set device to software init mode before closing [5.4,088/158] ASoC: qcom: lpass-platform: Fix memory leak [5.4,089/158] selftests/bpf: Fix error return code in run_getsockopt_test() [5.4,090/158] MIPS: Alchemy: Fix memleak in alchemy_clk_setup_cpu [5.4,091/158] drm/sun4i: dw-hdmi: fix error return code in sun8i_dw_hdmi_bind() [5.4,092/158] net/mlx5: E-Switch, Fail mlx5_esw_modify_vport_rate if qos disabled [5.4,093/158] bpf, sockmap: Fix partial copy_page_to_iter so progress can still be made [5.4,094/158] bpf, sockmap: Ensure SO_RCVBUF memory is observed on ingress redirect [5.4,095/158] can: kvaser_pciefd: Fix KCAN bittiming limits [5.4,096/158] can: kvaser_usb: kvaser_usb_hydra: Fix KCAN bittiming limits [5.4,097/158] iommu/vt-d: Move intel_iommu_gfx_mapped to Intel IOMMU header [5.4,098/158] iommu/vt-d: Avoid panic if iommu init fails in tboot system [5.4,099/158] can: flexcan: flexcan_chip_start(): fix erroneous flexcan_transceiver_enable() duri... [5.4,100/158] can: m_can: process interrupt only when not runtime suspended [5.4,101/158] xfs: fix the minrecs logic when dealing with inode root child blocks [5.4,102/158] xfs: strengthen rmap record flags checking [5.4,103/158] xfs: return corresponding errcode if xfs_initialize_perag() fail [5.4,104/158] regulator: ti-abb: Fix array out of bound read access on the first transition [5.4,105/158] fail_function: Remove a redundant mutex unlock [5.4,106/158] xfs: revert "xfs: fix rmap key and record comparison functions" [5.4,107/158] bpf, sockmap: Skb verdict SK_PASS to self already checked rmem limits [5.4,108/158] bpf, sockmap: On receive programs try to fast track SK_PASS ingress [5.4,109/158] bpf, sockmap: Use truesize with sk_rmem_schedule() [5.4,110/158] bpf, sockmap: Avoid returning unneeded EAGAIN when redirecting to self [5.4,111/158] efi/x86: Free efi_pgd with free_pages() [5.4,112/158] libfs: fix error cast of negative value in simple_attr_write() [5.4,113/158] HID: logitech-hidpp: Add PID for MX Anywhere 2 [5.4,114/158] HID: logitech-dj: Handle quad/bluetooth keyboards with a builtin trackpad [5.4,115/158] HID: logitech-dj: Fix Dinovo Mini when paired with a MX5x00 receiver [5.4,116/158] speakup: Do not let the line discipline be used several times [5.4,117/158] ALSA: firewire: Clean up a locking issue in copy_resp_to_buf() [5.4,118/158] ALSA: usb-audio: Add delay quirk for all Logitech USB devices [5.4,119/158] ALSA: ctl: fix error path at adding user-defined element set [5.4,120/158] ALSA: mixart: Fix mutex deadlock [5.4,121/158] ALSA: hda/realtek - Add supported for Lenovo ThinkPad Headset Button [5.4,122/158] ALSA: hda/realtek: Add some Clove SSID in the ALC293(ALC1220) [5.4,123/158] tty: serial: imx: fix potential deadlock [5.4,124/158] tty: serial: imx: keep console clocks always on [5.4,125/158] HID: logitech-dj: Fix an error in mse_bluetooth_descriptor [5.4,126/158] efivarfs: fix memory leak in efivarfs_create() [5.4,127/158] staging: rtl8723bs: Add 024c:0627 to the list of SDIO device-ids [5.4,128/158] iio: light: fix kconfig dependency bug for VCNL4035 [5.4,129/158] ext4: fix bogus warning in ext4_update_dx_flag() [5.4,130/158] iio: accel: kxcjk1013: Replace is_smo8500_device with an acpi_type enum [5.4,131/158] iio: accel: kxcjk1013: Add support for KIOX010A ACPI DSM for setting tablet-mode [5.4,132/158] iio: adc: mediatek: fix unset field [5.4,133/158] spi: lpspi: Fix use-after-free on unbind [5.4,134/158] spi: Introduce device-managed SPI controller allocation [5.4,135/158] spi: npcm-fiu: Dont leak SPI master in probe error path [5.4,136/158] spi: bcm2835aux: Fix use-after-free on unbind [5.4,137/158] regulator: pfuze100: limit pfuze-support-disable-sw to pfuze{100,200} [5.4,138/158] regulator: fix memory leak with repeated set_machine_constraints() [5.4,139/158] regulator: avoid resolve_supply() infinite recursion [5.4,140/158] regulator: workaround self-referent regulators [5.4,141/158] xtensa: fix TLBTEMP area placement [5.4,142/158] xtensa: disable preemption around cache alias management calls [5.4,143/158] mac80211: minstrel: remove deferred sampling code [5.4,144/158] mac80211: minstrel: fix tx status processing corner case [5.4,145/158] mac80211: free sta in sta_info_insert_finish() on errors [5.4,146/158] s390/cpum_sf.c: fix file permission for cpum_sfb_size [5.4,147/158] s390/dasd: fix null pointer dereference for ERP requests [5.4,148/158] Drivers: hv: vmbus: Allow cleanup of VMBUS_CONNECT_CPU if disconnected [5.4,149/158] drm/amd/display: Add missing pflip irq for dcn2.0 [5.4,150/158] drm/i915: Handle max_bpc==16 [5.4,151/158] mmc: sdhci-pci: Prefer SDR25 timing for High Speed mode for BYT-based Intel control... [5.4,152/158] ptrace: Set PF_SUPERPRIV when checking capability [5.4,153/158] seccomp: Set PF_SUPERPRIV when checking capability [5.4,154/158] x86/microcode/intel: Check patch signature before saving microcode for early loading [5.4,155/158] mm: memcg/slab: fix root memcg vmstats [5.4,156/158] mm/userfaultfd: do not access vma->vm_mm after calling handle_userfault() [5.4,157/158] mm, page_alloc: skip ->waternark_boost for atomic order-0 allocations [5.4,158/158] sched/fair: Fix overutilized update in enqueue_task_fair()

[5.4,029/158] net/mlx5: Add handling of port type in rule deletion

Commit Message

Patch