| Message ID | 1404472432-24764-3-git-send-email-peter.griffin@linaro.org |
|---|---|
| State | New |
| Headers | show |
2014-07-04 13:13 GMT+02:00 Peter Griffin: > +Required properties: > + - compatible : must be "st,stih407-dwc3" > + - reg : glue logic base address and USB syscfg ctrl register offest > + - reg-names : Should be "reg-glue" and "syscfg-reg". > + - st,syscon : should be phandle to system configuration node which > + encompases the glue registers. > + - resets : phandle pointing to the system powerdown controller minor knits: s/offest/offset/ s/encompases/encompasses/ "Should" is upper case while all other lines in this block start with a lower case letter; two lines end with a full stop, three lines without; colons the last lines do not align to the first three
Hi Daniele, Thanks for reviewing. On Fri, 04 Jul 2014, Daniele Forsi wrote: > 2014-07-04 13:13 GMT+02:00 Peter Griffin: > > > +Required properties: > > + - compatible : must be "st,stih407-dwc3" > > + - reg : glue logic base address and USB syscfg ctrl register offest > > + - reg-names : Should be "reg-glue" and "syscfg-reg". > > + - st,syscon : should be phandle to system configuration node which > > + encompases the glue registers. > > + - resets : phandle pointing to the system powerdown controller > > minor knits: > s/offest/offset/ > s/encompases/encompasses/ > "Should" is upper case while all other lines in this block start with > a lower case letter; > two lines end with a full stop, three lines without; > colons the last lines do not align to the first three All fixed in V2. Regards, Peter. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
diff --git a/Documentation/devicetree/bindings/usb/dwc3-st.txt b/Documentation/devicetree/bindings/usb/dwc3-st.txt new file mode 100644 index 0000000..f14e5da --- /dev/null +++ b/Documentation/devicetree/bindings/usb/dwc3-st.txt @@ -0,0 +1,58 @@ +ST DWC3 glue logic + +This file documents the parameters for the dwc3-st driver. +This driver provides the glue logic to use the dwc3 on STiH407 based platforms. + +Required properties: + - compatible : must be "st,stih407-dwc3" + - reg : glue logic base address and USB syscfg ctrl register offest + - reg-names : Should be "reg-glue" and "syscfg-reg". + - st,syscon : should be phandle to system configuration node which + encompases the glue registers. + - resets : phandle pointing to the system powerdown controller +See: Documentation/devicetree/bindings/reset/st,sti-powerdown.txt +See: Documentation/devicetree/bindings/reset/reset.txt + + - #address-cells, #size-cells : should be '1' if the device has sub-nodes + with 'reg' property. + + - pinctl-names : A pinctrl state named "default" must be defined. +See: Documentation/devicetree/bindings/pinctrl/pinctrl-binding.txt. + + - pinctrl-0 : Pin control group +See: Documentation/devicetree/bindings/pinctrl/pinctrl-binding.txt. + + - ranges: allows valid 1:1 translation between child's address space and + parent's address space. + +Optional properties: + - st,dwc3-drd-device: to program the HC as "device" (static setup) + +Sub-nodes: +The dwc3 core should be added as subnode to ST DWC3 glue as shown in the +example below. The DT binding details of dwc3 can be found in: +Documentation/devicetree/bindings/usb/dwc3.txt + +Example: + +st_dwc3: dwc3@8f94000 { + status = "disabled"; + compatible = "st,stih407-dwc3"; + reg = <0x08f94000 0x1000>, <0x110 0x4>; + reg-names = "reg-glue", "syscfg-reg"; + st,syscfg = <&syscfg_core>; + resets = <&powerdown STIH407_USB3_POWERDOWN>; + #address-cells = <1>; + #size-cells = <1>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usb3>; + ranges; + + dwc3: dwc3@9900000 { + compatible = "synopsys,dwc3"; + reg = <0x09900000 0x100000>; + interrupts = <GIC_SPI 155 IRQ_TYPE_NONE>; + + usb-phy = <&usb2_phy>, <&usb3_phy>; + }; +};