| Message ID | 20201123202746.2817480-1-u.kleine-koenig@pengutronix.de |
|---|---|
| State | Accepted |
| Commit | 83eb65b6ac7cd17ba87e5ebd15cd44f4034ccf3d |
| Headers | show |
| Series | i2c: pca-platform: drop two members from driver data that are assigned to only | expand |
On Mon, Nov 23, 2020 at 09:27:46PM +0100, Uwe Kleine-König wrote: > io_base and io_size are assigned to only in .probe() and otherwise unused. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> My very first driver :) Applied to for-next, thanks!
On Wed, Dec 02, 2020 at 04:57:01PM +0100, Wolfram Sang wrote: > On Mon, Nov 23, 2020 at 09:27:46PM +0100, Uwe Kleine-König wrote: > > io_base and io_size are assigned to only in .probe() and otherwise unused. > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > My very first driver :) Just for the record: I was never Wolfram's chauffeur. I guess he meant that the i2c-pca-platform driver was the first i2c driver he wrote. SCNR Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
> > My very first driver :) > > Just for the record: I was never Wolfram's chauffeur. I guess he meant > that the i2c-pca-platform driver was the first i2c driver he wrote. :D
diff --git a/drivers/i2c/busses/i2c-pca-platform.c b/drivers/i2c/busses/i2c-pca-platform.c index 546426a470cc..86d4f75ef8d3 100644 --- a/drivers/i2c/busses/i2c-pca-platform.c +++ b/drivers/i2c/busses/i2c-pca-platform.c @@ -33,8 +33,6 @@ struct i2c_pca_pf_data { wait_queue_head_t wait; struct i2c_adapter adap; struct i2c_algo_pca_data algo_data; - unsigned long io_base; - unsigned long io_size; }; /* Read/Write functions for different register alignments */ @@ -156,8 +154,6 @@ static int i2c_pca_pf_probe(struct platform_device *pdev) init_waitqueue_head(&i2c->wait); - i2c->io_base = res->start; - i2c->io_size = resource_size(res); i2c->irq = irq; i2c->adap.nr = pdev->id;
io_base and io_size are assigned to only in .probe() and otherwise unused. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/i2c/busses/i2c-pca-platform.c | 4 ---- 1 file changed, 4 deletions(-)