| Message ID | 20201119222248.148845-1-rikard.falkeborn@gmail.com |
|---|---|
| State | Accepted |
| Commit | ded8f0355a8821262a27a398d3f5587c29665dae |
| Headers | show |
| Series | media: i2c: rdacm20: Constify static structs | expand |
Hi Rikard, On Thu, Nov 19, 2020 at 11:22:48PM +0100, Rikard Falkeborn wrote: > The only usage of rdacm20_video_ops is to assign it to the video field > in the v4l2_subdev_ops struct which is a pointer to const, and the only > usage of rdacm20_subdev_ops is to pass its address to > v4l2_i2c_subdev_init() which accepts a pointer to const. Make them const > to allow the compiler to put them in read-only memory. > > Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> Thanks Acked-by: Jacopo Mondi <jacopo@jmondi.org> > --- > drivers/media/i2c/rdacm20.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/i2c/rdacm20.c b/drivers/media/i2c/rdacm20.c > index 1ed928c4ca70..ac00a6743623 100644 > --- a/drivers/media/i2c/rdacm20.c > +++ b/drivers/media/i2c/rdacm20.c > @@ -435,7 +435,7 @@ static int rdacm20_get_fmt(struct v4l2_subdev *sd, > return 0; > } > > -static struct v4l2_subdev_video_ops rdacm20_video_ops = { > +static const struct v4l2_subdev_video_ops rdacm20_video_ops = { > .s_stream = rdacm20_s_stream, > }; > > @@ -445,7 +445,7 @@ static const struct v4l2_subdev_pad_ops rdacm20_subdev_pad_ops = { > .set_fmt = rdacm20_get_fmt, > }; > > -static struct v4l2_subdev_ops rdacm20_subdev_ops = { > +static const struct v4l2_subdev_ops rdacm20_subdev_ops = { > .video = &rdacm20_video_ops, > .pad = &rdacm20_subdev_pad_ops, > }; > -- > 2.29.2 >
Hi Rikard, Thank you for the fix. On 19/11/2020 22:22, Rikard Falkeborn wrote: > The only usage of rdacm20_video_ops is to assign it to the video field > in the v4l2_subdev_ops struct which is a pointer to const, and the only > usage of rdacm20_subdev_ops is to pass its address to > v4l2_i2c_subdev_init() which accepts a pointer to const. Make them const > to allow the compiler to put them in read-only memory. > > Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > --- > drivers/media/i2c/rdacm20.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/i2c/rdacm20.c b/drivers/media/i2c/rdacm20.c > index 1ed928c4ca70..ac00a6743623 100644 > --- a/drivers/media/i2c/rdacm20.c > +++ b/drivers/media/i2c/rdacm20.c > @@ -435,7 +435,7 @@ static int rdacm20_get_fmt(struct v4l2_subdev *sd, > return 0; > } > > -static struct v4l2_subdev_video_ops rdacm20_video_ops = { > +static const struct v4l2_subdev_video_ops rdacm20_video_ops = { > .s_stream = rdacm20_s_stream, > }; > > @@ -445,7 +445,7 @@ static const struct v4l2_subdev_pad_ops rdacm20_subdev_pad_ops = { > .set_fmt = rdacm20_get_fmt, > }; > > -static struct v4l2_subdev_ops rdacm20_subdev_ops = { > +static const struct v4l2_subdev_ops rdacm20_subdev_ops = { > .video = &rdacm20_video_ops, > .pad = &rdacm20_subdev_pad_ops, > }; >
diff --git a/drivers/media/i2c/rdacm20.c b/drivers/media/i2c/rdacm20.c index 1ed928c4ca70..ac00a6743623 100644 --- a/drivers/media/i2c/rdacm20.c +++ b/drivers/media/i2c/rdacm20.c @@ -435,7 +435,7 @@ static int rdacm20_get_fmt(struct v4l2_subdev *sd, return 0; } -static struct v4l2_subdev_video_ops rdacm20_video_ops = { +static const struct v4l2_subdev_video_ops rdacm20_video_ops = { .s_stream = rdacm20_s_stream, }; @@ -445,7 +445,7 @@ static const struct v4l2_subdev_pad_ops rdacm20_subdev_pad_ops = { .set_fmt = rdacm20_get_fmt, }; -static struct v4l2_subdev_ops rdacm20_subdev_ops = { +static const struct v4l2_subdev_ops rdacm20_subdev_ops = { .video = &rdacm20_video_ops, .pad = &rdacm20_subdev_pad_ops, };
The only usage of rdacm20_video_ops is to assign it to the video field in the v4l2_subdev_ops struct which is a pointer to const, and the only usage of rdacm20_subdev_ops is to pass its address to v4l2_i2c_subdev_init() which accepts a pointer to const. Make them const to allow the compiler to put them in read-only memory. Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> --- drivers/media/i2c/rdacm20.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)