| Message ID | 20201120161529.236447-3-jacopo+renesas@jmondi.org |
|---|---|
| State | Accepted |
| Commit | 7fe1d4453fb6bf103d668a19d957a7b2fc21887c |
| Headers | show |
| Series | media: max9271: Fix GPIO handling | expand |
Hi Jacopo, On 20/11/2020 16:15, Jacopo Mondi wrote: > The MAX9271 GPIO1 line that controls the sensor reset is by default > enabled after a serializer chip reset. > > As rdacm20 does not go through an explicit serializer reset, make sure > GPIO1 is enabled to make the camera module driver more robust. > > Fixes: 34009bffc1c6 ("media: i2c: Add RDACM20 driver") > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> Looks helpful to ensure a GPIO is enabled before toggling ;-) Reading the datasheet, GPIO1EN defaults to enabled, so I assume this was already working - however I think being explicit is a good thing anyway. Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > --- > drivers/media/i2c/rdacm20.c | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/i2c/rdacm20.c b/drivers/media/i2c/rdacm20.c > index 1ed928c4ca70..16bcb764b0e0 100644 > --- a/drivers/media/i2c/rdacm20.c > +++ b/drivers/media/i2c/rdacm20.c > @@ -487,9 +487,18 @@ static int rdacm20_initialize(struct rdacm20_device *dev) > * Reset the sensor by cycling the OV10635 reset signal connected to the > * MAX9271 GPIO1 and verify communication with the OV10635. > */ > - max9271_clear_gpios(dev->serializer, MAX9271_GPIO1OUT); > + ret = max9271_enable_gpios(dev->serializer, MAX9271_GPIO1OUT); > + if (ret) > + return ret; > + > + ret = max9271_clear_gpios(dev->serializer, MAX9271_GPIO1OUT); > + if (ret) > + return ret; > usleep_range(10000, 15000); > - max9271_set_gpios(dev->serializer, MAX9271_GPIO1OUT); > + > + ret = max9271_set_gpios(dev->serializer, MAX9271_GPIO1OUT); > + if (ret) > + return ret; > usleep_range(10000, 15000); > > again: > -- > 2.29.1 >
diff --git a/drivers/media/i2c/rdacm20.c b/drivers/media/i2c/rdacm20.c index 1ed928c4ca70..16bcb764b0e0 100644 --- a/drivers/media/i2c/rdacm20.c +++ b/drivers/media/i2c/rdacm20.c @@ -487,9 +487,18 @@ static int rdacm20_initialize(struct rdacm20_device *dev) * Reset the sensor by cycling the OV10635 reset signal connected to the * MAX9271 GPIO1 and verify communication with the OV10635. */ - max9271_clear_gpios(dev->serializer, MAX9271_GPIO1OUT); + ret = max9271_enable_gpios(dev->serializer, MAX9271_GPIO1OUT); + if (ret) + return ret; + + ret = max9271_clear_gpios(dev->serializer, MAX9271_GPIO1OUT); + if (ret) + return ret; usleep_range(10000, 15000); - max9271_set_gpios(dev->serializer, MAX9271_GPIO1OUT); + + ret = max9271_set_gpios(dev->serializer, MAX9271_GPIO1OUT); + if (ret) + return ret; usleep_range(10000, 15000); again:
The MAX9271 GPIO1 line that controls the sensor reset is by default enabled after a serializer chip reset. As rdacm20 does not go through an explicit serializer reset, make sure GPIO1 is enabled to make the camera module driver more robust. Fixes: 34009bffc1c6 ("media: i2c: Add RDACM20 driver") Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> --- drivers/media/i2c/rdacm20.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) -- 2.29.1