diff mbox series

[1/2] io_uring: get an active ref_node from files_data

Message ID 98193a70c7b87cbfa3fc0a919af8041ed41a82e6.1605710178.git.asml.silence@gmail.com
State Accepted
Commit 1e5d770bb8a23dd01e28e92f4fb0b1093c8bdbe6
Headers show
Series [1/2] io_uring: get an active ref_node from files_data | expand

Commit Message

Pavel Begunkov Nov. 18, 2020, 2:56 p.m. UTC 
An active ref_node always can be found in ctx->files_data, it's much
safer to get it this way instead of poking into files_data->ref_list.

Cc: stable@vger.kernel.org # v5.7+
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
---
 fs/io_uring.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/fs/io_uring.c b/fs/io_uring.c
index b205c1df3f74..5cb194ca4fce 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -6974,9 +6974,7 @@  static int io_sqe_files_unregister(struct io_ring_ctx *ctx)
 		return -ENXIO;
 
 	spin_lock(&data->lock);
-	if (!list_empty(&data->ref_list))
-		ref_node = list_first_entry(&data->ref_list,
-				struct fixed_file_ref_node, node);
+	ref_node = data->node;
 	spin_unlock(&data->lock);
 	if (ref_node)
 		percpu_ref_kill(&ref_node->refs);