diff mbox series

arm64: defconfig: Enable QCOM_SCM as builtin

Message ID 20201118162528.454729-1-bjorn.andersson@linaro.org
State Accepted
Commit 91ccc45d1ec4d08851de004eb5d68c67e1232694
Headers show
Series arm64: defconfig: Enable QCOM_SCM as builtin | expand

Commit Message

Bjorn Andersson Nov. 18, 2020, 4:25 p.m. UTC
The Qualcomm SCM driver was never explicitly enabled in the defconfig.
Instead it was (apparently) selected by DRM_MSM and by the recent change
to make it tristate now became =m.

Unfortunately this removes the ability for PINCTRL_MSM and ARM_SMMU to
be =y and with deferred_probe_timeout defaulting to 0 this means that
things such as UART, USB, PCIe and SDHCI probes with their dependencies
ignored.

The lack of pinctrl results in invalid pin configuration and the lack of
iommu results in the system locking up as soon as any form of data
transfer is attempted from any of the affected peripherals.

Mark QCOM_SCM as builtin, to avoid this.

Cc: John Stultz <john.stultz@linaro.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

-- 
2.28.0

Comments

Vinod Koul Nov. 19, 2020, 12:49 p.m. UTC | #1
On 18-11-20, 08:25, Bjorn Andersson wrote:
> The Qualcomm SCM driver was never explicitly enabled in the defconfig.

> Instead it was (apparently) selected by DRM_MSM and by the recent change

> to make it tristate now became =m.

> 

> Unfortunately this removes the ability for PINCTRL_MSM and ARM_SMMU to

> be =y and with deferred_probe_timeout defaulting to 0 this means that

> things such as UART, USB, PCIe and SDHCI probes with their dependencies

> ignored.

> 

> The lack of pinctrl results in invalid pin configuration and the lack of

> iommu results in the system locking up as soon as any form of data

> transfer is attempted from any of the affected peripherals.

> 

> Mark QCOM_SCM as builtin, to avoid this.


Reviewed-by: Vinod Koul <vkoul@kernel.org>


-- 
~Vinod
Steev Klimaszewski Nov. 30, 2020, 4:30 p.m. UTC | #2
On 11/18/20 10:25 AM, Bjorn Andersson wrote:
> The Qualcomm SCM driver was never explicitly enabled in the defconfig.

> Instead it was (apparently) selected by DRM_MSM and by the recent change

> to make it tristate now became =m.

>

> Unfortunately this removes the ability for PINCTRL_MSM and ARM_SMMU to

> be =y and with deferred_probe_timeout defaulting to 0 this means that

> things such as UART, USB, PCIe and SDHCI probes with their dependencies

> ignored.

>

> The lack of pinctrl results in invalid pin configuration and the lack of

> iommu results in the system locking up as soon as any form of data

> transfer is attempted from any of the affected peripherals.

>

> Mark QCOM_SCM as builtin, to avoid this.

>

> Cc: John Stultz <john.stultz@linaro.org>

> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

> ---

>  arch/arm64/configs/defconfig | 1 +

>  1 file changed, 1 insertion(+)

>

> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig

> index d129340a7ed1..287ccf98dc41 100644

> --- a/arch/arm64/configs/defconfig

> +++ b/arch/arm64/configs/defconfig

> @@ -99,6 +99,7 @@ CONFIG_ARM_SCPI_PROTOCOL=y

>  CONFIG_RASPBERRYPI_FIRMWARE=y

>  CONFIG_INTEL_STRATIX10_SERVICE=y

>  CONFIG_INTEL_STRATIX10_RSU=m

> +CONFIG_QCOM_SCM=y

>  CONFIG_EFI_CAPSULE_LOADER=y

>  CONFIG_IMX_SCU=y

>  CONFIG_IMX_SCU_PD=y


Tested-by: Steev Klimaszewski <steev@kali.org>
diff mbox series

Patch

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index d129340a7ed1..287ccf98dc41 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -99,6 +99,7 @@  CONFIG_ARM_SCPI_PROTOCOL=y
 CONFIG_RASPBERRYPI_FIRMWARE=y
 CONFIG_INTEL_STRATIX10_SERVICE=y
 CONFIG_INTEL_STRATIX10_RSU=m
+CONFIG_QCOM_SCM=y
 CONFIG_EFI_CAPSULE_LOADER=y
 CONFIG_IMX_SCU=y
 CONFIG_IMX_SCU_PD=y