diff mbox

odp_atomic.h Correct spelling

Message ID 1403895673-60196-1-git-send-email-mike.holmes@linaro.org
State Accepted
Commit a5b7d50a6ac17ef5ada2da2232764065fce48c31
Headers show

Commit Message

Mike Holmes June 27, 2014, 7:01 p.m. UTC
Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
---
 include/odp_atomic.h | 28 ++++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)

Comments

Ola Liljedahl June 30, 2014, 12:32 p.m. UTC | #1
Yes but is it spelled "synchronized" or "synchronised"? Maybe we should
alternate?

-- Ola



On 27 June 2014 21:01, Mike Holmes <mike.holmes@linaro.org> wrote:

> Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
> ---
>  include/odp_atomic.h | 28 ++++++++++++++--------------
>  1 file changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/include/odp_atomic.h b/include/odp_atomic.h
> index 5a25dc7..0cc4cf4 100644
> --- a/include/odp_atomic.h
> +++ b/include/odp_atomic.h
> @@ -43,7 +43,7 @@ typedef volatile uint32_t odp_atomic_u32_t;
>   *
>   * @param ptr    An integer atomic variable
>   *
> - * @note The operation is not synchoronized with other threads
> + * @note The operation is not synchronized with other threads
>   */
>  static inline void odp_atomic_init_int(odp_atomic_int_t *ptr)
>  {
> @@ -57,7 +57,7 @@ static inline void odp_atomic_init_int(odp_atomic_int_t
> *ptr)
>   *
>   * @return atomic integer value
>   *
> - * @note The operation is not synchoronized with other threads
> + * @note The operation is not synchronized with other threads
>   */
>  static inline int odp_atomic_load_int(odp_atomic_int_t *ptr)
>  {
> @@ -70,7 +70,7 @@ static inline int odp_atomic_load_int(odp_atomic_int_t
> *ptr)
>   * @param ptr        An atomic variable
>   * @param new_value  Store new_value to a variable
>   *
> - * @note The operation is not synchoronized with other threads
> + * @note The operation is not synchronized with other threads
>   */
>  static inline void odp_atomic_store_int(odp_atomic_int_t *ptr, int
> new_value)
>  {
> @@ -91,9 +91,9 @@ static inline int
> odp_atomic_fetch_add_int(odp_atomic_int_t *ptr, int value)
>  }
>
>  /**
> - * Fetch and substract atomic integer
> + * Fetch and subtract atomic integer
>   *
> - * @param ptr    An atomic int variable
> + * @param ptr    An atomic integer variable
>   * @param value  A value to be subtracted from the variable
>   *
>   * @return Value of the variable before the operation
> @@ -154,7 +154,7 @@ static inline void odp_atomic_dec_int(odp_atomic_int_t
> *ptr)
>   *
>   * @param ptr    An atomic variable
>   *
> - * @note The operation is not synchoronized with other threads
> + * @note The operation is not synchronized with other threads
>   */
>  static inline void odp_atomic_init_u32(odp_atomic_u32_t *ptr)
>  {
> @@ -168,7 +168,7 @@ static inline void
> odp_atomic_init_u32(odp_atomic_u32_t *ptr)
>   *
>   * @return atomic uint32 value
>   *
> - * @note The operation is not synchoronized with other threads
> + * @note The operation is not synchronized with other threads
>   */
>  static inline uint32_t odp_atomic_load_u32(odp_atomic_u32_t *ptr)
>  {
> @@ -181,7 +181,7 @@ static inline uint32_t
> odp_atomic_load_u32(odp_atomic_u32_t *ptr)
>   * @param ptr        An atomic variable
>   * @param new_value  Store new_value to a variable
>   *
> - * @note The operation is not synchoronized with other threads
> + * @note The operation is not synchronized with other threads
>   */
>  static inline void odp_atomic_store_u32(odp_atomic_u32_t *ptr,
>                                         uint32_t new_value)
> @@ -204,7 +204,7 @@ static inline uint32_t
> odp_atomic_fetch_add_u32(odp_atomic_u32_t *ptr,
>  }
>
>  /**
> - * Fetch and substract uint32
> + * Fetch and subtract uint32
>   *
>   * @param ptr    An atomic variable
>   * @param value  A value to be sub to the variable
> @@ -299,7 +299,7 @@ odp_atomic_cmpset_u32(odp_atomic_u32_t *dst, uint32_t
> exp, uint32_t src)
>   *
>   * @param ptr    An atomic variable
>   *
> - * @note The operation is not synchoronized with other threads
> + * @note The operation is not synchronized with other threads
>   */
>  static inline void odp_atomic_init_u64(odp_atomic_u64_t *ptr)
>  {
> @@ -313,7 +313,7 @@ static inline void
> odp_atomic_init_u64(odp_atomic_u64_t *ptr)
>   *
>   * @return atomic uint64 value
>   *
> - * @note The operation is not synchoronized with other threads
> + * @note The operation is not synchronized with other threads
>   */
>  static inline uint64_t odp_atomic_load_u64(odp_atomic_u64_t *ptr)
>  {
> @@ -326,7 +326,7 @@ static inline uint64_t
> odp_atomic_load_u64(odp_atomic_u64_t *ptr)
>   * @param ptr        An atomic variable
>   * @param new_value  Store new_value to a variable
>   *
> - * @note The operation is not synchoronized with other threads
> + * @note The operation is not synchronized with other threads
>   */
>  static inline void odp_atomic_store_u64(odp_atomic_u64_t *ptr,
>                                         uint64_t new_value)
> @@ -427,7 +427,7 @@ static inline void odp_atomic_inc_u64(odp_atomic_u64_t
> *ptr)
>  }
>
>  /**
> - * Fetch and decement atomic uint64 by 1
> + * Fetch and decrement atomic uint64 by 1
>   *
>   * @param ptr    An atomic variable
>   *
> @@ -439,7 +439,7 @@ static inline uint64_t
> odp_atomic_fetch_dec_u64(odp_atomic_u64_t *ptr)
>  }
>
>  /**
> - * Deccrement atomic uint64 by 1
> + * Decrement atomic uint64 by 1
>   *
>   * @param ptr    An atomic variable
>   *
> --
> 1.9.1
>
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> http://lists.linaro.org/mailman/listinfo/lng-odp
>
Magnus Karlsson June 30, 2014, 12:44 p.m. UTC | #2
Is it one of those words that has a "z" in American English and an "s" in
British English? Of course only one of them is correct ;-).

/Magnus


On Mon, Jun 30, 2014 at 2:32 PM, Ola Liljedahl <ola.liljedahl@linaro.org>
wrote:

> Yes but is it spelled "synchronized" or "synchronised"? Maybe we should
> alternate?
>
> -- Ola
>
>
>
> On 27 June 2014 21:01, Mike Holmes <mike.holmes@linaro.org> wrote:
>
>> Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
>> ---
>>  include/odp_atomic.h | 28 ++++++++++++++--------------
>>  1 file changed, 14 insertions(+), 14 deletions(-)
>>
>> diff --git a/include/odp_atomic.h b/include/odp_atomic.h
>> index 5a25dc7..0cc4cf4 100644
>> --- a/include/odp_atomic.h
>> +++ b/include/odp_atomic.h
>> @@ -43,7 +43,7 @@ typedef volatile uint32_t odp_atomic_u32_t;
>>   *
>>   * @param ptr    An integer atomic variable
>>   *
>> - * @note The operation is not synchoronized with other threads
>> + * @note The operation is not synchronized with other threads
>>   */
>>  static inline void odp_atomic_init_int(odp_atomic_int_t *ptr)
>>  {
>> @@ -57,7 +57,7 @@ static inline void odp_atomic_init_int(odp_atomic_int_t
>> *ptr)
>>   *
>>   * @return atomic integer value
>>   *
>> - * @note The operation is not synchoronized with other threads
>> + * @note The operation is not synchronized with other threads
>>   */
>>  static inline int odp_atomic_load_int(odp_atomic_int_t *ptr)
>>  {
>> @@ -70,7 +70,7 @@ static inline int odp_atomic_load_int(odp_atomic_int_t
>> *ptr)
>>   * @param ptr        An atomic variable
>>   * @param new_value  Store new_value to a variable
>>   *
>> - * @note The operation is not synchoronized with other threads
>> + * @note The operation is not synchronized with other threads
>>   */
>>  static inline void odp_atomic_store_int(odp_atomic_int_t *ptr, int
>> new_value)
>>  {
>> @@ -91,9 +91,9 @@ static inline int
>> odp_atomic_fetch_add_int(odp_atomic_int_t *ptr, int value)
>>  }
>>
>>  /**
>> - * Fetch and substract atomic integer
>> + * Fetch and subtract atomic integer
>>   *
>> - * @param ptr    An atomic int variable
>> + * @param ptr    An atomic integer variable
>>   * @param value  A value to be subtracted from the variable
>>   *
>>   * @return Value of the variable before the operation
>> @@ -154,7 +154,7 @@ static inline void
>> odp_atomic_dec_int(odp_atomic_int_t *ptr)
>>   *
>>   * @param ptr    An atomic variable
>>   *
>> - * @note The operation is not synchoronized with other threads
>> + * @note The operation is not synchronized with other threads
>>   */
>>  static inline void odp_atomic_init_u32(odp_atomic_u32_t *ptr)
>>  {
>> @@ -168,7 +168,7 @@ static inline void
>> odp_atomic_init_u32(odp_atomic_u32_t *ptr)
>>   *
>>   * @return atomic uint32 value
>>   *
>> - * @note The operation is not synchoronized with other threads
>> + * @note The operation is not synchronized with other threads
>>   */
>>  static inline uint32_t odp_atomic_load_u32(odp_atomic_u32_t *ptr)
>>  {
>> @@ -181,7 +181,7 @@ static inline uint32_t
>> odp_atomic_load_u32(odp_atomic_u32_t *ptr)
>>   * @param ptr        An atomic variable
>>   * @param new_value  Store new_value to a variable
>>   *
>> - * @note The operation is not synchoronized with other threads
>> + * @note The operation is not synchronized with other threads
>>   */
>>  static inline void odp_atomic_store_u32(odp_atomic_u32_t *ptr,
>>                                         uint32_t new_value)
>> @@ -204,7 +204,7 @@ static inline uint32_t
>> odp_atomic_fetch_add_u32(odp_atomic_u32_t *ptr,
>>  }
>>
>>  /**
>> - * Fetch and substract uint32
>> + * Fetch and subtract uint32
>>   *
>>   * @param ptr    An atomic variable
>>   * @param value  A value to be sub to the variable
>> @@ -299,7 +299,7 @@ odp_atomic_cmpset_u32(odp_atomic_u32_t *dst, uint32_t
>> exp, uint32_t src)
>>   *
>>   * @param ptr    An atomic variable
>>   *
>> - * @note The operation is not synchoronized with other threads
>> + * @note The operation is not synchronized with other threads
>>   */
>>  static inline void odp_atomic_init_u64(odp_atomic_u64_t *ptr)
>>  {
>> @@ -313,7 +313,7 @@ static inline void
>> odp_atomic_init_u64(odp_atomic_u64_t *ptr)
>>   *
>>   * @return atomic uint64 value
>>   *
>> - * @note The operation is not synchoronized with other threads
>> + * @note The operation is not synchronized with other threads
>>   */
>>  static inline uint64_t odp_atomic_load_u64(odp_atomic_u64_t *ptr)
>>  {
>> @@ -326,7 +326,7 @@ static inline uint64_t
>> odp_atomic_load_u64(odp_atomic_u64_t *ptr)
>>   * @param ptr        An atomic variable
>>   * @param new_value  Store new_value to a variable
>>   *
>> - * @note The operation is not synchoronized with other threads
>> + * @note The operation is not synchronized with other threads
>>   */
>>  static inline void odp_atomic_store_u64(odp_atomic_u64_t *ptr,
>>                                         uint64_t new_value)
>> @@ -427,7 +427,7 @@ static inline void
>> odp_atomic_inc_u64(odp_atomic_u64_t *ptr)
>>  }
>>
>>  /**
>> - * Fetch and decement atomic uint64 by 1
>> + * Fetch and decrement atomic uint64 by 1
>>   *
>>   * @param ptr    An atomic variable
>>   *
>> @@ -439,7 +439,7 @@ static inline uint64_t
>> odp_atomic_fetch_dec_u64(odp_atomic_u64_t *ptr)
>>  }
>>
>>  /**
>> - * Deccrement atomic uint64 by 1
>> + * Decrement atomic uint64 by 1
>>   *
>>   * @param ptr    An atomic variable
>>   *
>> --
>> 1.9.1
>>
>>
>> _______________________________________________
>> lng-odp mailing list
>> lng-odp@lists.linaro.org
>> http://lists.linaro.org/mailman/listinfo/lng-odp
>>
>
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> http://lists.linaro.org/mailman/listinfo/lng-odp
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to lng-sc+unsubscribe@linaro.org.
>
>
Bill Fischofer June 30, 2014, 12:55 p.m. UTC | #3
As Churchill observed, he US and UK are two countries divided by a common
language.  British and American orthography differs in a lot of areas.  The
convention most often used is that prose is written in the author's native
orthography.  If we have differences in the wording of actual API calls
then we can create aliases so both spellings are acceptable.


On Mon, Jun 30, 2014 at 7:44 AM, Magnus Karlsson <
magnus.karlsson@avagotech.com> wrote:

> Is it one of those words that has a "z" in American English and an "s" in
> British English? Of course only one of them is correct ;-).
>
> /Magnus
>
>
> On Mon, Jun 30, 2014 at 2:32 PM, Ola Liljedahl <ola.liljedahl@linaro.org>
> wrote:
>
>> Yes but is it spelled "synchronized" or "synchronised"? Maybe we should
>> alternate?
>>
>> -- Ola
>>
>>
>>
>> On 27 June 2014 21:01, Mike Holmes <mike.holmes@linaro.org> wrote:
>>
>>> Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
>>> ---
>>>  include/odp_atomic.h | 28 ++++++++++++++--------------
>>>  1 file changed, 14 insertions(+), 14 deletions(-)
>>>
>>> diff --git a/include/odp_atomic.h b/include/odp_atomic.h
>>> index 5a25dc7..0cc4cf4 100644
>>> --- a/include/odp_atomic.h
>>> +++ b/include/odp_atomic.h
>>> @@ -43,7 +43,7 @@ typedef volatile uint32_t odp_atomic_u32_t;
>>>   *
>>>   * @param ptr    An integer atomic variable
>>>   *
>>> - * @note The operation is not synchoronized with other threads
>>> + * @note The operation is not synchronized with other threads
>>>   */
>>>  static inline void odp_atomic_init_int(odp_atomic_int_t *ptr)
>>>  {
>>> @@ -57,7 +57,7 @@ static inline void
>>> odp_atomic_init_int(odp_atomic_int_t *ptr)
>>>   *
>>>   * @return atomic integer value
>>>   *
>>> - * @note The operation is not synchoronized with other threads
>>> + * @note The operation is not synchronized with other threads
>>>   */
>>>  static inline int odp_atomic_load_int(odp_atomic_int_t *ptr)
>>>  {
>>> @@ -70,7 +70,7 @@ static inline int odp_atomic_load_int(odp_atomic_int_t
>>> *ptr)
>>>   * @param ptr        An atomic variable
>>>   * @param new_value  Store new_value to a variable
>>>   *
>>> - * @note The operation is not synchoronized with other threads
>>> + * @note The operation is not synchronized with other threads
>>>   */
>>>  static inline void odp_atomic_store_int(odp_atomic_int_t *ptr, int
>>> new_value)
>>>  {
>>> @@ -91,9 +91,9 @@ static inline int
>>> odp_atomic_fetch_add_int(odp_atomic_int_t *ptr, int value)
>>>  }
>>>
>>>  /**
>>> - * Fetch and substract atomic integer
>>> + * Fetch and subtract atomic integer
>>>   *
>>> - * @param ptr    An atomic int variable
>>> + * @param ptr    An atomic integer variable
>>>   * @param value  A value to be subtracted from the variable
>>>   *
>>>   * @return Value of the variable before the operation
>>> @@ -154,7 +154,7 @@ static inline void
>>> odp_atomic_dec_int(odp_atomic_int_t *ptr)
>>>   *
>>>   * @param ptr    An atomic variable
>>>   *
>>> - * @note The operation is not synchoronized with other threads
>>> + * @note The operation is not synchronized with other threads
>>>   */
>>>  static inline void odp_atomic_init_u32(odp_atomic_u32_t *ptr)
>>>  {
>>> @@ -168,7 +168,7 @@ static inline void
>>> odp_atomic_init_u32(odp_atomic_u32_t *ptr)
>>>   *
>>>   * @return atomic uint32 value
>>>   *
>>> - * @note The operation is not synchoronized with other threads
>>> + * @note The operation is not synchronized with other threads
>>>   */
>>>  static inline uint32_t odp_atomic_load_u32(odp_atomic_u32_t *ptr)
>>>  {
>>> @@ -181,7 +181,7 @@ static inline uint32_t
>>> odp_atomic_load_u32(odp_atomic_u32_t *ptr)
>>>   * @param ptr        An atomic variable
>>>   * @param new_value  Store new_value to a variable
>>>   *
>>> - * @note The operation is not synchoronized with other threads
>>> + * @note The operation is not synchronized with other threads
>>>   */
>>>  static inline void odp_atomic_store_u32(odp_atomic_u32_t *ptr,
>>>                                         uint32_t new_value)
>>> @@ -204,7 +204,7 @@ static inline uint32_t
>>> odp_atomic_fetch_add_u32(odp_atomic_u32_t *ptr,
>>>  }
>>>
>>>  /**
>>> - * Fetch and substract uint32
>>> + * Fetch and subtract uint32
>>>   *
>>>   * @param ptr    An atomic variable
>>>   * @param value  A value to be sub to the variable
>>> @@ -299,7 +299,7 @@ odp_atomic_cmpset_u32(odp_atomic_u32_t *dst,
>>> uint32_t exp, uint32_t src)
>>>   *
>>>   * @param ptr    An atomic variable
>>>   *
>>> - * @note The operation is not synchoronized with other threads
>>> + * @note The operation is not synchronized with other threads
>>>   */
>>>  static inline void odp_atomic_init_u64(odp_atomic_u64_t *ptr)
>>>  {
>>> @@ -313,7 +313,7 @@ static inline void
>>> odp_atomic_init_u64(odp_atomic_u64_t *ptr)
>>>   *
>>>   * @return atomic uint64 value
>>>   *
>>> - * @note The operation is not synchoronized with other threads
>>> + * @note The operation is not synchronized with other threads
>>>   */
>>>  static inline uint64_t odp_atomic_load_u64(odp_atomic_u64_t *ptr)
>>>  {
>>> @@ -326,7 +326,7 @@ static inline uint64_t
>>> odp_atomic_load_u64(odp_atomic_u64_t *ptr)
>>>   * @param ptr        An atomic variable
>>>   * @param new_value  Store new_value to a variable
>>>   *
>>> - * @note The operation is not synchoronized with other threads
>>> + * @note The operation is not synchronized with other threads
>>>   */
>>>  static inline void odp_atomic_store_u64(odp_atomic_u64_t *ptr,
>>>                                         uint64_t new_value)
>>> @@ -427,7 +427,7 @@ static inline void
>>> odp_atomic_inc_u64(odp_atomic_u64_t *ptr)
>>>  }
>>>
>>>  /**
>>> - * Fetch and decement atomic uint64 by 1
>>> + * Fetch and decrement atomic uint64 by 1
>>>   *
>>>   * @param ptr    An atomic variable
>>>   *
>>> @@ -439,7 +439,7 @@ static inline uint64_t
>>> odp_atomic_fetch_dec_u64(odp_atomic_u64_t *ptr)
>>>  }
>>>
>>>  /**
>>> - * Deccrement atomic uint64 by 1
>>> + * Decrement atomic uint64 by 1
>>>   *
>>>   * @param ptr    An atomic variable
>>>   *
>>> --
>>> 1.9.1
>>>
>>>
>>> _______________________________________________
>>> lng-odp mailing list
>>> lng-odp@lists.linaro.org
>>> http://lists.linaro.org/mailman/listinfo/lng-odp
>>>
>>
>>
>> _______________________________________________
>> lng-odp mailing list
>> lng-odp@lists.linaro.org
>> http://lists.linaro.org/mailman/listinfo/lng-odp
>>
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to lng-sc+unsubscribe@linaro.org.
>>
>>
>
>
> --
>
> *Magnus Karlsson*
>
> Software Development Engineering Manager
>
> Avago Technologies (formerly LSI Logic)
>
> Box 1024, Knarrarnäsgatan 15
>
> SE-164 21 Kista, Sweden
>
> TEL +46 8 594 607 09
>
> FAX +46 8 594 607 10
>
> CELL +46 73 80 444 88
>
> magnus.karlsson@avagotech.com
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> http://lists.linaro.org/mailman/listinfo/lng-odp
>
>
Marshall Guillory June 30, 2014, 1:07 p.m. UTC | #4
Yes, of course one of them is correct. :-)

Sent from my iPhone

> On Jun 30, 2014, at 7:44 AM, Magnus Karlsson <magnus.karlsson@avagotech.com> wrote:
> 
> Is it one of those words that has a "z" in American English and an "s" in British English? Of course only one of them is correct ;-).
> 
> /Magnus
> 
> 
>> On Mon, Jun 30, 2014 at 2:32 PM, Ola Liljedahl <ola.liljedahl@linaro.org> wrote:
>> Yes but is it spelled "synchronized" or "synchronised"? Maybe we should alternate?
>> 
>> -- Ola
>> 
>> 
>> 
>>> On 27 June 2014 21:01, Mike Holmes <mike.holmes@linaro.org> wrote:
>>> Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
>>> ---
>>>  include/odp_atomic.h | 28 ++++++++++++++--------------
>>>  1 file changed, 14 insertions(+), 14 deletions(-)
>>> 
>>> diff --git a/include/odp_atomic.h b/include/odp_atomic.h
>>> index 5a25dc7..0cc4cf4 100644
>>> --- a/include/odp_atomic.h
>>> +++ b/include/odp_atomic.h
>>> @@ -43,7 +43,7 @@ typedef volatile uint32_t odp_atomic_u32_t;
>>>   *
>>>   * @param ptr    An integer atomic variable
>>>   *
>>> - * @note The operation is not synchoronized with other threads
>>> + * @note The operation is not synchronized with other threads
>>>   */
>>>  static inline void odp_atomic_init_int(odp_atomic_int_t *ptr)
>>>  {
>>> @@ -57,7 +57,7 @@ static inline void odp_atomic_init_int(odp_atomic_int_t *ptr)
>>>   *
>>>   * @return atomic integer value
>>>   *
>>> - * @note The operation is not synchoronized with other threads
>>> + * @note The operation is not synchronized with other threads
>>>   */
>>>  static inline int odp_atomic_load_int(odp_atomic_int_t *ptr)
>>>  {
>>> @@ -70,7 +70,7 @@ static inline int odp_atomic_load_int(odp_atomic_int_t *ptr)
>>>   * @param ptr        An atomic variable
>>>   * @param new_value  Store new_value to a variable
>>>   *
>>> - * @note The operation is not synchoronized with other threads
>>> + * @note The operation is not synchronized with other threads
>>>   */
>>>  static inline void odp_atomic_store_int(odp_atomic_int_t *ptr, int new_value)
>>>  {
>>> @@ -91,9 +91,9 @@ static inline int odp_atomic_fetch_add_int(odp_atomic_int_t *ptr, int value)
>>>  }
>>> 
>>>  /**
>>> - * Fetch and substract atomic integer
>>> + * Fetch and subtract atomic integer
>>>   *
>>> - * @param ptr    An atomic int variable
>>> + * @param ptr    An atomic integer variable
>>>   * @param value  A value to be subtracted from the variable
>>>   *
>>>   * @return Value of the variable before the operation
>>> @@ -154,7 +154,7 @@ static inline void odp_atomic_dec_int(odp_atomic_int_t *ptr)
>>>   *
>>>   * @param ptr    An atomic variable
>>>   *
>>> - * @note The operation is not synchoronized with other threads
>>> + * @note The operation is not synchronized with other threads
>>>   */
>>>  static inline void odp_atomic_init_u32(odp_atomic_u32_t *ptr)
>>>  {
>>> @@ -168,7 +168,7 @@ static inline void odp_atomic_init_u32(odp_atomic_u32_t *ptr)
>>>   *
>>>   * @return atomic uint32 value
>>>   *
>>> - * @note The operation is not synchoronized with other threads
>>> + * @note The operation is not synchronized with other threads
>>>   */
>>>  static inline uint32_t odp_atomic_load_u32(odp_atomic_u32_t *ptr)
>>>  {
>>> @@ -181,7 +181,7 @@ static inline uint32_t odp_atomic_load_u32(odp_atomic_u32_t *ptr)
>>>   * @param ptr        An atomic variable
>>>   * @param new_value  Store new_value to a variable
>>>   *
>>> - * @note The operation is not synchoronized with other threads
>>> + * @note The operation is not synchronized with other threads
>>>   */
>>>  static inline void odp_atomic_store_u32(odp_atomic_u32_t *ptr,
>>>                                         uint32_t new_value)
>>> @@ -204,7 +204,7 @@ static inline uint32_t odp_atomic_fetch_add_u32(odp_atomic_u32_t *ptr,
>>>  }
>>> 
>>>  /**
>>> - * Fetch and substract uint32
>>> + * Fetch and subtract uint32
>>>   *
>>>   * @param ptr    An atomic variable
>>>   * @param value  A value to be sub to the variable
>>> @@ -299,7 +299,7 @@ odp_atomic_cmpset_u32(odp_atomic_u32_t *dst, uint32_t exp, uint32_t src)
>>>   *
>>>   * @param ptr    An atomic variable
>>>   *
>>> - * @note The operation is not synchoronized with other threads
>>> + * @note The operation is not synchronized with other threads
>>>   */
>>>  static inline void odp_atomic_init_u64(odp_atomic_u64_t *ptr)
>>>  {
>>> @@ -313,7 +313,7 @@ static inline void odp_atomic_init_u64(odp_atomic_u64_t *ptr)
>>>   *
>>>   * @return atomic uint64 value
>>>   *
>>> - * @note The operation is not synchoronized with other threads
>>> + * @note The operation is not synchronized with other threads
>>>   */
>>>  static inline uint64_t odp_atomic_load_u64(odp_atomic_u64_t *ptr)
>>>  {
>>> @@ -326,7 +326,7 @@ static inline uint64_t odp_atomic_load_u64(odp_atomic_u64_t *ptr)
>>>   * @param ptr        An atomic variable
>>>   * @param new_value  Store new_value to a variable
>>>   *
>>> - * @note The operation is not synchoronized with other threads
>>> + * @note The operation is not synchronized with other threads
>>>   */
>>>  static inline void odp_atomic_store_u64(odp_atomic_u64_t *ptr,
>>>                                         uint64_t new_value)
>>> @@ -427,7 +427,7 @@ static inline void odp_atomic_inc_u64(odp_atomic_u64_t *ptr)
>>>  }
>>> 
>>>  /**
>>> - * Fetch and decement atomic uint64 by 1
>>> + * Fetch and decrement atomic uint64 by 1
>>>   *
>>>   * @param ptr    An atomic variable
>>>   *
>>> @@ -439,7 +439,7 @@ static inline uint64_t odp_atomic_fetch_dec_u64(odp_atomic_u64_t *ptr)
>>>  }
>>> 
>>>  /**
>>> - * Deccrement atomic uint64 by 1
>>> + * Decrement atomic uint64 by 1
>>>   *
>>>   * @param ptr    An atomic variable
>>>   *
>>> --
>>> 1.9.1
>>> 
>>> 
>>> _______________________________________________
>>> lng-odp mailing list
>>> lng-odp@lists.linaro.org
>>> http://lists.linaro.org/mailman/listinfo/lng-odp
>> 
>> 
>> _______________________________________________
>> lng-odp mailing list
>> lng-odp@lists.linaro.org
>> http://lists.linaro.org/mailman/listinfo/lng-odp
>> 
>> To unsubscribe from this group and stop receiving emails from it, send an email to lng-sc+unsubscribe@linaro.org.
>> 
> 
> 
> 
> -- 
> Magnus Karlsson
> 
> Software Development Engineering Manager
> 
> Avago Technologies (formerly LSI Logic)
> 
> Box 1024, Knarrarnäsgatan 15
> 
> SE-164 21 Kista, Sweden
> 
> TEL +46 8 594 607 09
> 
> FAX +46 8 594 607 10
> 
> CELL +46 73 80 444 88
> 
> magnus.karlsson@avagotech.com
> 
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> http://lists.linaro.org/mailman/listinfo/lng-odp
Ola Liljedahl June 30, 2014, 1:41 p.m. UTC | #5
Mike was the author of these changes (even though he seemed to prefer
minimising the changes. Which makes the question of the author's nativity
somewhat complicated...


On 30 June 2014 14:55, Bill Fischofer <bill.fischofer@linaro.org> wrote:

> As Churchill observed, he US and UK are two countries divided by a common
> language.  British and American orthography differs in a lot of areas.  The
> convention most often used is that prose is written in the author's native
> orthography.  If we have differences in the wording of actual API calls
> then we can create aliases so both spellings are acceptable.
>
>
> On Mon, Jun 30, 2014 at 7:44 AM, Magnus Karlsson <
> magnus.karlsson@avagotech.com> wrote:
>
>> Is it one of those words that has a "z" in American English and an "s" in
>> British English? Of course only one of them is correct ;-).
>>
>> /Magnus
>>
>>
>> On Mon, Jun 30, 2014 at 2:32 PM, Ola Liljedahl <ola.liljedahl@linaro.org>
>> wrote:
>>
>>> Yes but is it spelled "synchronized" or "synchronised"? Maybe we should
>>> alternate?
>>>
>>> -- Ola
>>>
>>>
>>>
>>> On 27 June 2014 21:01, Mike Holmes <mike.holmes@linaro.org> wrote:
>>>
>>>> Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
>>>> ---
>>>>  include/odp_atomic.h | 28 ++++++++++++++--------------
>>>>  1 file changed, 14 insertions(+), 14 deletions(-)
>>>>
>>>> diff --git a/include/odp_atomic.h b/include/odp_atomic.h
>>>> index 5a25dc7..0cc4cf4 100644
>>>> --- a/include/odp_atomic.h
>>>> +++ b/include/odp_atomic.h
>>>> @@ -43,7 +43,7 @@ typedef volatile uint32_t odp_atomic_u32_t;
>>>>   *
>>>>   * @param ptr    An integer atomic variable
>>>>   *
>>>> - * @note The operation is not synchoronized with other threads
>>>> + * @note The operation is not synchronized with other threads
>>>>   */
>>>>  static inline void odp_atomic_init_int(odp_atomic_int_t *ptr)
>>>>  {
>>>> @@ -57,7 +57,7 @@ static inline void
>>>> odp_atomic_init_int(odp_atomic_int_t *ptr)
>>>>   *
>>>>   * @return atomic integer value
>>>>   *
>>>> - * @note The operation is not synchoronized with other threads
>>>> + * @note The operation is not synchronized with other threads
>>>>   */
>>>>  static inline int odp_atomic_load_int(odp_atomic_int_t *ptr)
>>>>  {
>>>> @@ -70,7 +70,7 @@ static inline int
>>>> odp_atomic_load_int(odp_atomic_int_t *ptr)
>>>>   * @param ptr        An atomic variable
>>>>   * @param new_value  Store new_value to a variable
>>>>   *
>>>> - * @note The operation is not synchoronized with other threads
>>>> + * @note The operation is not synchronized with other threads
>>>>   */
>>>>  static inline void odp_atomic_store_int(odp_atomic_int_t *ptr, int
>>>> new_value)
>>>>  {
>>>> @@ -91,9 +91,9 @@ static inline int
>>>> odp_atomic_fetch_add_int(odp_atomic_int_t *ptr, int value)
>>>>  }
>>>>
>>>>  /**
>>>> - * Fetch and substract atomic integer
>>>> + * Fetch and subtract atomic integer
>>>>   *
>>>> - * @param ptr    An atomic int variable
>>>> + * @param ptr    An atomic integer variable
>>>>   * @param value  A value to be subtracted from the variable
>>>>   *
>>>>   * @return Value of the variable before the operation
>>>> @@ -154,7 +154,7 @@ static inline void
>>>> odp_atomic_dec_int(odp_atomic_int_t *ptr)
>>>>   *
>>>>   * @param ptr    An atomic variable
>>>>   *
>>>> - * @note The operation is not synchoronized with other threads
>>>> + * @note The operation is not synchronized with other threads
>>>>   */
>>>>  static inline void odp_atomic_init_u32(odp_atomic_u32_t *ptr)
>>>>  {
>>>> @@ -168,7 +168,7 @@ static inline void
>>>> odp_atomic_init_u32(odp_atomic_u32_t *ptr)
>>>>   *
>>>>   * @return atomic uint32 value
>>>>   *
>>>> - * @note The operation is not synchoronized with other threads
>>>> + * @note The operation is not synchronized with other threads
>>>>   */
>>>>  static inline uint32_t odp_atomic_load_u32(odp_atomic_u32_t *ptr)
>>>>  {
>>>> @@ -181,7 +181,7 @@ static inline uint32_t
>>>> odp_atomic_load_u32(odp_atomic_u32_t *ptr)
>>>>   * @param ptr        An atomic variable
>>>>   * @param new_value  Store new_value to a variable
>>>>   *
>>>> - * @note The operation is not synchoronized with other threads
>>>> + * @note The operation is not synchronized with other threads
>>>>   */
>>>>  static inline void odp_atomic_store_u32(odp_atomic_u32_t *ptr,
>>>>                                         uint32_t new_value)
>>>> @@ -204,7 +204,7 @@ static inline uint32_t
>>>> odp_atomic_fetch_add_u32(odp_atomic_u32_t *ptr,
>>>>  }
>>>>
>>>>  /**
>>>> - * Fetch and substract uint32
>>>> + * Fetch and subtract uint32
>>>>   *
>>>>   * @param ptr    An atomic variable
>>>>   * @param value  A value to be sub to the variable
>>>> @@ -299,7 +299,7 @@ odp_atomic_cmpset_u32(odp_atomic_u32_t *dst,
>>>> uint32_t exp, uint32_t src)
>>>>   *
>>>>   * @param ptr    An atomic variable
>>>>   *
>>>> - * @note The operation is not synchoronized with other threads
>>>> + * @note The operation is not synchronized with other threads
>>>>   */
>>>>  static inline void odp_atomic_init_u64(odp_atomic_u64_t *ptr)
>>>>  {
>>>> @@ -313,7 +313,7 @@ static inline void
>>>> odp_atomic_init_u64(odp_atomic_u64_t *ptr)
>>>>   *
>>>>   * @return atomic uint64 value
>>>>   *
>>>> - * @note The operation is not synchoronized with other threads
>>>> + * @note The operation is not synchronized with other threads
>>>>   */
>>>>  static inline uint64_t odp_atomic_load_u64(odp_atomic_u64_t *ptr)
>>>>  {
>>>> @@ -326,7 +326,7 @@ static inline uint64_t
>>>> odp_atomic_load_u64(odp_atomic_u64_t *ptr)
>>>>   * @param ptr        An atomic variable
>>>>   * @param new_value  Store new_value to a variable
>>>>   *
>>>> - * @note The operation is not synchoronized with other threads
>>>> + * @note The operation is not synchronized with other threads
>>>>   */
>>>>  static inline void odp_atomic_store_u64(odp_atomic_u64_t *ptr,
>>>>                                         uint64_t new_value)
>>>> @@ -427,7 +427,7 @@ static inline void
>>>> odp_atomic_inc_u64(odp_atomic_u64_t *ptr)
>>>>  }
>>>>
>>>>  /**
>>>> - * Fetch and decement atomic uint64 by 1
>>>> + * Fetch and decrement atomic uint64 by 1
>>>>   *
>>>>   * @param ptr    An atomic variable
>>>>   *
>>>> @@ -439,7 +439,7 @@ static inline uint64_t
>>>> odp_atomic_fetch_dec_u64(odp_atomic_u64_t *ptr)
>>>>  }
>>>>
>>>>  /**
>>>> - * Deccrement atomic uint64 by 1
>>>> + * Decrement atomic uint64 by 1
>>>>   *
>>>>   * @param ptr    An atomic variable
>>>>   *
>>>> --
>>>> 1.9.1
>>>>
>>>>
>>>> _______________________________________________
>>>> lng-odp mailing list
>>>> lng-odp@lists.linaro.org
>>>> http://lists.linaro.org/mailman/listinfo/lng-odp
>>>>
>>>
>>>
>>> _______________________________________________
>>> lng-odp mailing list
>>> lng-odp@lists.linaro.org
>>> http://lists.linaro.org/mailman/listinfo/lng-odp
>>>
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to lng-sc+unsubscribe@linaro.org.
>>>
>>>
>>
>>
>> --
>>
>> *Magnus Karlsson*
>>
>> Software Development Engineering Manager
>>
>> Avago Technologies (formerly LSI Logic)
>>
>> Box 1024, Knarrarnäsgatan 15
>>
>> SE-164 21 Kista, Sweden
>>
>> TEL +46 8 594 607 09
>>
>> FAX +46 8 594 607 10
>>
>> CELL +46 73 80 444 88
>>
>> magnus.karlsson@avagotech.com
>>
>> _______________________________________________
>> lng-odp mailing list
>> lng-odp@lists.linaro.org
>> http://lists.linaro.org/mailman/listinfo/lng-odp
>>
>>
>
David Nyström June 30, 2014, 1:51 p.m. UTC | #6
Hi,

Sorry for hijacking this thread for a more general discussion.

There are several other libraries that specialize at atomics, and do it
a bit more cleanly.

Are there any good reasons not to use libatomic-ops or perhaps 
concurrencykit for atomic_ops ?

Br,
David
Bill Fischofer June 30, 2014, 1:52 p.m. UTC | #7
Transplants can refer to their passport for guidance.  :)

Bill


On Mon, Jun 30, 2014 at 8:41 AM, Ola Liljedahl <ola.liljedahl@linaro.org>
wrote:

> Mike was the author of these changes (even though he seemed to prefer
> minimising the changes. Which makes the question of the author's nativity
> somewhat complicated...
>
>
> On 30 June 2014 14:55, Bill Fischofer <bill.fischofer@linaro.org> wrote:
>
>> As Churchill observed, he US and UK are two countries divided by a common
>> language.  British and American orthography differs in a lot of areas.  The
>> convention most often used is that prose is written in the author's native
>> orthography.  If we have differences in the wording of actual API calls
>> then we can create aliases so both spellings are acceptable.
>>
>>
>> On Mon, Jun 30, 2014 at 7:44 AM, Magnus Karlsson <
>> magnus.karlsson@avagotech.com> wrote:
>>
>>> Is it one of those words that has a "z" in American English and an "s"
>>> in British English? Of course only one of them is correct ;-).
>>>
>>> /Magnus
>>>
>>>
>>> On Mon, Jun 30, 2014 at 2:32 PM, Ola Liljedahl <ola.liljedahl@linaro.org
>>> > wrote:
>>>
>>>> Yes but is it spelled "synchronized" or "synchronised"? Maybe we should
>>>> alternate?
>>>>
>>>> -- Ola
>>>>
>>>>
>>>>
>>>> On 27 June 2014 21:01, Mike Holmes <mike.holmes@linaro.org> wrote:
>>>>
>>>>> Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
>>>>> ---
>>>>>  include/odp_atomic.h | 28 ++++++++++++++--------------
>>>>>  1 file changed, 14 insertions(+), 14 deletions(-)
>>>>>
>>>>> diff --git a/include/odp_atomic.h b/include/odp_atomic.h
>>>>> index 5a25dc7..0cc4cf4 100644
>>>>> --- a/include/odp_atomic.h
>>>>> +++ b/include/odp_atomic.h
>>>>> @@ -43,7 +43,7 @@ typedef volatile uint32_t odp_atomic_u32_t;
>>>>>   *
>>>>>   * @param ptr    An integer atomic variable
>>>>>   *
>>>>> - * @note The operation is not synchoronized with other threads
>>>>> + * @note The operation is not synchronized with other threads
>>>>>   */
>>>>>  static inline void odp_atomic_init_int(odp_atomic_int_t *ptr)
>>>>>  {
>>>>> @@ -57,7 +57,7 @@ static inline void
>>>>> odp_atomic_init_int(odp_atomic_int_t *ptr)
>>>>>   *
>>>>>   * @return atomic integer value
>>>>>   *
>>>>> - * @note The operation is not synchoronized with other threads
>>>>> + * @note The operation is not synchronized with other threads
>>>>>   */
>>>>>  static inline int odp_atomic_load_int(odp_atomic_int_t *ptr)
>>>>>  {
>>>>> @@ -70,7 +70,7 @@ static inline int
>>>>> odp_atomic_load_int(odp_atomic_int_t *ptr)
>>>>>   * @param ptr        An atomic variable
>>>>>   * @param new_value  Store new_value to a variable
>>>>>   *
>>>>> - * @note The operation is not synchoronized with other threads
>>>>> + * @note The operation is not synchronized with other threads
>>>>>   */
>>>>>  static inline void odp_atomic_store_int(odp_atomic_int_t *ptr, int
>>>>> new_value)
>>>>>  {
>>>>> @@ -91,9 +91,9 @@ static inline int
>>>>> odp_atomic_fetch_add_int(odp_atomic_int_t *ptr, int value)
>>>>>  }
>>>>>
>>>>>  /**
>>>>> - * Fetch and substract atomic integer
>>>>> + * Fetch and subtract atomic integer
>>>>>   *
>>>>> - * @param ptr    An atomic int variable
>>>>> + * @param ptr    An atomic integer variable
>>>>>   * @param value  A value to be subtracted from the variable
>>>>>   *
>>>>>   * @return Value of the variable before the operation
>>>>> @@ -154,7 +154,7 @@ static inline void
>>>>> odp_atomic_dec_int(odp_atomic_int_t *ptr)
>>>>>   *
>>>>>   * @param ptr    An atomic variable
>>>>>   *
>>>>> - * @note The operation is not synchoronized with other threads
>>>>> + * @note The operation is not synchronized with other threads
>>>>>   */
>>>>>  static inline void odp_atomic_init_u32(odp_atomic_u32_t *ptr)
>>>>>  {
>>>>> @@ -168,7 +168,7 @@ static inline void
>>>>> odp_atomic_init_u32(odp_atomic_u32_t *ptr)
>>>>>   *
>>>>>   * @return atomic uint32 value
>>>>>   *
>>>>> - * @note The operation is not synchoronized with other threads
>>>>> + * @note The operation is not synchronized with other threads
>>>>>   */
>>>>>  static inline uint32_t odp_atomic_load_u32(odp_atomic_u32_t *ptr)
>>>>>  {
>>>>> @@ -181,7 +181,7 @@ static inline uint32_t
>>>>> odp_atomic_load_u32(odp_atomic_u32_t *ptr)
>>>>>   * @param ptr        An atomic variable
>>>>>   * @param new_value  Store new_value to a variable
>>>>>   *
>>>>> - * @note The operation is not synchoronized with other threads
>>>>> + * @note The operation is not synchronized with other threads
>>>>>   */
>>>>>  static inline void odp_atomic_store_u32(odp_atomic_u32_t *ptr,
>>>>>                                         uint32_t new_value)
>>>>> @@ -204,7 +204,7 @@ static inline uint32_t
>>>>> odp_atomic_fetch_add_u32(odp_atomic_u32_t *ptr,
>>>>>  }
>>>>>
>>>>>  /**
>>>>> - * Fetch and substract uint32
>>>>> + * Fetch and subtract uint32
>>>>>   *
>>>>>   * @param ptr    An atomic variable
>>>>>   * @param value  A value to be sub to the variable
>>>>> @@ -299,7 +299,7 @@ odp_atomic_cmpset_u32(odp_atomic_u32_t *dst,
>>>>> uint32_t exp, uint32_t src)
>>>>>   *
>>>>>   * @param ptr    An atomic variable
>>>>>   *
>>>>> - * @note The operation is not synchoronized with other threads
>>>>> + * @note The operation is not synchronized with other threads
>>>>>   */
>>>>>  static inline void odp_atomic_init_u64(odp_atomic_u64_t *ptr)
>>>>>  {
>>>>> @@ -313,7 +313,7 @@ static inline void
>>>>> odp_atomic_init_u64(odp_atomic_u64_t *ptr)
>>>>>   *
>>>>>   * @return atomic uint64 value
>>>>>   *
>>>>> - * @note The operation is not synchoronized with other threads
>>>>> + * @note The operation is not synchronized with other threads
>>>>>   */
>>>>>  static inline uint64_t odp_atomic_load_u64(odp_atomic_u64_t *ptr)
>>>>>  {
>>>>> @@ -326,7 +326,7 @@ static inline uint64_t
>>>>> odp_atomic_load_u64(odp_atomic_u64_t *ptr)
>>>>>   * @param ptr        An atomic variable
>>>>>   * @param new_value  Store new_value to a variable
>>>>>   *
>>>>> - * @note The operation is not synchoronized with other threads
>>>>> + * @note The operation is not synchronized with other threads
>>>>>   */
>>>>>  static inline void odp_atomic_store_u64(odp_atomic_u64_t *ptr,
>>>>>                                         uint64_t new_value)
>>>>> @@ -427,7 +427,7 @@ static inline void
>>>>> odp_atomic_inc_u64(odp_atomic_u64_t *ptr)
>>>>>  }
>>>>>
>>>>>  /**
>>>>> - * Fetch and decement atomic uint64 by 1
>>>>> + * Fetch and decrement atomic uint64 by 1
>>>>>   *
>>>>>   * @param ptr    An atomic variable
>>>>>   *
>>>>> @@ -439,7 +439,7 @@ static inline uint64_t
>>>>> odp_atomic_fetch_dec_u64(odp_atomic_u64_t *ptr)
>>>>>  }
>>>>>
>>>>>  /**
>>>>> - * Deccrement atomic uint64 by 1
>>>>> + * Decrement atomic uint64 by 1
>>>>>   *
>>>>>   * @param ptr    An atomic variable
>>>>>   *
>>>>> --
>>>>> 1.9.1
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> lng-odp mailing list
>>>>> lng-odp@lists.linaro.org
>>>>> http://lists.linaro.org/mailman/listinfo/lng-odp
>>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> lng-odp mailing list
>>>> lng-odp@lists.linaro.org
>>>> http://lists.linaro.org/mailman/listinfo/lng-odp
>>>>
>>>> To unsubscribe from this group and stop receiving emails from it, send
>>>> an email to lng-sc+unsubscribe@linaro.org.
>>>>
>>>>
>>>
>>>
>>> --
>>>
>>> *Magnus Karlsson*
>>>
>>> Software Development Engineering Manager
>>>
>>> Avago Technologies (formerly LSI Logic)
>>>
>>> Box 1024, Knarrarnäsgatan 15
>>>
>>> SE-164 21 Kista, Sweden
>>>
>>> TEL +46 8 594 607 09
>>>
>>> FAX +46 8 594 607 10
>>>
>>> CELL +46 73 80 444 88
>>>
>>> magnus.karlsson@avagotech.com
>>>
>>> _______________________________________________
>>> lng-odp mailing list
>>> lng-odp@lists.linaro.org
>>> http://lists.linaro.org/mailman/listinfo/lng-odp
>>>
>>>
>>
>
Mike Holmes June 30, 2014, 1:53 p.m. UTC | #8
No, possibly only that no one provided a patch to do so, or licensing
issues, but I don't think either was investigated in detail.


On 30 June 2014 09:51, David Nyström <david.nystrom@enea.com> wrote:

> Hi,
>
> Sorry for hijacking this thread for a more general discussion.
>
> There are several other libraries that specialize at atomics, and do it
> a bit more cleanly.
>
> Are there any good reasons not to use libatomic-ops or perhaps
> concurrencykit for atomic_ops ?
>
> Br,
> David
>
Bill Fischofer June 30, 2014, 2:01 p.m. UTC | #9
A quick check shows that libatomics is GPL, so not usable by ODP (BSD
3-clause).  Concurrencykit seems to be BSD. Since ODP is a framework it
does not preclude applications from using other frameworks so I'd think
applications could use it if they wish.


On Mon, Jun 30, 2014 at 8:53 AM, Mike Holmes <mike.holmes@linaro.org> wrote:

> No, possibly only that no one provided a patch to do so, or licensing
> issues, but I don't think either was investigated in detail.
>
>
> On 30 June 2014 09:51, David Nyström <david.nystrom@enea.com> wrote:
>
>> Hi,
>>
>> Sorry for hijacking this thread for a more general discussion.
>>
>> There are several other libraries that specialize at atomics, and do it
>> a bit more cleanly.
>>
>> Are there any good reasons not to use libatomic-ops or perhaps
>> concurrencykit for atomic_ops ?
>>
>> Br,
>> David
>>
>
>
>
> --
> *Mike Holmes*
> Linaro Technical Manager / Lead
> LNG - ODP
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> http://lists.linaro.org/mailman/listinfo/lng-odp
>
>
David Nyström June 30, 2014, 2:11 p.m. UTC | #10
On 2014-06-30 16:01, Bill Fischofer wrote:
> A quick check shows that libatomics is GPL, so not usable by ODP (BSD
> 3-clause).

This is a common misconception.
https://github.com/ivmai/libatomic_ops/blob/master/doc/LICENSING.txt

In fact, all relevant features we might use are MIT.
GPL parts are split into the libatomics-gpl library.

>Concurrencykit seems to be BSD. Since ODP is a framework it
> does not preclude applications from using other frameworks so I'd think
> applications could use it if they wish.
>
> On Mon, Jun 30, 2014 at 8:53 AM, Mike Holmes <mike.holmes@linaro.org> wrote:
>
>> No, possibly only that no one provided a patch to do so, or licensing
>> issues, but I don't think either was investigated in detail.
>>
>>
>> On 30 June 2014 09:51, David Nyström <david.nystrom@enea.com> wrote:
>>
>>> Hi,
>>>
>>> Sorry for hijacking this thread for a more general discussion.
>>>
>>> There are several other libraries that specialize at atomics, and do it
>>> a bit more cleanly.
>>>
>>> Are there any good reasons not to use libatomic-ops or perhaps
>>> concurrencykit for atomic_ops ?
>>>
>>> Br,
>>> David
>>>
>>
>>
>>
>> --
>> *Mike Holmes*
>> Linaro Technical Manager / Lead
>> LNG - ODP
>>
>> _______________________________________________
>> lng-odp mailing list
>> lng-odp@lists.linaro.org
>> http://lists.linaro.org/mailman/listinfo/lng-odp
>>
>>
>
>
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> http://lists.linaro.org/mailman/listinfo/lng-odp
>
Bill Fischofer June 30, 2014, 2:56 p.m. UTC | #11
Thanks for that clarification.


On Mon, Jun 30, 2014 at 9:11 AM, David Nyström <david.nystrom@enea.com>
wrote:

> On 2014-06-30 16:01, Bill Fischofer wrote:
>
>> A quick check shows that libatomics is GPL, so not usable by ODP (BSD
>> 3-clause).
>>
>
> This is a common misconception.
> https://github.com/ivmai/libatomic_ops/blob/master/doc/LICENSING.txt
>
> In fact, all relevant features we might use are MIT.
> GPL parts are split into the libatomics-gpl library.
>
>  Concurrencykit seems to be BSD. Since ODP is a framework it
>> does not preclude applications from using other frameworks so I'd think
>> applications could use it if they wish.
>>
>> On Mon, Jun 30, 2014 at 8:53 AM, Mike Holmes <mike.holmes@linaro.org>
>> wrote:
>>
>>  No, possibly only that no one provided a patch to do so, or licensing
>>> issues, but I don't think either was investigated in detail.
>>>
>>>
>>> On 30 June 2014 09:51, David Nyström <david.nystrom@enea.com> wrote:
>>>
>>>  Hi,
>>>>
>>>> Sorry for hijacking this thread for a more general discussion.
>>>>
>>>> There are several other libraries that specialize at atomics, and do it
>>>> a bit more cleanly.
>>>>
>>>> Are there any good reasons not to use libatomic-ops or perhaps
>>>> concurrencykit for atomic_ops ?
>>>>
>>>> Br,
>>>> David
>>>>
>>>>
>>>
>>>
>>> --
>>> *Mike Holmes*
>>>
>>> Linaro Technical Manager / Lead
>>> LNG - ODP
>>>
>>> _______________________________________________
>>> lng-odp mailing list
>>> lng-odp@lists.linaro.org
>>> http://lists.linaro.org/mailman/listinfo/lng-odp
>>>
>>>
>>>
>>
>>
>> _______________________________________________
>> lng-odp mailing list
>> lng-odp@lists.linaro.org
>> http://lists.linaro.org/mailman/listinfo/lng-odp
>>
>>
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> http://lists.linaro.org/mailman/listinfo/lng-odp
>
Maxim Uvarov July 1, 2014, 7:50 a.m. UTC | #12
Applied, thanks!

Maxim.

On 06/27/2014 11:01 PM, Mike Holmes wrote:
> Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
> ---
>   include/odp_atomic.h | 28 ++++++++++++++--------------
>   1 file changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/include/odp_atomic.h b/include/odp_atomic.h
> index 5a25dc7..0cc4cf4 100644
> --- a/include/odp_atomic.h
> +++ b/include/odp_atomic.h
> @@ -43,7 +43,7 @@ typedef volatile uint32_t odp_atomic_u32_t;
>    *
>    * @param ptr    An integer atomic variable
>    *
> - * @note The operation is not synchoronized with other threads
> + * @note The operation is not synchronized with other threads
>    */
>   static inline void odp_atomic_init_int(odp_atomic_int_t *ptr)
>   {
> @@ -57,7 +57,7 @@ static inline void odp_atomic_init_int(odp_atomic_int_t *ptr)
>    *
>    * @return atomic integer value
>    *
> - * @note The operation is not synchoronized with other threads
> + * @note The operation is not synchronized with other threads
>    */
>   static inline int odp_atomic_load_int(odp_atomic_int_t *ptr)
>   {
> @@ -70,7 +70,7 @@ static inline int odp_atomic_load_int(odp_atomic_int_t *ptr)
>    * @param ptr        An atomic variable
>    * @param new_value  Store new_value to a variable
>    *
> - * @note The operation is not synchoronized with other threads
> + * @note The operation is not synchronized with other threads
>    */
>   static inline void odp_atomic_store_int(odp_atomic_int_t *ptr, int new_value)
>   {
> @@ -91,9 +91,9 @@ static inline int odp_atomic_fetch_add_int(odp_atomic_int_t *ptr, int value)
>   }
>   
>   /**
> - * Fetch and substract atomic integer
> + * Fetch and subtract atomic integer
>    *
> - * @param ptr    An atomic int variable
> + * @param ptr    An atomic integer variable
>    * @param value  A value to be subtracted from the variable
>    *
>    * @return Value of the variable before the operation
> @@ -154,7 +154,7 @@ static inline void odp_atomic_dec_int(odp_atomic_int_t *ptr)
>    *
>    * @param ptr    An atomic variable
>    *
> - * @note The operation is not synchoronized with other threads
> + * @note The operation is not synchronized with other threads
>    */
>   static inline void odp_atomic_init_u32(odp_atomic_u32_t *ptr)
>   {
> @@ -168,7 +168,7 @@ static inline void odp_atomic_init_u32(odp_atomic_u32_t *ptr)
>    *
>    * @return atomic uint32 value
>    *
> - * @note The operation is not synchoronized with other threads
> + * @note The operation is not synchronized with other threads
>    */
>   static inline uint32_t odp_atomic_load_u32(odp_atomic_u32_t *ptr)
>   {
> @@ -181,7 +181,7 @@ static inline uint32_t odp_atomic_load_u32(odp_atomic_u32_t *ptr)
>    * @param ptr        An atomic variable
>    * @param new_value  Store new_value to a variable
>    *
> - * @note The operation is not synchoronized with other threads
> + * @note The operation is not synchronized with other threads
>    */
>   static inline void odp_atomic_store_u32(odp_atomic_u32_t *ptr,
>   					uint32_t new_value)
> @@ -204,7 +204,7 @@ static inline uint32_t odp_atomic_fetch_add_u32(odp_atomic_u32_t *ptr,
>   }
>   
>   /**
> - * Fetch and substract uint32
> + * Fetch and subtract uint32
>    *
>    * @param ptr    An atomic variable
>    * @param value  A value to be sub to the variable
> @@ -299,7 +299,7 @@ odp_atomic_cmpset_u32(odp_atomic_u32_t *dst, uint32_t exp, uint32_t src)
>    *
>    * @param ptr    An atomic variable
>    *
> - * @note The operation is not synchoronized with other threads
> + * @note The operation is not synchronized with other threads
>    */
>   static inline void odp_atomic_init_u64(odp_atomic_u64_t *ptr)
>   {
> @@ -313,7 +313,7 @@ static inline void odp_atomic_init_u64(odp_atomic_u64_t *ptr)
>    *
>    * @return atomic uint64 value
>    *
> - * @note The operation is not synchoronized with other threads
> + * @note The operation is not synchronized with other threads
>    */
>   static inline uint64_t odp_atomic_load_u64(odp_atomic_u64_t *ptr)
>   {
> @@ -326,7 +326,7 @@ static inline uint64_t odp_atomic_load_u64(odp_atomic_u64_t *ptr)
>    * @param ptr        An atomic variable
>    * @param new_value  Store new_value to a variable
>    *
> - * @note The operation is not synchoronized with other threads
> + * @note The operation is not synchronized with other threads
>    */
>   static inline void odp_atomic_store_u64(odp_atomic_u64_t *ptr,
>   					uint64_t new_value)
> @@ -427,7 +427,7 @@ static inline void odp_atomic_inc_u64(odp_atomic_u64_t *ptr)
>   }
>   
>   /**
> - * Fetch and decement atomic uint64 by 1
> + * Fetch and decrement atomic uint64 by 1
>    *
>    * @param ptr    An atomic variable
>    *
> @@ -439,7 +439,7 @@ static inline uint64_t odp_atomic_fetch_dec_u64(odp_atomic_u64_t *ptr)
>   }
>   
>   /**
> - * Deccrement atomic uint64 by 1
> + * Decrement atomic uint64 by 1
>    *
>    * @param ptr    An atomic variable
>    *
diff mbox

Patch

diff --git a/include/odp_atomic.h b/include/odp_atomic.h
index 5a25dc7..0cc4cf4 100644
--- a/include/odp_atomic.h
+++ b/include/odp_atomic.h
@@ -43,7 +43,7 @@  typedef volatile uint32_t odp_atomic_u32_t;
  *
  * @param ptr    An integer atomic variable
  *
- * @note The operation is not synchoronized with other threads
+ * @note The operation is not synchronized with other threads
  */
 static inline void odp_atomic_init_int(odp_atomic_int_t *ptr)
 {
@@ -57,7 +57,7 @@  static inline void odp_atomic_init_int(odp_atomic_int_t *ptr)
  *
  * @return atomic integer value
  *
- * @note The operation is not synchoronized with other threads
+ * @note The operation is not synchronized with other threads
  */
 static inline int odp_atomic_load_int(odp_atomic_int_t *ptr)
 {
@@ -70,7 +70,7 @@  static inline int odp_atomic_load_int(odp_atomic_int_t *ptr)
  * @param ptr        An atomic variable
  * @param new_value  Store new_value to a variable
  *
- * @note The operation is not synchoronized with other threads
+ * @note The operation is not synchronized with other threads
  */
 static inline void odp_atomic_store_int(odp_atomic_int_t *ptr, int new_value)
 {
@@ -91,9 +91,9 @@  static inline int odp_atomic_fetch_add_int(odp_atomic_int_t *ptr, int value)
 }
 
 /**
- * Fetch and substract atomic integer
+ * Fetch and subtract atomic integer
  *
- * @param ptr    An atomic int variable
+ * @param ptr    An atomic integer variable
  * @param value  A value to be subtracted from the variable
  *
  * @return Value of the variable before the operation
@@ -154,7 +154,7 @@  static inline void odp_atomic_dec_int(odp_atomic_int_t *ptr)
  *
  * @param ptr    An atomic variable
  *
- * @note The operation is not synchoronized with other threads
+ * @note The operation is not synchronized with other threads
  */
 static inline void odp_atomic_init_u32(odp_atomic_u32_t *ptr)
 {
@@ -168,7 +168,7 @@  static inline void odp_atomic_init_u32(odp_atomic_u32_t *ptr)
  *
  * @return atomic uint32 value
  *
- * @note The operation is not synchoronized with other threads
+ * @note The operation is not synchronized with other threads
  */
 static inline uint32_t odp_atomic_load_u32(odp_atomic_u32_t *ptr)
 {
@@ -181,7 +181,7 @@  static inline uint32_t odp_atomic_load_u32(odp_atomic_u32_t *ptr)
  * @param ptr        An atomic variable
  * @param new_value  Store new_value to a variable
  *
- * @note The operation is not synchoronized with other threads
+ * @note The operation is not synchronized with other threads
  */
 static inline void odp_atomic_store_u32(odp_atomic_u32_t *ptr,
 					uint32_t new_value)
@@ -204,7 +204,7 @@  static inline uint32_t odp_atomic_fetch_add_u32(odp_atomic_u32_t *ptr,
 }
 
 /**
- * Fetch and substract uint32
+ * Fetch and subtract uint32
  *
  * @param ptr    An atomic variable
  * @param value  A value to be sub to the variable
@@ -299,7 +299,7 @@  odp_atomic_cmpset_u32(odp_atomic_u32_t *dst, uint32_t exp, uint32_t src)
  *
  * @param ptr    An atomic variable
  *
- * @note The operation is not synchoronized with other threads
+ * @note The operation is not synchronized with other threads
  */
 static inline void odp_atomic_init_u64(odp_atomic_u64_t *ptr)
 {
@@ -313,7 +313,7 @@  static inline void odp_atomic_init_u64(odp_atomic_u64_t *ptr)
  *
  * @return atomic uint64 value
  *
- * @note The operation is not synchoronized with other threads
+ * @note The operation is not synchronized with other threads
  */
 static inline uint64_t odp_atomic_load_u64(odp_atomic_u64_t *ptr)
 {
@@ -326,7 +326,7 @@  static inline uint64_t odp_atomic_load_u64(odp_atomic_u64_t *ptr)
  * @param ptr        An atomic variable
  * @param new_value  Store new_value to a variable
  *
- * @note The operation is not synchoronized with other threads
+ * @note The operation is not synchronized with other threads
  */
 static inline void odp_atomic_store_u64(odp_atomic_u64_t *ptr,
 					uint64_t new_value)
@@ -427,7 +427,7 @@  static inline void odp_atomic_inc_u64(odp_atomic_u64_t *ptr)
 }
 
 /**
- * Fetch and decement atomic uint64 by 1
+ * Fetch and decrement atomic uint64 by 1
  *
  * @param ptr    An atomic variable
  *
@@ -439,7 +439,7 @@  static inline uint64_t odp_atomic_fetch_dec_u64(odp_atomic_u64_t *ptr)
 }
 
 /**
- * Deccrement atomic uint64 by 1
+ * Decrement atomic uint64 by 1
  *
  * @param ptr    An atomic variable
  *