diff mbox series

[4.19,031/101] ALSA: hda: Reinstate runtime_allow() for all hda controllers

Message ID 20201117122114.605040102@linuxfoundation.org
State New
Headers show
Series None | expand

Commit Message

Greg KH Nov. 17, 2020, 1:04 p.m. UTC 
From: Kai-Heng Feng <kai.heng.feng@canonical.com>

[ Upstream commit 9fc149c3bce7bdbb94948a8e6bd025e3b3538603 ]

The broken jack detection should be fixed by commit a6e7d0a4bdb0 ("ALSA:
hda: fix jack detection with Realtek codecs when in D3"), let's try
enabling runtime PM by default again.

Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Link: https://lore.kernel.org/r/20201027130038.16463-4-kai.heng.feng@canonical.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 sound/pci/hda/hda_intel.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Pavel Machek Nov. 18, 2020, 10:43 a.m. UTC | #1 
Hi!

> From: Kai-Heng Feng <kai.heng.feng@canonical.com>

> 

> [ Upstream commit 9fc149c3bce7bdbb94948a8e6bd025e3b3538603 ]

> 

> The broken jack detection should be fixed by commit a6e7d0a4bdb0 ("ALSA:

> hda: fix jack detection with Realtek codecs when in D3"), let's try

> enabling runtime PM by default again.


I believe experiments should be done in mainline, not in stable.

Worse problem is that a6e7d0a4bdb0 is not in 4.19-stable, so this will
likely break jack detection.

Best regards,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek
Sasha Levin Nov. 18, 2020, 1:40 p.m. UTC | #2 
On Wed, Nov 18, 2020 at 11:43:16AM +0100, Pavel Machek wrote:
>Hi!

>

>> From: Kai-Heng Feng <kai.heng.feng@canonical.com>

>>

>> [ Upstream commit 9fc149c3bce7bdbb94948a8e6bd025e3b3538603 ]

>>

>> The broken jack detection should be fixed by commit a6e7d0a4bdb0 ("ALSA:

>> hda: fix jack detection with Realtek codecs when in D3"), let's try

>> enabling runtime PM by default again.

>

>I believe experiments should be done in mainline, not in stable.

>

>Worse problem is that a6e7d0a4bdb0 is not in 4.19-stable, so this will

>likely break jack detection.


I've dropped it from 4.19, thanks!

-- 
Thanks,
Sasha
diff mbox series

Patch

diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index d43245937db7e..8e1eb5f243a27 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -2478,6 +2478,7 @@  static int azx_probe_continue(struct azx *chip)
 
 	if (azx_has_pm_runtime(chip)) {
 		pm_runtime_use_autosuspend(&pci->dev);
+		pm_runtime_allow(&pci->dev);
 		pm_runtime_put_autosuspend(&pci->dev);
 	}