| Message ID | 20201115192951.1073632-2-jic23@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings: IIO: Drop wrong use of io-channel-ranges then drop it as well. | expand |
On Sun, 15 Nov 2020 19:29:43 +0000 Jonathan Cameron <jic23@kernel.org> wrote: > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > io-channel-ranges is a property for io-channel consumers. Here > it is in an example of a provider of channels so doesn't do anything > useful. > > Recent additions to dt-schema check this property is only provided > alongside io-channels which is not true here and hence an error is > reported. > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > Reported-by: Rob Herring <robh@kernel.org> > Cc: Andy Gross <agross@kernel.org> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: Jishnu Prakash <jprakash@codeaurora.org> I'm not usually keen on taking my own patches without review, but I don't want to leave this obvious breakage in tree longer than necessary. So I've applied this to the togreg branch of iio.git and pushed it out as testing for the autobuilders to poke at it. Note still time for last minute reviews as can rebase for next day or two. Thanks, Jonathan > --- > Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml > index 7f4f827c57a7..95cc705b961b 100644 > --- a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml > @@ -48,8 +48,6 @@ properties: > description: > End of conversion interrupt. > > - io-channel-ranges: true > - > required: > - compatible > - reg > @@ -249,7 +247,6 @@ examples: > #address-cells = <1>; > #size-cells = <0>; > #io-channel-cells = <1>; > - io-channel-ranges; > > /* Channel node */ > adc-chan@39 {
On Sun 15 Nov 13:29 CST 2020, Jonathan Cameron wrote: > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > io-channel-ranges is a property for io-channel consumers. Here > it is in an example of a provider of channels so doesn't do anything > useful. > > Recent additions to dt-schema check this property is only provided > alongside io-channels which is not true here and hence an error is > reported. > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > Reported-by: Rob Herring <robh@kernel.org> > Cc: Andy Gross <agross@kernel.org> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: Jishnu Prakash <jprakash@codeaurora.org> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Regards, Bjorn > --- > Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml > index 7f4f827c57a7..95cc705b961b 100644 > --- a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml > @@ -48,8 +48,6 @@ properties: > description: > End of conversion interrupt. > > - io-channel-ranges: true > - > required: > - compatible > - reg > @@ -249,7 +247,6 @@ examples: > #address-cells = <1>; > #size-cells = <0>; > #io-channel-cells = <1>; > - io-channel-ranges; > > /* Channel node */ > adc-chan@39 { > -- > 2.28.0 >
diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml index 7f4f827c57a7..95cc705b961b 100644 --- a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml +++ b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml @@ -48,8 +48,6 @@ properties: description: End of conversion interrupt. - io-channel-ranges: true - required: - compatible - reg @@ -249,7 +247,6 @@ examples: #address-cells = <1>; #size-cells = <0>; #io-channel-cells = <1>; - io-channel-ranges; /* Channel node */ adc-chan@39 {