| Message ID | 20201112224917.165544-1-robh@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | media: dt-bindings: coda: Add missing 'additionalProperties' | expand |
On Thu, 2020-11-12 at 16:49 -0600, Rob Herring wrote: > 'additionalProperties' is now required by the meta-schema. Add it for > coda. > > Cc: Philipp Zabel <p.zabel@pengutronix.de> > Cc: Mauro Carvalho Chehab <mchehab@kernel.org> > Cc: linux-media@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > Documentation/devicetree/bindings/media/coda.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/coda.yaml b/Documentation/devicetree/bindings/media/coda.yaml > index 7bac0057faf7..be6218354631 100644 > --- a/Documentation/devicetree/bindings/media/coda.yaml > +++ b/Documentation/devicetree/bindings/media/coda.yaml > @@ -59,6 +59,8 @@ required: > - clocks > - clock-names > > +additionalProperties: false > + > allOf: > - if: > properties: Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de> regards Philipp
On Tue, 2020-11-17 at 07:48 -0600, Rob Herring wrote: > On Thu, Nov 12, 2020 at 4:49 PM Rob Herring <robh@kernel.org> wrote: > > 'additionalProperties' is now required by the meta-schema. Add it for > > coda. > > > > Cc: Philipp Zabel <p.zabel@pengutronix.de> > > Cc: Mauro Carvalho Chehab <mchehab@kernel.org> > > Cc: linux-media@vger.kernel.org > > Signed-off-by: Rob Herring <robh@kernel.org> > > --- > > Documentation/devicetree/bindings/media/coda.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > I missed an error this introduces: > > /home/rob/proj/git/linux-dt/.build-arm/Documentation/devicetree/bindings/media/coda.example.dt.yaml: > video-codec@63ff4000: 'interrupts' does not match any of the regexes: > 'pinctrl-[0-9]+' > From schema: > /home/rob/proj/git/linux-dt/Documentation/devicetree/bindings/media/coda.yaml Right, because interrupts are only specified conditionally: allOf: - if: properties: compatible: contains: const: cnm,coda960 then: properties: interrupts: items: - description: BIT processor interrupt - description: JPEG unit interrupt interrupt-names: items: - const: bit - const: jpeg else: properties: interrupts: items: - description: BIT processor interrupt What is the proper way to fix this? regards Philipp
diff --git a/Documentation/devicetree/bindings/media/coda.yaml b/Documentation/devicetree/bindings/media/coda.yaml index 7bac0057faf7..be6218354631 100644 --- a/Documentation/devicetree/bindings/media/coda.yaml +++ b/Documentation/devicetree/bindings/media/coda.yaml @@ -59,6 +59,8 @@ required: - clocks - clock-names +additionalProperties: false + allOf: - if: properties:
'additionalProperties' is now required by the meta-schema. Add it for coda. Cc: Philipp Zabel <p.zabel@pengutronix.de> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> Cc: linux-media@vger.kernel.org Signed-off-by: Rob Herring <robh@kernel.org> --- Documentation/devicetree/bindings/media/coda.yaml | 2 ++ 1 file changed, 2 insertions(+) -- 2.25.1