| Message ID | 20201112104420.GG1997862@dell |
|---|---|
| State | Accepted |
| Commit | c7f0169e3bd274e576f6aaeee86ad2adf7bb14b5 |
| Headers | show |
| Series | input: mouse: elan_i2c_core: Move header inclusion inside | expand |
On Thu, Nov 12, 2020 at 10:44:20AM +0000, Lee Jones wrote: > The same clause as its use. > > Fixes the following W=1 kernel build warning(s): > > include/linux/input/elan-i2c-ids.h:26:36: warning: ‘elan_acpi_id’ defined but not used [-Wunused-const-variable=] > > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> > Cc: Henrik Rydberg <rydberg@bitmath.org> > Cc: Jingle Wu <jingle.wu@emc.com.tw> > Cc: dusonlin@emc.com.tw > Cc: KT Liao <kt.liao@emc.com.tw> > Cc: linux-input@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> Applied, thank you. -- Dmitry
diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c index c599e21a84784..65d21a050cea0 100644 --- a/drivers/input/mouse/elan_i2c_core.c +++ b/drivers/input/mouse/elan_i2c_core.c @@ -34,7 +34,6 @@ #include <linux/completion.h> #include <linux/of.h> #include <linux/property.h> -#include <linux/input/elan-i2c-ids.h> #include <linux/regulator/consumer.h> #include <asm/unaligned.h> @@ -1413,6 +1412,7 @@ static const struct i2c_device_id elan_id[] = { MODULE_DEVICE_TABLE(i2c, elan_id); #ifdef CONFIG_ACPI +#include <linux/input/elan-i2c-ids.h> MODULE_DEVICE_TABLE(acpi, elan_acpi_id); #endif
The same clause as its use. Fixes the following W=1 kernel build warning(s): include/linux/input/elan-i2c-ids.h:26:36: warning: ‘elan_acpi_id’ defined but not used [-Wunused-const-variable=] Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: Henrik Rydberg <rydberg@bitmath.org> Cc: Jingle Wu <jingle.wu@emc.com.tw> Cc: dusonlin@emc.com.tw Cc: KT Liao <kt.liao@emc.com.tw> Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/input/mouse/elan_i2c_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1