| Message ID | 20201111113432.35641-2-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Accepted |
| Commit | 1d112baae84844f3737193c39ac5069f5980ecd1 |
| Headers | show |
| Series | None | expand |
On Wed, Nov 11, 2020 at 01:34:32PM +0200, Andy Shevchenko wrote: > It appears that pin configuration for GPIO chip hasn't been enabled yet > due to absence of ->set_config() callback. > > Enable it here for Intel Lynxpoint PCH. > > Depends-on: 2956b5d94a76 ("pinctrl / gpio: Introduce .set_config() callback for GPIO chips") > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
On Thu, Nov 12, 2020 at 10:00:51AM +0200, Mika Westerberg wrote: > On Wed, Nov 11, 2020 at 01:34:32PM +0200, Andy Shevchenko wrote: > > It appears that pin configuration for GPIO chip hasn't been enabled yet > > due to absence of ->set_config() callback. > > > > Enable it here for Intel Lynxpoint PCH. > > > > Depends-on: 2956b5d94a76 ("pinctrl / gpio: Introduce .set_config() callback for GPIO chips") > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com> Pushed to my review and testing queue, thanks! -- With Best Regards, Andy Shevchenko
diff --git a/drivers/pinctrl/intel/pinctrl-lynxpoint.c b/drivers/pinctrl/intel/pinctrl-lynxpoint.c index 2e9670fc479a..0a48ca46ab59 100644 --- a/drivers/pinctrl/intel/pinctrl-lynxpoint.c +++ b/drivers/pinctrl/intel/pinctrl-lynxpoint.c @@ -874,6 +874,7 @@ static int lp_gpio_probe(struct platform_device *pdev) gc->direction_output = lp_gpio_direction_output; gc->get = lp_gpio_get; gc->set = lp_gpio_set; + gc->set_config = gpiochip_generic_config; gc->get_direction = lp_gpio_get_direction; gc->base = -1; gc->ngpio = LP_NUM_GPIO;
It appears that pin configuration for GPIO chip hasn't been enabled yet due to absence of ->set_config() callback. Enable it here for Intel Lynxpoint PCH. Depends-on: 2956b5d94a76 ("pinctrl / gpio: Introduce .set_config() callback for GPIO chips") Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/pinctrl/intel/pinctrl-lynxpoint.c | 1 + 1 file changed, 1 insertion(+)