diff mbox series

[2/2] ASoC: renesas,rsnd: Update audio graph references

Message ID 1605097613-25301-3-git-send-email-spujar@nvidia.com
State New
Headers show
Series None | expand

Commit Message

Sameer Pujar Nov. 11, 2020, 12:26 p.m. UTC
Since audio graph schema is refactored now update the related
references here.

Signed-off-by: Sameer Pujar <spujar@nvidia.com>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 Documentation/devicetree/bindings/sound/renesas,rsnd.yaml | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Rob Herring Nov. 12, 2020, 4:07 p.m. UTC | #1
On Wed, Nov 11, 2020 at 05:56:53PM +0530, Sameer Pujar wrote:
> Since audio graph schema is refactored now update the related

> references here.

> 

> Signed-off-by: Sameer Pujar <spujar@nvidia.com>

> Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

> ---

>  Documentation/devicetree/bindings/sound/renesas,rsnd.yaml | 6 ++----

>  1 file changed, 2 insertions(+), 4 deletions(-)


This should be part of the first patch. Things break in between.

> 

> diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml

> index 51f4dca..fc2ae22 100644

> --- a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml

> +++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml

> @@ -112,12 +112,10 @@ properties:

>          - pattern: '^clk_(a|b|c|i)$'

>  

>    port:

> -    description: OF-Graph subnode

> -    $ref: "audio-graph-card.yaml#/properties/port"

> +    $ref: /schemas/sound/audio-graph.yaml#/properties/port

>  

>    ports:

> -    description: multi OF-Graph subnode

> -    $ref: "audio-graph-card.yaml#/properties/ports"

> +    $ref: /schemas/graph.yaml#/properties/ports

>  

>  # use patternProperties to avoid naming "xxx,yyy" issue

>  patternProperties:

> -- 

> 2.7.4

>
Rob Herring Nov. 12, 2020, 4:15 p.m. UTC | #2
On Thu, Nov 12, 2020 at 10:07 AM Rob Herring <robh@kernel.org> wrote:
>

> On Wed, Nov 11, 2020 at 05:56:53PM +0530, Sameer Pujar wrote:

> > Since audio graph schema is refactored now update the related

> > references here.

> >

> > Signed-off-by: Sameer Pujar <spujar@nvidia.com>

> > Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

> > ---

> >  Documentation/devicetree/bindings/sound/renesas,rsnd.yaml | 6 ++----

> >  1 file changed, 2 insertions(+), 4 deletions(-)

>

> This should be part of the first patch. Things break in between.

>

> >

> > diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml

> > index 51f4dca..fc2ae22 100644

> > --- a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml

> > +++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml

> > @@ -112,12 +112,10 @@ properties:

> >          - pattern: '^clk_(a|b|c|i)$'

> >

> >    port:

> > -    description: OF-Graph subnode

> > -    $ref: "audio-graph-card.yaml#/properties/port"

> > +    $ref: /schemas/sound/audio-graph.yaml#/properties/port

> >

> >    ports:

> > -    description: multi OF-Graph subnode

> > -    $ref: "audio-graph-card.yaml#/properties/ports"

> > +    $ref: /schemas/graph.yaml#/properties/ports


Actually, with the graph.yaml dependency that doesn't work either. I
think this probably needs to be a ref to just audio-graph.yaml at the
top level and that should pick up port and ports schemas.

Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
index 51f4dca..fc2ae22 100644
--- a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
+++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
@@ -112,12 +112,10 @@  properties:
         - pattern: '^clk_(a|b|c|i)$'
 
   port:
-    description: OF-Graph subnode
-    $ref: "audio-graph-card.yaml#/properties/port"
+    $ref: /schemas/sound/audio-graph.yaml#/properties/port
 
   ports:
-    description: multi OF-Graph subnode
-    $ref: "audio-graph-card.yaml#/properties/ports"
+    $ref: /schemas/graph.yaml#/properties/ports
 
 # use patternProperties to avoid naming "xxx,yyy" issue
 patternProperties: