diff mbox series

dt-bindings: mediatek: mt8192: revert "add audio afe document"

Message ID 1605081920-11848-1-git-send-email-jiaxin.yu@mediatek.com
State Accepted
Commit 7d94ca3c8acd0117200f34523536ee01615e7dc3
Headers show
Series dt-bindings: mediatek: mt8192: revert "add audio afe document" | expand

Commit Message

Jiaxin Yu (俞家鑫) Nov. 11, 2020, 8:05 a.m. UTC
This reverts commit 1afc60e00de3abbb6c559da409c5c1bb8c1d98ec.

Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com>
---
 https://mailman.alsa-project.org/pipermail/alsa-devel/2020-November/176873.html
 These dependency are continuing to upstream, I will revert this patch first.
 After the dependencies are merged, I will send 'mt8192-afe-pcm.yaml' again.

 .../bindings/sound/mt8192-afe-pcm.yaml        | 100 ------------------
 1 file changed, 100 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml

Comments

Rob Herring Nov. 16, 2020, 5:08 p.m. UTC | #1
On Wed, 11 Nov 2020 16:05:20 +0800, Jiaxin Yu wrote:
> This reverts commit 1afc60e00de3abbb6c559da409c5c1bb8c1d98ec.
> 
> Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com>
> ---
>  https://mailman.alsa-project.org/pipermail/alsa-devel/2020-November/176873.html
>  These dependency are continuing to upstream, I will revert this patch first.
>  After the dependencies are merged, I will send 'mt8192-afe-pcm.yaml' again.
> 
>  .../bindings/sound/mt8192-afe-pcm.yaml        | 100 ------------------
>  1 file changed, 100 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml
> 

Acked-by: Rob Herring <robh@kernel.org>
Mark Brown Nov. 18, 2020, 6:07 p.m. UTC | #2
On Wed, Nov 11, 2020 at 04:05:20PM +0800, Jiaxin Yu wrote:
> This reverts commit 1afc60e00de3abbb6c559da409c5c1bb8c1d98ec.
> 
> Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com>
> ---
>  https://mailman.alsa-project.org/pipermail/alsa-devel/2020-November/176873.html
>  These dependency are continuing to upstream, I will revert this patch first.
>  After the dependencies are merged, I will send 'mt8192-afe-pcm.yaml' again.

This description of what the commit does should be part of the
changelog, reverts are just normal patches and should have changelogs
describing what they do just like other changes do.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

Please include human readable descriptions of things like commits and
issues being discussed in e-mail in your mails, this makes them much
easier for humans to read especially when they have no internet access.
I do frequently catch up on my mail on flights or while otherwise
travelling so this is even more pressing for me than just being about
making things a bit easier to read.
Mark Brown Nov. 18, 2020, 8:59 p.m. UTC | #3
On Wed, 11 Nov 2020 16:05:20 +0800, Jiaxin Yu wrote:
> This reverts commit 1afc60e00de3abbb6c559da409c5c1bb8c1d98ec.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: mt8192: revert "add audio afe document"
      commit: 7d94ca3c8acd0117200f34523536ee01615e7dc3

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml b/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml
deleted file mode 100644
index 0170c93802d29..0000000000000
--- a/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml
+++ /dev/null
@@ -1,100 +0,0 @@ 
-# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
-%YAML 1.2
----
-$id: http://devicetree.org/schemas/sound/mt8192-afe-pcm.yaml#
-$schema: http://devicetree.org/meta-schemas/core.yaml#
-
-title: Mediatek AFE PCM controller for mt8192
-
-maintainers:
-   - Jiaxin Yu <jiaxin.yu@mediatek.com>
-   - Shane Chien <shane.chien@mediatek.com>
-
-properties:
-  compatible:
-      const: mediatek,mt8192-audio
-
-  interrupts:
-    maxItems: 1
-
-  resets:
-    maxItems: 1
-
-  reset-names:
-    const: audiosys
-
-  mediatek,apmixedsys:
-    $ref: "/schemas/types.yaml#/definitions/phandle"
-    description: The phandle of the mediatek apmixedsys controller
-
-  mediatek,infracfg:
-    $ref: "/schemas/types.yaml#/definitions/phandle"
-    description: The phandle of the mediatek infracfg controller
-
-  mediatek,topckgen:
-    $ref: "/schemas/types.yaml#/definitions/phandle"
-    description: The phandle of the mediatek topckgen controller
-
-  power-domains:
-    maxItems: 1
-
-  clocks:
-    items:
-      - description: AFE clock
-      - description: ADDA DAC clock
-      - description: ADDA DAC pre-distortion clock
-      - description: audio infra sys clock
-      - description: audio infra 26M clock
-
-  clock-names:
-    items:
-      - const: aud_afe_clk
-      - const: aud_dac_clk
-      - const: aud_dac_predis_clk
-      - const: aud_infra_clk
-      - const: aud_infra_26m_clk
-
-required:
-  - compatible
-  - interrupts
-  - resets
-  - reset-names
-  - mediatek,apmixedsys
-  - mediatek,infracfg
-  - mediatek,topckgen
-  - power-domains
-  - clocks
-  - clock-names
-
-additionalProperties: false
-
-examples:
-  - |
-    #include <dt-bindings/clock/mt8192-clk.h>
-    #include <dt-bindings/interrupt-controller/arm-gic.h>
-    #include <dt-bindings/interrupt-controller/irq.h>
-    #include <dt-bindings/power/mt8192-power.h>
-    #include <dt-bindings/reset-controller/mt8192-resets.h>
-
-    afe: mt8192-afe-pcm {
-        compatible = "mediatek,mt8192-audio";
-        interrupts = <GIC_SPI 202 IRQ_TYPE_LEVEL_HIGH>;
-        resets = <&watchdog MT8192_TOPRGU_AUDIO_SW_RST>;
-        reset-names = "audiosys";
-        mediatek,apmixedsys = <&apmixedsys>;
-        mediatek,infracfg = <&infracfg>;
-        mediatek,topckgen = <&topckgen>;
-        power-domains = <&scpsys MT8192_POWER_DOMAIN_AUDIO>;
-        clocks = <&audsys CLK_AUD_AFE>,
-                 <&audsys CLK_AUD_DAC>,
-                 <&audsys CLK_AUD_DAC_PREDIS>,
-                 <&infracfg CLK_INFRA_AUDIO>,
-                 <&infracfg CLK_INFRA_AUDIO_26M_B>;
-        clock-names = "aud_afe_clk",
-                      "aud_dac_clk",
-                      "aud_dac_predis_clk",
-                      "aud_infra_clk",
-                      "aud_infra_26m_clk";
-    };
-
-...