diff mbox series

[5.4,57/85] drm/vc4: drv: Add error handding for bind

Message ID	20201109125025.308973704@linuxfoundation.org
State	Superseded
Headers	show Return-Path: <SRS0=upl/=EP=vger.kernel.org=stable-owner@kernel.org> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, stable@vger.kernel.org, Hoegeun Kwon <hoegeun.kwon@samsung.com>, Maxime Ripard <maxime@cerno.tech>, Sasha Levin <sashal@kernel.org> Subject: [PATCH 5.4 57/85] drm/vc4: drv: Add error handding for bind Date: Mon, 9 Nov 2020 13:55:54 +0100 Message-Id: <20201109125025.308973704@linuxfoundation.org> In-Reply-To: <20201109125022.614792961@linuxfoundation.org> References: <20201109125022.614792961@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	None \| expand [5.4,02/85] drm/i915/gt: Delay execlist processing for tgl [5.4,03/85] drm/i915: Drop runtime-pm assert from vgpu io accessors [5.4,04/85] ASoC: Intel: Skylake: Add alternative topology binary name [5.4,06/85] arm64: asm: Add new-style position independent function annotations [5.4,07/85] arm64: lib: Use modern annotations for assembly functions [5.4,10/85] ptrace: fix task_join_group_stop() for the case when current is traced [5.4,12/85] chelsio/chtls: fix memory leaks caused by a race [5.4,15/85] gianfar: Account for Tx PTP timestamp in the skb headroom [5.4,16/85] ionic: check port ptr before use [5.4,17/85] ip_tunnel: fix over-mtu packet send fail without TUNNEL_DONT_FRAGMENT flags [5.4,20/85] sctp: Fix COMM_LOST/CANT_STR_ASSOC err reporting on big-endian platforms [5.4,22/85] Fonts: Replace discarded const qualifier [5.4,23/85] ALSA: hda/realtek - Fixed HP headset Mic cant be detected [5.4,26/85] ALSA: usb-audio: add usb vendor id as DSD-capable for Khadas devices [5.4,27/85] ALSA: usb-audio: Add implicit feedback quirk for Qu-16 [5.4,31/85] kthread_worker: prevent queuing delayed work from timer_fn when it is being canceled [5.4,32/85] mm: always have io_remap_pfn_range() set pgprot_decrypted() [5.4,35/85] mtd: spi-nor: Dont copy self-pointing struct around [5.4,37/85] ftrace: Handle tracing when switching between context [5.4,40/85] tracing: Fix out of bounds write in get_trace_buf [5.4,43/85] arm64: dts: meson: add missing g12 rng clock [5.4,44/85] x86/kexec: Use up-to-dated screen_info copy to fill boot params [5.4,46/85] drm/sun4i: frontend: Rework a bit the phase data [5.4,48/85] drm/sun4i: frontend: Fix the scaler phase on A33 [5.4,50/85] blk-cgroup: Pre-allocate tree node on blkg_conf_prep [5.4,51/85] scsi: core: Dont start concurrent async scan on same host [5.4,53/85] scsi: ibmvscsi: Fix potential race after loss of transport [5.4,55/85] nvme-rdma: handle unexpected nvme completion data length [5.4,57/85] drm/vc4: drv: Add error handding for bind [5.4,59/85] usb: cdns3: gadget: suspicious implicit sign extension [5.4,62/85] arm64/smp: Move rcu_cpu_starting() earlier [5.4,63/85] Revert "coresight: Make sysfs functional on topologies with per core sink" [5.4,65/85] fork: fix copy_process(CLONE_PARENT) race with the exiting ->real_parent [5.4,69/85] USB: serial: cyberjack: fix write-URB completion race [5.4,70/85] USB: serial: option: add Quectel EC200T module support [5.4,71/85] USB: serial: option: add LE910Cx compositions 0x1203, 0x1230, 0x1231 [5.4,74/85] tty: serial: fsl_lpuart: LS1021A has a FIFO size of 16 words, like LS1028A [5.4,75/85] usb: dwc3: ep0: Fix delay status handling [5.4,78/85] drm/panfrost: Fix a deadlock between the shrinker and madvise path [5.4,79/85] ARC: stack unwinding: avoid indefinite looping [5.4,81/85] PM: runtime: Drop pm_runtime_clean_up_links() [5.4,83/85] xfs: flush for older, xfs specific ioctls [5.4,85/85] arm64: dts: marvell: espressobin: Add ethernet switch aliases

Commit Message

Greg KH Nov. 9, 2020, 12:55 p.m. UTC

From: Hoegeun Kwon <hoegeun.kwon@samsung.com>

[ Upstream commit 9ce0af3e9573fb84c4c807183d13ea2a68271e4b ]

There is a problem that if vc4_drm bind fails, a memory leak occurs on
the drm_property_create side. Add error handding for drm_mode_config.

Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/20201027041442.30352-2-hoegeun.kwon@samsung.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/gpu/drm/vc4/vc4_drv.c | 1 +
 1 file changed, 1 insertion(+)

diff mbox series

Patch

diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
index 5e6fb6c2307f0..0d78ba017a29b 100644
--- a/drivers/gpu/drm/vc4/vc4_drv.c
+++ b/drivers/gpu/drm/vc4/vc4_drv.c
@@ -309,6 +309,7 @@  static int vc4_drm_bind(struct device *dev)
 	component_unbind_all(dev, drm);
 gem_destroy:
 	vc4_gem_destroy(drm);
+	drm_mode_config_cleanup(drm);
 	vc4_bo_cache_destroy(drm);
 dev_put:
 	drm_dev_put(drm);