diff mbox series

[PATCH-for-5.2,v4,02/17] meson: always include contrib/libvhost-user

Message ID 20201108204535.2319870-3-philmd@redhat.com
State New
Headers show
Series [PATCH-for-5.2,v4,01/17] configure: Check vhost-user is available to build vhost-user-blk-server | expand

Commit Message

Philippe Mathieu-Daudé Nov. 8, 2020, 8:45 p.m. UTC 
From: Stefan Hajnoczi <stefanha@redhat.com>

libvhost-user is needed when CONFIG_LINUX is set. The CONFIG_VHOST_USER
check in meson.build is incorrect.

In fact, no explicit check is needed since this dependency is not built
by default. If something declares a dependency on libvhost-user then it
will be built, otherwise it won't be built (i.e. on non-Linux hosts).

This fixes ./configure --disable-vhost-user && make.

Fixes: bc15e44cb2191bbb2318878acdf5038134e56394 ("configure: introduce --enable-vhost-user-blk-server")
Reported-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reported-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20201106210340.698771-1-stefanha@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 meson.build | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
diff mbox series

Patch

diff --git a/meson.build b/meson.build
index f5175010dfa..b4736203219 100644
--- a/meson.build
+++ b/meson.build
@@ -1450,11 +1450,7 @@ 
   'util',
 ]
 
-vhost_user = not_found
-if 'CONFIG_VHOST_USER' in config_host
-  subdir('contrib/libvhost-user')
-endif
-
+subdir('contrib/libvhost-user')
 subdir('qapi')
 subdir('qobject')
 subdir('stubs')