diff mbox series

[v2] net: atlantic: Remove unnecessary conversion to bool

Message ID 1604797919-10157-1-git-send-email-kaixuxia@tencent.com
State Superseded
Headers show
Series [v2] net: atlantic: Remove unnecessary conversion to bool | expand

Commit Message

xiakaixu1987@gmail.com Nov. 8, 2020, 1:11 a.m. UTC 
From: Kaixu Xia <kaixuxia@tencent.com>

The '!=' expression itself is bool, no need to convert it to bool.
Fix the following coccicheck warning:

./drivers/net/ethernet/aquantia/atlantic/aq_nic.c:1477:34-39: WARNING: conversion to bool not needed here

Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
---
 drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jakub Kicinski Nov. 10, 2020, 11:26 p.m. UTC | #1 
On Sun,  8 Nov 2020 09:11:59 +0800 xiakaixu1987@gmail.com wrote:
> From: Kaixu Xia <kaixuxia@tencent.com>

> 

> The '!=' expression itself is bool, no need to convert it to bool.

> Fix the following coccicheck warning:

> 

> ./drivers/net/ethernet/aquantia/atlantic/aq_nic.c:1477:34-39: WARNING: conversion to bool not needed here

> 

> Reported-by: Tosk Robot <tencent_os_robot@tencent.com>

> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>


Applied.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
index bf5e0e9bd0e2..6c049864dac0 100644
--- a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
+++ b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
@@ -1474,7 +1474,7 @@  int aq_nic_setup_tc_mqprio(struct aq_nic_s *self, u32 tcs, u8 *prio_tc_map)
 		for (i = 0; i < sizeof(cfg->prio_tc_map); i++)
 			cfg->prio_tc_map[i] = cfg->tcs * i / 8;
 
-	cfg->is_qos = (tcs != 0 ? true : false);
+	cfg->is_qos = !!tcs;
 	cfg->is_ptp = (cfg->tcs <= AQ_HW_PTP_TC);
 	if (!cfg->is_ptp)
 		netdev_warn(self->ndev, "%s\n",