| Message ID | 20201107081420.60325-10-damien.lemoal@wdc.com |
|---|---|
| State | Accepted |
| Commit | b72de3ff19fdc4bbe4d4bb3f4483c7e46e00bac3 |
| Headers | show |
| Series | None | expand |
On Sat, Nov 7, 2020 at 9:14 AM Damien Le Moal <damien.lemoal@wdc.com> wrote: > Fix the check on the number of IRQs to allow up to the maximum (32) > instead of only the maximum minus one. > > Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com> I just ripped this patch out of your patch set and applied it to the GPIO tree with some minor change to the subject. Yours, Linus Walleij
diff --git a/drivers/gpio/gpio-sifive.c b/drivers/gpio/gpio-sifive.c index c54dd08f2cbf..d5eb9ca11901 100644 --- a/drivers/gpio/gpio-sifive.c +++ b/drivers/gpio/gpio-sifive.c @@ -183,7 +183,7 @@ static int sifive_gpio_probe(struct platform_device *pdev) return PTR_ERR(chip->regs); ngpio = of_irq_count(node); - if (ngpio >= SIFIVE_GPIO_MAX) { + if (ngpio > SIFIVE_GPIO_MAX) { dev_err(dev, "Too many GPIO interrupts (max=%d)\n", SIFIVE_GPIO_MAX); return -ENXIO;
Fix the check on the number of IRQs to allow up to the maximum (32) instead of only the maximum minus one. Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com> --- drivers/gpio/gpio-sifive.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)