diff mbox series

[v4,17/19] lpfc: vmid: Adding qfpa and vmid timeout check in worker thread

Message ID 1604895845-2587-18-git-send-email-muneendra.kumar@broadcom.com
State Superseded
Headers show
Series [v4,01/19] cgroup: Added cgroup_get_from_kernfs_id | expand

Commit Message

Muneendra Kumar Nov. 9, 2020, 4:24 a.m. UTC
From: Gaurav Srivastava <gaurav.srivastava@broadcom.com>

This patch add the periodic check for issuing of qfpa command and vmid
timeout in the worker thread. The inactivity timeout check is added via
the timer function.

Signed-off-by: Gaurav Srivastava  <gaurav.srivastava@broadcom.com>
Signed-off-by: James Smart <jsmart2021@gmail.com>

---
v4:
No change

v3:
No change

v2:
Ported the patch on top of 5.10/scsi-queue
---
 drivers/scsi/lpfc/lpfc_hbadisc.c | 42 ++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

Comments

Hannes Reinecke Nov. 16, 2020, 8:12 a.m. UTC | #1
On 11/9/20 5:24 AM, Muneendra wrote:
> From: Gaurav Srivastava <gaurav.srivastava@broadcom.com>

> 

> This patch add the periodic check for issuing of qfpa command and vmid

> timeout in the worker thread. The inactivity timeout check is added via

> the timer function.

> 

> Signed-off-by: Gaurav Srivastava  <gaurav.srivastava@broadcom.com>

> Signed-off-by: James Smart <jsmart2021@gmail.com>

> 

> ---

> v4:

> No change

> 

> v3:

> No change

> 

> v2:

> Ported the patch on top of 5.10/scsi-queue

> ---

>   drivers/scsi/lpfc/lpfc_hbadisc.c | 42 ++++++++++++++++++++++++++++++++

>   1 file changed, 42 insertions(+)

> 

> diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c

> index b20013866942..38df3c4341f9 100644

> --- a/drivers/scsi/lpfc/lpfc_hbadisc.c

> +++ b/drivers/scsi/lpfc/lpfc_hbadisc.c

> @@ -433,6 +433,32 @@ lpfc_dev_loss_tmo_handler(struct lpfc_nodelist *ndlp)

>   	return fcf_inuse;

>   }

>   

> +void lpfc_check_vmid_qfpa_issue(struct lpfc_hba *phba)

> +{

> +	struct lpfc_vport *vport;

> +	struct lpfc_vport **vports;

> +	int i, ret;

> +

> +	vports = lpfc_create_vport_work_array(phba);

> +	if (!vports)

> +		return;

> +

> +	for (i = 0; i <= phba->max_vports; i++) {

> +		if ((!vports[i]) && (i == 0))

> +			vport = phba->pport;

> +		else

> +			vport = vports[i];

> +		if (!vport)

> +			break;

> +

> +		if (vport->vmid_flag & LPFC_VMID_ISSUE_QFPA) {

> +			ret = lpfc_issue_els_qfpa(vport);

> +			vport->vmid_flag &= ~LPFC_VMID_ISSUE_QFPA;

> +		}

> +	}

> +	lpfc_destroy_vport_work_array(phba, vports);

> +}

> +

>   /**

>    * lpfc_sli4_post_dev_loss_tmo_handler - SLI4 post devloss timeout handler

>    * @phba: Pointer to hba context object.

> @@ -744,6 +770,22 @@ lpfc_work_done(struct lpfc_hba *phba)

>   	if (ha_copy & HA_LATT)

>   		lpfc_handle_latt(phba);

>   

> +	/* Handle VMID Events */

> +	if (lpfc_is_vmid_enabled(phba)) {

> +		if (phba->pport->work_port_events &

> +		    WORKER_CHECK_VMID_ISSUE_QFPA) {

> +			lpfc_check_vmid_qfpa_issue(phba);

> +			phba->pport->work_port_events &=

> +				~WORKER_CHECK_VMID_ISSUE_QFPA;

> +		}

> +		if (phba->pport->work_port_events &

> +		    WORKER_CHECK_INACTIVE_VMID) {

> +			lpfc_check_inactive_vmid(phba);

> +			phba->pport->work_port_events &=

> +			    ~WORKER_CHECK_INACTIVE_VMID;

> +		}

> +	}

> +

>   	/* Process SLI4 events */

>   	if (phba->pci_dev_grp == LPFC_PCI_DEV_OC) {

>   		if (phba->hba_flag & HBA_RRQ_ACTIVE)

> 

Reviewed-by: Hannes Reinecke <hare@suse.de>


Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
diff mbox series

Patch

diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c
index b20013866942..38df3c4341f9 100644
--- a/drivers/scsi/lpfc/lpfc_hbadisc.c
+++ b/drivers/scsi/lpfc/lpfc_hbadisc.c
@@ -433,6 +433,32 @@  lpfc_dev_loss_tmo_handler(struct lpfc_nodelist *ndlp)
 	return fcf_inuse;
 }
 
+void lpfc_check_vmid_qfpa_issue(struct lpfc_hba *phba)
+{
+	struct lpfc_vport *vport;
+	struct lpfc_vport **vports;
+	int i, ret;
+
+	vports = lpfc_create_vport_work_array(phba);
+	if (!vports)
+		return;
+
+	for (i = 0; i <= phba->max_vports; i++) {
+		if ((!vports[i]) && (i == 0))
+			vport = phba->pport;
+		else
+			vport = vports[i];
+		if (!vport)
+			break;
+
+		if (vport->vmid_flag & LPFC_VMID_ISSUE_QFPA) {
+			ret = lpfc_issue_els_qfpa(vport);
+			vport->vmid_flag &= ~LPFC_VMID_ISSUE_QFPA;
+		}
+	}
+	lpfc_destroy_vport_work_array(phba, vports);
+}
+
 /**
  * lpfc_sli4_post_dev_loss_tmo_handler - SLI4 post devloss timeout handler
  * @phba: Pointer to hba context object.
@@ -744,6 +770,22 @@  lpfc_work_done(struct lpfc_hba *phba)
 	if (ha_copy & HA_LATT)
 		lpfc_handle_latt(phba);
 
+	/* Handle VMID Events */
+	if (lpfc_is_vmid_enabled(phba)) {
+		if (phba->pport->work_port_events &
+		    WORKER_CHECK_VMID_ISSUE_QFPA) {
+			lpfc_check_vmid_qfpa_issue(phba);
+			phba->pport->work_port_events &=
+				~WORKER_CHECK_VMID_ISSUE_QFPA;
+		}
+		if (phba->pport->work_port_events &
+		    WORKER_CHECK_INACTIVE_VMID) {
+			lpfc_check_inactive_vmid(phba);
+			phba->pport->work_port_events &=
+			    ~WORKER_CHECK_INACTIVE_VMID;
+		}
+	}
+
 	/* Process SLI4 events */
 	if (phba->pci_dev_grp == LPFC_PCI_DEV_OC) {
 		if (phba->hba_flag & HBA_RRQ_ACTIVE)