diff mbox series

[v5,02/17] gpiolib: add missed break statement

Message ID 20201109205332.19592-3-andriy.shevchenko@linux.intel.com
State Accepted
Commit 6900fad60ac6987b7c1e4dee2e99e28701a2b8fb
Headers show
Series gpiolib: acpi: pin configuration fixes | expand

Commit Message

Andy Shevchenko Nov. 9, 2020, 8:53 p.m. UTC 
It's no difference in the functionality, but after the change the code
is less error prone to various checkers.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpio/gpiolib.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Mika Westerberg Nov. 11, 2020, 3:18 p.m. UTC | #1 
On Mon, Nov 09, 2020 at 10:53:17PM +0200, Andy Shevchenko wrote:
> It's no difference in the functionality, but after the change the code

> is less error prone to various checkers.

> 

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>


Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
diff mbox series

Patch

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index f94225d7817b..b45487aace7e 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -2108,6 +2108,7 @@  static int gpio_set_config(struct gpio_desc *desc, enum pin_config_param mode)
 
 	default:
 		arg = 0;
+		break;
 	}
 
 	config = PIN_CONF_PACKED(mode, arg);