| Message ID | 1403103172-19856-4-git-send-email-lee.jones@linaro.org |
|---|---|
| State | New |
| Headers | show |
Hi Lee, > All the infrastructure is now in place for ST's PWM controller. This > patch takes the final step and enables the IP on the 2020 Rev-E > development platform. Why are you only enabling this for rev-E board? If you make the stih415 DT PWM nodes part of this series as well, then assuming there is no good reason to the contary, the PWM could be enabled for both stih415/6 in the common stih41x-b2020 DTS file which is also included by rev-E (assuming that PWM wiring is not some rev-E specific thing). Also Ajit Signed-off-by needs adding to this series. After that: Acked-by: Peter Griffin <peter.griffin@linaro.org> regards, Peter. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> > All the infrastructure is now in place for ST's PWM controller. This > > patch takes the final step and enables the IP on the 2020 Rev-E > > development platform. > > Why are you only enabling this for rev-E board? Purely for testing purposes, as it's the only board I have. If anyone has the other revisions and would be happy to test the driver for me then great. > If you make the stih415 DT PWM nodes part of this series as well, then > assuming there is no good reason to the contary, the PWM could > be enabled for both stih415/6 in the common stih41x-b2020 DTS file which > is also included by rev-E (assuming that PWM wiring is not some rev-E specific > thing). > > Also Ajit Signed-off-by needs adding to this series. As you know, Thierry already picked this up. Will fix for v2. > After that: > Acked-by: Peter Griffin <peter.griffin@linaro.org> Thanks.
Hi Lee, > > Why are you only enabling this for rev-E board? > > Purely for testing purposes, as it's the only board I have. If > anyone has the other revisions and would be happy to test the driver > for me then great. Ok that's what I suspected. If you tell me how, I can test on a Rev C board. But as there are several other revisions I think checking the board schematics would be the quickest way forward. > > If you make the stih415 DT PWM nodes part of this series as well, then > > assuming there is no good reason to the contary, the PWM could > > be enabled for both stih415/6 in the common stih41x-b2020 DTS file which > > is also included by rev-E (assuming that PWM wiring is not some rev-E specific > > thing). Can you add the stih415 bindings in V2 as well? regards, Peter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
> > > Why are you only enabling this for rev-E board? > > > > Purely for testing purposes, as it's the only board I have. If > > anyone has the other revisions and would be happy to test the driver > > for me then great. > > Ok that's what I suspected. > > If you tell me how, I can test on a Rev C board. But as there are several other > revisions I think checking the board schematics would be the quickest way forward. Great. Do you have a oscilloscope/logic analyser? > > > If you make the stih415 DT PWM nodes part of this series as well, then > > > assuming there is no good reason to the contary, the PWM could > > > be enabled for both stih415/6 in the common stih41x-b2020 DTS file which > > > is also included by rev-E (assuming that PWM wiring is not some rev-E specific > > > thing). > > Can you add the stih415 bindings in V2 as well? Who's using Orly1?
Hi Lee, > > > Purely for testing purposes, as it's the only board I have. If > > > anyone has the other revisions and would be happy to test the driver > > > for me then great. > > > > Ok that's what I suspected. > > > > If you tell me how, I can test on a Rev C board. But as there are several other > > revisions I think checking the board schematics would be the quickest way forward. > > Great. Do you have a oscilloscope/logic analyser? I have an old scope, and I've been wanting to buy a decent logic analyser ;-) Also can you email me the rev E schematic? I currently only have rev C. > > > > If you make the stih415 DT PWM nodes part of this series as well, then > > > > assuming there is no good reason to the contary, the PWM could > > > > be enabled for both stih415/6 in the common stih41x-b2020 DTS file which > > > > is also included by rev-E (assuming that PWM wiring is not some rev-E specific > > > > thing). > > > > Can you add the stih415 bindings in V2 as well? > > Who's using Orly1? I'll let ST answer that. AFAIK drivers upstreamed so far for Orly based hardware have generally been enabled for both SoCs, hence querying why the stih415 bindings are missing from this series. Being pinout compatible, a b2020 board can be populated with a stih415, so it seems strange for it to then be missing PWM support given that the SoC, board and pwm driver all support it. regards, Peter. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
diff --git a/arch/arm/boot/dts/stih416-b2020e.dts b/arch/arm/boot/dts/stih416-b2020e.dts index ba0fa2c..07cbf5b 100644 --- a/arch/arm/boot/dts/stih416-b2020e.dts +++ b/arch/arm/boot/dts/stih416-b2020e.dts @@ -31,5 +31,15 @@ ethernet1: dwmac@fef08000 { snps,reset-gpio = <&PIO0 7>; }; + + /* SAS PWM Module */ + pwm0: pwm@fed10000 { + status = "okay"; + }; + + /* SBC PWM Module */ + pwm1: pwm@fe510000 { + status = "okay"; + }; }; };
All the infrastructure is now in place for ST's PWM controller. This patch takes the final step and enables the IP on the 2020 Rev-E development platform. Signed-off-by: Lee Jones <lee.jones@linaro.org> --- arch/arm/boot/dts/stih416-b2020e.dts | 10 ++++++++++ 1 file changed, 10 insertions(+)