diff mbox series

[1/8] dt-bindings: mfd: ti,j721e-system-controller.yaml: Document "pcie-ctrl"

Message ID 20201102101154.13598-2-kishon@ti.com
State New
Headers show
Series J7200: Add PCIe DT nodes to Enable PCIe | expand

Commit Message

Kishon Vijay Abraham I Nov. 2, 2020, 10:11 a.m. UTC
Add binding documentation for "pcie-ctrl" which should be a subnode of
the system controller.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>

---
 .../devicetree/bindings/mfd/ti,j721e-system-controller.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

-- 
2.17.1

Comments

Rob Herring (Arm) Nov. 5, 2020, 4:54 p.m. UTC | #1
On Mon, Nov 02, 2020 at 03:41:47PM +0530, Kishon Vijay Abraham I wrote:
> Add binding documentation for "pcie-ctrl" which should be a subnode of

> the system controller.

> 

> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>

> ---

>  .../devicetree/bindings/mfd/ti,j721e-system-controller.yaml | 6 ++++++

>  1 file changed, 6 insertions(+)

> 

> diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml

> index 19fcf59fd2fe..fd985794e419 100644

> --- a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml

> +++ b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml

> @@ -50,6 +50,12 @@ patternProperties:

>        specified in

>        Documentation/devicetree/bindings/mux/reg-mux.txt

>  

> +  "^pcie-ctrl@[0-9a-f]+$":


Unit address, so it should have 'reg' too?

You don't need a node if there aren't any properties.

> +    type: object

> +    description: |

> +      This is the PCIe controller configuration required to configre PCIe

> +      mode, lane width and speed.

> +

>  required:

>    - compatible

>    - reg

> -- 

> 2.17.1

>
Kishon Vijay Abraham I Nov. 9, 2020, 2:17 p.m. UTC | #2
Hi Rob,

On 05/11/20 10:24 pm, Rob Herring wrote:
> On Mon, Nov 02, 2020 at 03:41:47PM +0530, Kishon Vijay Abraham I wrote:

>> Add binding documentation for "pcie-ctrl" which should be a subnode of

>> the system controller.

>>

>> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>

>> ---

>>  .../devicetree/bindings/mfd/ti,j721e-system-controller.yaml | 6 ++++++

>>  1 file changed, 6 insertions(+)

>>

>> diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml

>> index 19fcf59fd2fe..fd985794e419 100644

>> --- a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml

>> +++ b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml

>> @@ -50,6 +50,12 @@ patternProperties:

>>        specified in

>>        Documentation/devicetree/bindings/mux/reg-mux.txt

>>  

>> +  "^pcie-ctrl@[0-9a-f]+$":

> 

> Unit address, so it should have 'reg' too?

> 

> You don't need a node if there aren't any properties.


The subnodes are again a syscon node. I'll fix this up in the next revision.

Thank You,
Kishon
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
index 19fcf59fd2fe..fd985794e419 100644
--- a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
+++ b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
@@ -50,6 +50,12 @@  patternProperties:
       specified in
       Documentation/devicetree/bindings/mux/reg-mux.txt
 
+  "^pcie-ctrl@[0-9a-f]+$":
+    type: object
+    description: |
+      This is the PCIe controller configuration required to configre PCIe
+      mode, lane width and speed.
+
 required:
   - compatible
   - reg