| Message ID | 20201105193512.22388-6-michael@walle.cc |
|---|---|
| State | Superseded |
| Headers | show |
| Series | clk: add fsl-flexspi driver | expand |
> -----Original Message----- > From: Michael Walle <michael@walle.cc> > Sent: Thursday, November 5, 2020 1:35 PM > To: linux-clk@vger.kernel.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org > Cc: Michael Turquette <mturquette@baylibre.com>; Stephen Boyd > <sboyd@kernel.org>; Rob Herring <robh+dt@kernel.org>; Shawn Guo > <shawnguo@kernel.org>; Leo Li <leoyang.li@nxp.com>; Michael Walle > <michael@walle.cc> > Subject: [PATCH v2 5/5] arm64: dts: lx2160a: fix FlexSPI clock > > Now that we have a proper driver for the FlexSPI interface use it. This will fix > SCK frequency switching on Layerscape SoCs. > > This was only compile time tested. > > Signed-off-by: Michael Walle <michael@walle.cc> > --- > Changes since v1: > - none > > arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > index 83072da6f6c6..6e375e80bd35 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > @@ -659,9 +659,20 @@ > }; > > dcfg: syscon@1e00000 { > - compatible = "fsl,lx2160a-dcfg", "syscon"; > + #address-cells = <1>; > + #size-cells = <1>; > + compatible = "fsl,lx2160a-dcfg", "syscon", "simple- > mfd"; > reg = <0x0 0x1e00000 0x0 0x10000>; > + ranges = <0x0 0x0 0x1e00000 0x10000>; > little-endian; > + > + fspi_clk: clock-controller@900 { > + compatible = "fsl,lx2160a-flexspi-clk"; > + reg = <0x900 0x4>; > + #clock-cells = <0>; > + clocks = <&clockgen 4 0>; This is different from the current <&clockgen 4 3>, is it an intended change? > + clock-output-names = "fspi_clk"; > + }; > }; > > tmu: tmu@1f80000 { > @@ -776,7 +787,7 @@ > <0x0 0x20000000 0x0 0x10000000>; > reg-names = "fspi_base", "fspi_mmap"; > interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&clockgen 4 3>, <&clockgen 4 3>; > + clocks = <&clockgen 4 3>, <&fspi_clk>; > clock-names = "fspi_en", "fspi"; > status = "disabled"; > }; > -- > 2.20.1
Am 2020-11-06 03:00, schrieb Leo Li: >> -----Original Message----- >> From: Michael Walle <michael@walle.cc> >> Sent: Thursday, November 5, 2020 1:35 PM >> To: linux-clk@vger.kernel.org; devicetree@vger.kernel.org; linux- >> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org >> Cc: Michael Turquette <mturquette@baylibre.com>; Stephen Boyd >> <sboyd@kernel.org>; Rob Herring <robh+dt@kernel.org>; Shawn Guo >> <shawnguo@kernel.org>; Leo Li <leoyang.li@nxp.com>; Michael Walle >> <michael@walle.cc> >> Subject: [PATCH v2 5/5] arm64: dts: lx2160a: fix FlexSPI clock >> >> Now that we have a proper driver for the FlexSPI interface use it. >> This will fix >> SCK frequency switching on Layerscape SoCs. >> >> This was only compile time tested. >> >> Signed-off-by: Michael Walle <michael@walle.cc> >> --- >> Changes since v1: >> - none >> >> arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 15 +++++++++++++-- >> 1 file changed, 13 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi >> b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi >> index 83072da6f6c6..6e375e80bd35 100644 >> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi >> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi >> @@ -659,9 +659,20 @@ >> }; >> >> dcfg: syscon@1e00000 { >> - compatible = "fsl,lx2160a-dcfg", "syscon"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + compatible = "fsl,lx2160a-dcfg", "syscon", "simple- >> mfd"; >> reg = <0x0 0x1e00000 0x0 0x10000>; >> + ranges = <0x0 0x0 0x1e00000 0x10000>; >> little-endian; >> + >> + fspi_clk: clock-controller@900 { >> + compatible = "fsl,lx2160a-flexspi-clk"; >> + reg = <0x900 0x4>; >> + #clock-cells = <0>; >> + clocks = <&clockgen 4 0>; > > This is different from the current <&clockgen 4 3>, is it an intended > change? Yes, this change was intended. At least on the LS1028A this clock divider is connected to the platform base clock. I don't know why there was "<&clockgen 4 3>" in the first place. But because the clkgen clock cannot be changed it didn't matter before this commit. The flexspi driver only calls clk_set_rate(), never clk_get_rate(). On the LS1028A I actually meassured the resulting SCK frequency. Looking at Figure 7. (Clock subsystem block diagram) in the LX2160A RM, this seems to be the case here, too. -michael
Am 2020-11-06 09:11, schrieb Michael Walle: > Am 2020-11-06 03:00, schrieb Leo Li: >>> -----Original Message----- >>> From: Michael Walle <michael@walle.cc> >>> Sent: Thursday, November 5, 2020 1:35 PM >>> To: linux-clk@vger.kernel.org; devicetree@vger.kernel.org; linux- >>> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org >>> Cc: Michael Turquette <mturquette@baylibre.com>; Stephen Boyd >>> <sboyd@kernel.org>; Rob Herring <robh+dt@kernel.org>; Shawn Guo >>> <shawnguo@kernel.org>; Leo Li <leoyang.li@nxp.com>; Michael Walle >>> <michael@walle.cc> >>> Subject: [PATCH v2 5/5] arm64: dts: lx2160a: fix FlexSPI clock >>> >>> Now that we have a proper driver for the FlexSPI interface use it. >>> This will fix >>> SCK frequency switching on Layerscape SoCs. >>> >>> This was only compile time tested. >>> >>> Signed-off-by: Michael Walle <michael@walle.cc> >>> --- >>> Changes since v1: >>> - none >>> >>> arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 15 +++++++++++++-- >>> 1 file changed, 13 insertions(+), 2 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi >>> b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi >>> index 83072da6f6c6..6e375e80bd35 100644 >>> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi >>> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi >>> @@ -659,9 +659,20 @@ >>> }; >>> >>> dcfg: syscon@1e00000 { >>> - compatible = "fsl,lx2160a-dcfg", "syscon"; >>> + #address-cells = <1>; >>> + #size-cells = <1>; >>> + compatible = "fsl,lx2160a-dcfg", "syscon", "simple- >>> mfd"; >>> reg = <0x0 0x1e00000 0x0 0x10000>; >>> + ranges = <0x0 0x0 0x1e00000 0x10000>; >>> little-endian; >>> + >>> + fspi_clk: clock-controller@900 { >>> + compatible = "fsl,lx2160a-flexspi-clk"; >>> + reg = <0x900 0x4>; >>> + #clock-cells = <0>; >>> + clocks = <&clockgen 4 0>; >> >> This is different from the current <&clockgen 4 3>, is it an intended >> change? > > Yes, this change was intended. At least on the LS1028A this clock > divider is > connected to the platform base clock. I don't know why there was > "<&clockgen 4 3>" in the first place. But because the clkgen clock > cannot > be changed it didn't matter before this commit. The flexspi driver only > calls clk_set_rate(), never clk_get_rate(). On the LS1028A I actually > meassured the resulting SCK frequency. > Looking at Figure 7. (Clock subsystem block diagram) in the LX2160A RM, > this > seems to be the case here, too. Btw on the LS1028A this should be "<&clockgen 2 0>;" Will be fixed in the new version. And because there so much difference between LS1028A and LX2160A, I'll mark the last patch (this one, for the LX2160A) as RFC until someone will test it. -michael
diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi index 83072da6f6c6..6e375e80bd35 100644 --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi @@ -659,9 +659,20 @@ }; dcfg: syscon@1e00000 { - compatible = "fsl,lx2160a-dcfg", "syscon"; + #address-cells = <1>; + #size-cells = <1>; + compatible = "fsl,lx2160a-dcfg", "syscon", "simple-mfd"; reg = <0x0 0x1e00000 0x0 0x10000>; + ranges = <0x0 0x0 0x1e00000 0x10000>; little-endian; + + fspi_clk: clock-controller@900 { + compatible = "fsl,lx2160a-flexspi-clk"; + reg = <0x900 0x4>; + #clock-cells = <0>; + clocks = <&clockgen 4 0>; + clock-output-names = "fspi_clk"; + }; }; tmu: tmu@1f80000 { @@ -776,7 +787,7 @@ <0x0 0x20000000 0x0 0x10000000>; reg-names = "fspi_base", "fspi_mmap"; interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&clockgen 4 3>, <&clockgen 4 3>; + clocks = <&clockgen 4 3>, <&fspi_clk>; clock-names = "fspi_en", "fspi"; status = "disabled"; };
Now that we have a proper driver for the FlexSPI interface use it. This will fix SCK frequency switching on Layerscape SoCs. This was only compile time tested. Signed-off-by: Michael Walle <michael@walle.cc> --- Changes since v1: - none arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-)