diff mbox series

arm64: dts: imx8m: use generic name for tmu

Message ID 1603351278-8198-1-git-send-email-peng.fan@nxp.com
State New
Headers show
Series arm64: dts: imx8m: use generic name for tmu | expand

Commit Message

Peng Fan Oct. 22, 2020, 7:21 a.m. UTC
From: Peng Fan <peng.fan@nxp.com>


Per devicetree specification, generic names are recommended
to be used, such as temperature-sensor.

Signed-off-by: Peng Fan <peng.fan@nxp.com>

---
 arch/arm64/boot/dts/freescale/imx8mm.dtsi | 2 +-
 arch/arm64/boot/dts/freescale/imx8mn.dtsi | 2 +-
 arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
 arch/arm64/boot/dts/freescale/imx8mq.dtsi | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

-- 
2.28.0

Comments

Krzysztof Kozlowski Oct. 22, 2020, 9:06 a.m. UTC | #1
On Thu, Oct 22, 2020 at 03:21:18PM +0800, peng.fan@nxp.com wrote:
> From: Peng Fan <peng.fan@nxp.com>

> 

> Per devicetree specification, generic names are recommended

> to be used, such as temperature-sensor.

> 

> Signed-off-by: Peng Fan <peng.fan@nxp.com>

> ---

>  arch/arm64/boot/dts/freescale/imx8mm.dtsi | 2 +-

>  arch/arm64/boot/dts/freescale/imx8mn.dtsi | 2 +-

>  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-

>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 2 +-

>  4 files changed, 4 insertions(+), 4 deletions(-)

> 

> diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi

> index b83f400def8b..327f1d44ced9 100644

> --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi

> +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi

> @@ -404,7 +404,7 @@ gpio5: gpio@30240000 {

>  				gpio-ranges = <&iomuxc 0 119 30>;

>  			};

>  

> -			tmu: tmu@30260000 {

> +			tmu: temperature-sensor@30260000 {


No, TMU is not a temperature-sensor. It does much more. TMU is quite
generic name for this class of device.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
index b83f400def8b..327f1d44ced9 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
@@ -404,7 +404,7 @@  gpio5: gpio@30240000 {
 				gpio-ranges = <&iomuxc 0 119 30>;
 			};
 
-			tmu: tmu@30260000 {
+			tmu: temperature-sensor@30260000 {
 				compatible = "fsl,imx8mm-tmu";
 				reg = <0x30260000 0x10000>;
 				clocks = <&clk IMX8MM_CLK_TMU_ROOT>;
diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
index 746faf1cf2fb..994fcb021b8f 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
@@ -311,7 +311,7 @@  gpio5: gpio@30240000 {
 				gpio-ranges = <&iomuxc 0 119 30>;
 			};
 
-			tmu: tmu@30260000 {
+			tmu: temperature-sensor@30260000 {
 				compatible = "fsl,imx8mn-tmu", "fsl,imx8mm-tmu";
 				reg = <0x30260000 0x10000>;
 				clocks = <&clk IMX8MN_CLK_TMU_ROOT>;
diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index 6038f66aefc1..2a16016b1cf4 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -288,7 +288,7 @@  gpio5: gpio@30240000 {
 				gpio-ranges = <&iomuxc 0 114 30>;
 			};
 
-			tmu: tmu@30260000 {
+			tmu: temperature-sensor@30260000 {
 				compatible = "fsl,imx8mp-tmu";
 				reg = <0x30260000 0x10000>;
 				clocks = <&clk IMX8MP_CLK_TSENSOR_ROOT>;
diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index 5e0e7d0f1bc4..ab57839a3de1 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -420,7 +420,7 @@  gpio5: gpio@30240000 {
 				gpio-ranges = <&iomuxc 0 119 30>;
 			};
 
-			tmu: tmu@30260000 {
+			tmu: temperature-sensor@30260000 {
 				compatible = "fsl,imx8mq-tmu";
 				reg = <0x30260000 0x10000>;
 				interrupts = <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>;