diff mbox series

[v2] net: macvlan: remove redundant initialization in macvlan_dev_netpoll_setup

Message ID 1604541244-3241-1-git-send-email-dong.menglong@zte.com.cn
State New
Headers show
Series [v2] net: macvlan: remove redundant initialization in macvlan_dev_netpoll_setup | expand

Commit Message

Menglong Dong Nov. 5, 2020, 1:54 a.m. UTC 
From: Menglong Dong <dong.menglong@zte.com.cn>

The initialization for err with 0 seems useless, as it is soon updated
with -ENOMEM. So, we can remove it.

Changes since v1:
-Keep -ENOMEM still.

Signed-off-by: Menglong Dong <dong.menglong@zte.com.cn>
---
 drivers/net/macvlan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jakub Kicinski Nov. 7, 2020, 8:20 p.m. UTC | #1 
On Wed,  4 Nov 2020 20:54:04 -0500 menglong8.dong@gmail.com wrote:
> From: Menglong Dong <dong.menglong@zte.com.cn>

> 

> The initialization for err with 0 seems useless, as it is soon updated

> with -ENOMEM. So, we can remove it.

> 

> Changes since v1:

> -Keep -ENOMEM still.

> 

> Signed-off-by: Menglong Dong <dong.menglong@zte.com.cn>


Applied.
diff mbox series

Patch

diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c
index dd96020..d9b6c44 100644
--- a/drivers/net/macvlan.c
+++ b/drivers/net/macvlan.c
@@ -1096,7 +1096,7 @@  static int macvlan_dev_netpoll_setup(struct net_device *dev, struct netpoll_info
 	struct macvlan_dev *vlan = netdev_priv(dev);
 	struct net_device *real_dev = vlan->lowerdev;
 	struct netpoll *netpoll;
-	int err = 0;
+	int err;
 
 	netpoll = kzalloc(sizeof(*netpoll), GFP_KERNEL);
 	err = -ENOMEM;