| Message ID | 20201102102815.1102222-1-mst@redhat.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2] pc: comment style fixup | expand |
On 11/2/20 11:28 AM, Michael S. Tsirkin wrote: > Fix up checkpatch comment style warnings. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > --- > > changes from v1: > address philippe's comments > :w > > hw/i386/pc.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) Thanks! Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> -----Original Message----- > From: Qemu-devel > [mailto:qemu-devel-bounces+kuhn.chenqun=huawei.com@nongnu.org] On > Behalf Of Michael S. Tsirkin > Sent: Monday, November 2, 2020 6:29 PM > To: qemu-devel@nongnu.org > Cc: Paolo Bonzini <pbonzini@redhat.com>; Eduardo Habkost > <ehabkost@redhat.com>; Richard Henderson <rth@twiddle.net> > Subject: [PATCH v2] pc: comment style fixup > > Fix up checkpatch comment style warnings. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > --- > > changes from v1: > address philippe's comments > :w > > hw/i386/pc.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 416fb0e0f6..aae45ba779 100644 > --- a/hw/i386/pc.c > +++ b/hw/i386/pc.c > @@ -1149,10 +1149,11 @@ void pc_basic_device_init(struct PCMachineState > *pcms, > error_report("couldn't create HPET device"); > exit(1); > } > - /* For pc-piix-*, hpet's intcap is always IRQ2. For pc-q35-1.7 > - * and earlier, use IRQ2 for compat. Otherwise, use IRQ16~23, > - * IRQ8 and IRQ2. > - */ > + /* > + * For pc-piix-*, hpet's intcap is always IRQ2. For pc-q35-1.7 and > + * earlier, use IRQ2 for compat. Otherwise, use IRQ16~23, IRQ8 and > + * IRQ2. > + */ > uint8_t compat = object_property_get_uint(OBJECT(hpet), > HPET_INTCAP, NULL); > if (!compat) { > -- > MST > Reviewed-by: Chen Qun <kuhn.chenqun@huawei.com>
diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 416fb0e0f6..aae45ba779 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1149,10 +1149,11 @@ void pc_basic_device_init(struct PCMachineState *pcms, error_report("couldn't create HPET device"); exit(1); } - /* For pc-piix-*, hpet's intcap is always IRQ2. For pc-q35-1.7 - * and earlier, use IRQ2 for compat. Otherwise, use IRQ16~23, - * IRQ8 and IRQ2. - */ + /* + * For pc-piix-*, hpet's intcap is always IRQ2. For pc-q35-1.7 and + * earlier, use IRQ2 for compat. Otherwise, use IRQ16~23, IRQ8 and + * IRQ2. + */ uint8_t compat = object_property_get_uint(OBJECT(hpet), HPET_INTCAP, NULL); if (!compat) {
Fix up checkpatch comment style warnings. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- changes from v1: address philippe's comments :w hw/i386/pc.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)