diff mbox series

ssi: Fix bad printf format specifiers

Message ID 5FA280F5.8060902@huawei.com
State Superseded
Headers show
Series ssi: Fix bad printf format specifiers | expand

Commit Message

Alex Chen Nov. 4, 2020, 10:22 a.m. UTC 
We should use printf format specifier "%u" instead of "%d" for
argument of type "unsigned int".

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Alex Chen <alex.chen@huawei.com>
---
 hw/ssi/imx_spi.c    | 2 +-
 hw/ssi/xilinx_spi.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Alistair Francis Nov. 4, 2020, 4:21 p.m. UTC | #1 
On Wed, Nov 4, 2020 at 2:23 AM AlexChen <alex.chen@huawei.com> wrote:
>
> We should use printf format specifier "%u" instead of "%d" for
> argument of type "unsigned int".
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Alex Chen <alex.chen@huawei.com>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>  hw/ssi/imx_spi.c    | 2 +-
>  hw/ssi/xilinx_spi.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/ssi/imx_spi.c b/hw/ssi/imx_spi.c
> index 7f703d8328..d8885ae454 100644
> --- a/hw/ssi/imx_spi.c
> +++ b/hw/ssi/imx_spi.c
> @@ -53,7 +53,7 @@ static const char *imx_spi_reg_name(uint32_t reg)
>      case ECSPI_MSGDATA:
>          return  "ECSPI_MSGDATA";
>      default:
> -        sprintf(unknown, "%d ?", reg);
> +        sprintf(unknown, "%u ?", reg);
>          return unknown;
>      }
>  }
> diff --git a/hw/ssi/xilinx_spi.c b/hw/ssi/xilinx_spi.c
> index fec8817d94..49ff275593 100644
> --- a/hw/ssi/xilinx_spi.c
> +++ b/hw/ssi/xilinx_spi.c
> @@ -142,7 +142,7 @@ static void xlx_spi_update_irq(XilinxSPI *s)
>         irq chain unless things really changed.  */
>      if (pending != s->irqline) {
>          s->irqline = pending;
> -        DB_PRINT("irq_change of state %d ISR:%x IER:%X\n",
> +        DB_PRINT("irq_change of state %u ISR:%x IER:%X\n",
>                      pending, s->regs[R_IPISR], s->regs[R_IPIER]);
>          qemu_set_irq(s->irq, pending);
>      }
> --
> 2.19.1
>
Peter Maydell Nov. 4, 2020, 5:58 p.m. UTC | #2 
On Wed, 4 Nov 2020 at 16:33, Alistair Francis <alistair23@gmail.com> wrote:
>
> On Wed, Nov 4, 2020 at 2:23 AM AlexChen <alex.chen@huawei.com> wrote:
> >
> > We should use printf format specifier "%u" instead of "%d" for
> > argument of type "unsigned int".
> >
> > Reported-by: Euler Robot <euler.robot@huawei.com>
> > Signed-off-by: Alex Chen <alex.chen@huawei.com>
>
> Reviewed-by: Alistair Francis <alistair.francis@wdc.com>



Applied to target-arm.next, thanks.

-- PMM
Chubb, Peter (Data61, Kensington NSW) Nov. 4, 2020, 9:39 p.m. UTC | #3 
>>>>> "AlexChen" == AlexChen  <alex.chen@huawei.com> writes:

AlexChen> We should use printf format specifier "%u" instead of "%d"
AlexChen> for argument of type "unsigned int".

AlexChen> Reported-by: Euler Robot <euler.robot@huawei.com>
AlexChen>Signed-off-by: Alex Chen <alex.chen@huawei.com> ---

LGTM,
add
Reviewed-By: Peter Chubb <peter.chubb@data61.csiro.au>
diff mbox series

Patch

diff --git a/hw/ssi/imx_spi.c b/hw/ssi/imx_spi.c
index 7f703d8328..d8885ae454 100644
--- a/hw/ssi/imx_spi.c
+++ b/hw/ssi/imx_spi.c
@@ -53,7 +53,7 @@  static const char *imx_spi_reg_name(uint32_t reg)
     case ECSPI_MSGDATA:
         return  "ECSPI_MSGDATA";
     default:
-        sprintf(unknown, "%d ?", reg);
+        sprintf(unknown, "%u ?", reg);
         return unknown;
     }
 }
diff --git a/hw/ssi/xilinx_spi.c b/hw/ssi/xilinx_spi.c
index fec8817d94..49ff275593 100644
--- a/hw/ssi/xilinx_spi.c
+++ b/hw/ssi/xilinx_spi.c
@@ -142,7 +142,7 @@  static void xlx_spi_update_irq(XilinxSPI *s)
        irq chain unless things really changed.  */
     if (pending != s->irqline) {
         s->irqline = pending;
-        DB_PRINT("irq_change of state %d ISR:%x IER:%X\n",
+        DB_PRINT("irq_change of state %u ISR:%x IER:%X\n",
                     pending, s->regs[R_IPISR], s->regs[R_IPIER]);
         qemu_set_irq(s->irq, pending);
     }