diff mbox series

[net-next,v4] net: dec: tulip: de2104x: Add shutdown handler to stop NIC

Message ID 20201028172125.496942-1-mdf@kernel.org
State New
Headers show
Series [net-next,v4] net: dec: tulip: de2104x: Add shutdown handler to stop NIC | expand

Commit Message

Moritz Fischer Oct. 28, 2020, 5:21 p.m. UTC
The driver does not implement a shutdown handler which leads to issues
when using kexec in certain scenarios. The NIC keeps on fetching
descriptors which gets flagged by the IOMMU with errors like this:

DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr fffff000
DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr fffff000
DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr fffff000
DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr fffff000
DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr fffff000

Signed-off-by: Moritz Fischer <mdf@kernel.org>
---

Changes from v3:
- Added rtnl_lock()/unlock() as suggested by Jakub and use dev_close()

Changes from v2:
- Changed to net-next
- Removed extra whitespace

Changes from v1:
- Replace call to de_remove_one with de_shutdown() function
  as suggested by James.

---
 drivers/net/ethernet/dec/tulip/de2104x.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Jakub Kicinski Oct. 31, 2020, 12:16 a.m. UTC | #1
On Wed, 28 Oct 2020 10:21:25 -0700 Moritz Fischer wrote:
> The driver does not implement a shutdown handler which leads to issues

> when using kexec in certain scenarios. The NIC keeps on fetching

> descriptors which gets flagged by the IOMMU with errors like this:

> 

> DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr fffff000

> DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr fffff000

> DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr fffff000

> DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr fffff000

> DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr fffff000

> 

> Signed-off-by: Moritz Fischer <mdf@kernel.org>


Applied, thanks!
diff mbox series

Patch

diff --git a/drivers/net/ethernet/dec/tulip/de2104x.c b/drivers/net/ethernet/dec/tulip/de2104x.c
index d9f6c19940ef..c3cbe55205a7 100644
--- a/drivers/net/ethernet/dec/tulip/de2104x.c
+++ b/drivers/net/ethernet/dec/tulip/de2104x.c
@@ -2175,11 +2175,21 @@  static int __maybe_unused de_resume(struct device *dev_d)
 
 static SIMPLE_DEV_PM_OPS(de_pm_ops, de_suspend, de_resume);
 
+static void de_shutdown(struct pci_dev *pdev)
+{
+	struct net_device *dev = pci_get_drvdata(pdev);
+
+	rtnl_lock();
+	dev_close(dev);
+	rtnl_unlock();
+}
+
 static struct pci_driver de_driver = {
 	.name		= DRV_NAME,
 	.id_table	= de_pci_tbl,
 	.probe		= de_init_one,
 	.remove		= de_remove_one,
+	.shutdown	= de_shutdown,
 	.driver.pm	= &de_pm_ops,
 };