diff mbox series

[04/30] net: wimax: i2400m: control: Fix some misspellings in i2400m_set_init_config()'s docs

Message ID 20201102114512.1062724-5-lee.jones@linaro.org
State Superseded
Headers show
Series [01/30] net: fddi: skfp: ecm: Protect 'if' when AIX_EVENT is not defined | expand

Commit Message

Lee Jones Nov. 2, 2020, 11:44 a.m. UTC
Fixes the following W=1 kernel build warning(s):

 drivers/net/wimax/i2400m/control.c:1195: warning: Function parameter or member 'arg' not described in 'i2400m_set_init_config'
 drivers/net/wimax/i2400m/control.c:1195: warning: Excess function parameter 'arg_size' description in 'i2400m_set_init_config'

Cc: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>
Cc: linux-wimax@intel.com
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/staging/wimax/i2400m/control.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Lee Jones Nov. 12, 2020, 10:04 a.m. UTC | #1
On Mon, 02 Nov 2020, Lee Jones wrote:

> Fixes the following W=1 kernel build warning(s):

> 

>  drivers/net/wimax/i2400m/control.c:1195: warning: Function parameter or member 'arg' not described in 'i2400m_set_init_config'

>  drivers/net/wimax/i2400m/control.c:1195: warning: Excess function parameter 'arg_size' description in 'i2400m_set_init_config'

> 

> Cc: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>

> Cc: linux-wimax@intel.com

> Cc: "David S. Miller" <davem@davemloft.net>

> Cc: Jakub Kicinski <kuba@kernel.org>

> Cc: netdev@vger.kernel.org

> Signed-off-by: Lee Jones <lee.jones@linaro.org>

> ---

>  drivers/staging/wimax/i2400m/control.c | 4 ++--

>  1 file changed, 2 insertions(+), 2 deletions(-)


Any news on these i2400 patches?

Looks like the driver has been moved to Staging since submission.

Greg, shall I re-submit?

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
Greg KH Nov. 12, 2020, 10:50 a.m. UTC | #2
On Thu, Nov 12, 2020 at 10:04:45AM +0000, Lee Jones wrote:
> On Mon, 02 Nov 2020, Lee Jones wrote:

> 

> > Fixes the following W=1 kernel build warning(s):

> > 

> >  drivers/net/wimax/i2400m/control.c:1195: warning: Function parameter or member 'arg' not described in 'i2400m_set_init_config'

> >  drivers/net/wimax/i2400m/control.c:1195: warning: Excess function parameter 'arg_size' description in 'i2400m_set_init_config'

> > 

> > Cc: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>

> > Cc: linux-wimax@intel.com

> > Cc: "David S. Miller" <davem@davemloft.net>

> > Cc: Jakub Kicinski <kuba@kernel.org>

> > Cc: netdev@vger.kernel.org

> > Signed-off-by: Lee Jones <lee.jones@linaro.org>

> > ---

> >  drivers/staging/wimax/i2400m/control.c | 4 ++--

> >  1 file changed, 2 insertions(+), 2 deletions(-)

> 

> Any news on these i2400 patches?

> 

> Looks like the driver has been moved to Staging since submission.

> 

> Greg, shall I re-submit?


Please do as I don't have any pending from you at all.  And put
"staging:" as a prefix please.

thanks,

greg k-h
diff mbox series

Patch

diff --git a/drivers/staging/wimax/i2400m/control.c b/drivers/staging/wimax/i2400m/control.c
index fe885aa56cf37..1e270b2101e86 100644
--- a/drivers/staging/wimax/i2400m/control.c
+++ b/drivers/staging/wimax/i2400m/control.c
@@ -1183,11 +1183,11 @@  static int i2400m_cmd_get_state(struct i2400m *i2400m)
  * Set basic configuration settings
  *
  * @i2400m: device descriptor
- * @args: array of pointers to the TLV headers to send for
+ * @arg: array of pointers to the TLV headers to send for
  *     configuration (each followed by its payload).
  *     TLV headers and payloads must be properly initialized, with the
  *     right endianess (LE).
- * @arg_size: number of pointers in the @args array
+ * @args: number of pointers in the @arg array
  */
 static int i2400m_set_init_config(struct i2400m *i2400m,
 				  const struct i2400m_tlv_hdr **arg,