diff mbox series

octeontx2-pf: Fix sizeof() mismatch

Message ID 20201102134601.698436-1-colin.king@canonical.com
State New
Headers show
Series octeontx2-pf: Fix sizeof() mismatch | expand

Commit Message

Colin King Nov. 2, 2020, 1:46 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

An incorrect sizeof() is being used, sizeof(u64 *) is not correct,
it should be sizeof(*sq->sqb_ptrs).

Fixes: caa2da34fd25 ("octeontx2-pf: Initialize and config queues")
Addresses-Coverity: ("Sizeof not portable (SIZEOF_MISMATCH)")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jakub Kicinski Nov. 4, 2020, 1:52 a.m. UTC | #1 
On Mon,  2 Nov 2020 13:46:01 +0000 Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>

> 

> An incorrect sizeof() is being used, sizeof(u64 *) is not correct,

> it should be sizeof(*sq->sqb_ptrs).

> 

> Fixes: caa2da34fd25 ("octeontx2-pf: Initialize and config queues")

> Addresses-Coverity: ("Sizeof not portable (SIZEOF_MISMATCH)")

> Signed-off-by: Colin Ian King <colin.king@canonical.com>


Applied, but to net-next. The driver depends on 64BIT so this is
harmless.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
index fc765e86988e..9f3d6715748e 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
@@ -1239,7 +1239,7 @@  int otx2_sq_aura_pool_init(struct otx2_nic *pfvf)
 
 		sq = &qset->sq[qidx];
 		sq->sqb_count = 0;
-		sq->sqb_ptrs = kcalloc(num_sqbs, sizeof(u64 *), GFP_KERNEL);
+		sq->sqb_ptrs = kcalloc(num_sqbs, sizeof(*sq->sqb_ptrs), GFP_KERNEL);
 		if (!sq->sqb_ptrs)
 			return -ENOMEM;