diff mbox series

spi: spi-ti-qspi: fix reference leak in ti_qspi_setup

Message ID 20201103140947.3815-1-zhangqilong3@huawei.com
State Accepted
Commit 45c0cba753641e5d7c3207f04241bd0e7a021698
Headers show
Series spi: spi-ti-qspi: fix reference leak in ti_qspi_setup | expand

Commit Message

Zhang Qilong Nov. 3, 2020, 2:09 p.m. UTC
pm_runtime_get_sync will increment pm usage counter even it
failed. Forgetting to pm_runtime_put_noidle will result in
reference leak in ti_qspi_setup, so we should fix it.

Fixes: 505a14954e2d7 ("spi/qspi: Add qspi flash controller")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
---
 drivers/spi/spi-ti-qspi.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Mark Brown Nov. 9, 2020, 7:48 p.m. UTC | #1
On Tue, 3 Nov 2020 22:09:47 +0800, Zhang Qilong wrote:
> pm_runtime_get_sync will increment pm usage counter even it

> failed. Forgetting to pm_runtime_put_noidle will result in

> reference leak in ti_qspi_setup, so we should fix it.


Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: spi-ti-qspi: fix reference leak in ti_qspi_setup
      commit: 45c0cba753641e5d7c3207f04241bd0e7a021698

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c
index 3c41649698a5..9417385c0921 100644
--- a/drivers/spi/spi-ti-qspi.c
+++ b/drivers/spi/spi-ti-qspi.c
@@ -174,6 +174,7 @@  static int ti_qspi_setup(struct spi_device *spi)
 
 	ret = pm_runtime_get_sync(qspi->dev);
 	if (ret < 0) {
+		pm_runtime_put_noidle(qspi->dev);
 		dev_err(qspi->dev, "pm_runtime_get_sync() failed\n");
 		return ret;
 	}