| Message ID | 20201104105508.21197-1-prabhakar.mahadev-lad.rj@bp.renesas.com |
|---|---|
| State | Accepted |
| Commit | 7de8bfaa095fcbc2db2952d4b561be102a41c2a6 |
| Headers | show |
| Series | arm64: dts: renesas: r8a774e1: Add missing audio_clk_b | expand |
On Wed, Nov 4, 2020 at 11:55 AM Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > Add audio_clk_b configured as 0 Hz, this will be overridden by the > boards providing the audio clock. > > Fixes: 8183a7938cfec ("arm64: dts: renesas: r8a774e1: Add audio support") > Reported-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue in renesas-devel for v5.11. > I have rebased this patch on renesas-arm-dt-for-v5.10 branch. Not renesas-arm-dt-for-v5.11? Anyway, seems to apply cleanly. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, Thank you for the review. > -----Original Message----- > From: Geert Uytterhoeven <geert@linux-m68k.org> > Sent: 09 November 2020 10:02 > To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com> > Cc: Magnus Damm <magnus.damm@gmail.com>; Rob Herring <robh+dt@kernel.org>; Linux-Renesas <linux- > renesas-soc@vger.kernel.org>; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS > <devicetree@vger.kernel.org>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; Biju Das > <biju.das.jz@bp.renesas.com>; Prabhakar <prabhakar.csengg@gmail.com> > Subject: Re: [PATCH] arm64: dts: renesas: r8a774e1: Add missing audio_clk_b > > On Wed, Nov 4, 2020 at 11:55 AM Lad Prabhakar > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > Add audio_clk_b configured as 0 Hz, this will be overridden by the > > boards providing the audio clock. > > > > Fixes: 8183a7938cfec ("arm64: dts: renesas: r8a774e1: Add audio support") > > Reported-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > i.e. will queue in renesas-devel for v5.11. > > > I have rebased this patch on renesas-arm-dt-for-v5.10 branch. > > Not renesas-arm-dt-for-v5.11? > Since this was a fixup, I was hoping this will go into v5.10 as a result I rebased it on renesas-arm-dt-for-v5.10 branch. Cheers, Prabhakar > Anyway, seems to apply cleanly. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
Hi Prabhakar, On Mon, Nov 9, 2020 at 11:05 AM Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > -----Original Message----- > > From: Geert Uytterhoeven <geert@linux-m68k.org> > > Sent: 09 November 2020 10:02 > > To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Cc: Magnus Damm <magnus.damm@gmail.com>; Rob Herring <robh+dt@kernel.org>; Linux-Renesas <linux- > > renesas-soc@vger.kernel.org>; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS > > <devicetree@vger.kernel.org>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; Biju Das > > <biju.das.jz@bp.renesas.com>; Prabhakar <prabhakar.csengg@gmail.com> > > Subject: Re: [PATCH] arm64: dts: renesas: r8a774e1: Add missing audio_clk_b > > > > On Wed, Nov 4, 2020 at 11:55 AM Lad Prabhakar > > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > > Add audio_clk_b configured as 0 Hz, this will be overridden by the > > > boards providing the audio clock. > > > > > > Fixes: 8183a7938cfec ("arm64: dts: renesas: r8a774e1: Add audio support") > > > Reported-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > i.e. will queue in renesas-devel for v5.11. > > > > > I have rebased this patch on renesas-arm-dt-for-v5.10 branch. > > > > Not renesas-arm-dt-for-v5.11? > > > Since this was a fixup, I was hoping this will go into v5.10 as a result I rebased it on renesas-arm-dt-for-v5.10 branch. OK. Will queue in renesas-fixes-for-v5.10 instead. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, > -----Original Message----- > From: Geert Uytterhoeven <geert@linux-m68k.org> > Sent: 09 November 2020 10:10 > To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com> > Cc: Magnus Damm <magnus.damm@gmail.com>; Rob Herring <robh+dt@kernel.org>; Linux-Renesas <linux- > renesas-soc@vger.kernel.org>; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS > <devicetree@vger.kernel.org>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; Biju Das > <biju.das.jz@bp.renesas.com>; Prabhakar <prabhakar.csengg@gmail.com> > Subject: Re: [PATCH] arm64: dts: renesas: r8a774e1: Add missing audio_clk_b > > Hi Prabhakar, > > On Mon, Nov 9, 2020 at 11:05 AM Prabhakar Mahadev Lad > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > > -----Original Message----- > > > From: Geert Uytterhoeven <geert@linux-m68k.org> > > > Sent: 09 November 2020 10:02 > > > To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > Cc: Magnus Damm <magnus.damm@gmail.com>; Rob Herring <robh+dt@kernel.org>; Linux-Renesas <linux- > > > renesas-soc@vger.kernel.org>; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS > > > <devicetree@vger.kernel.org>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; Biju Das > > > <biju.das.jz@bp.renesas.com>; Prabhakar <prabhakar.csengg@gmail.com> > > > Subject: Re: [PATCH] arm64: dts: renesas: r8a774e1: Add missing audio_clk_b > > > > > > On Wed, Nov 4, 2020 at 11:55 AM Lad Prabhakar > > > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > > > Add audio_clk_b configured as 0 Hz, this will be overridden by the > > > > boards providing the audio clock. > > > > > > > > Fixes: 8183a7938cfec ("arm64: dts: renesas: r8a774e1: Add audio support") > > > > Reported-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > i.e. will queue in renesas-devel for v5.11. > > > > > > > I have rebased this patch on renesas-arm-dt-for-v5.10 branch. > > > > > > Not renesas-arm-dt-for-v5.11? > > > > > Since this was a fixup, I was hoping this will go into v5.10 as a result I rebased it on renesas- > arm-dt-for-v5.10 branch. > > OK. Will queue in renesas-fixes-for-v5.10 instead. > Thank you. Cheers, Prabhakar > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
diff --git a/arch/arm64/boot/dts/renesas/r8a774e1.dtsi b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi index 9cbf963aa068..c29643442e91 100644 --- a/arch/arm64/boot/dts/renesas/r8a774e1.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi @@ -28,6 +28,12 @@ clock-frequency = <0>; }; + audio_clk_b: audio_clk_b { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <0>; + }; + audio_clk_c: audio_clk_c { compatible = "fixed-clock"; #clock-cells = <0>;
Add audio_clk_b configured as 0 Hz, this will be overridden by the boards providing the audio clock. Fixes: 8183a7938cfec ("arm64: dts: renesas: r8a774e1: Add audio support") Reported-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> --- Hi Geert, I have rebased this patch on renesas-arm-dt-for-v5.10 branch. Cheers, Prabhakar --- arch/arm64/boot/dts/renesas/r8a774e1.dtsi | 6 ++++++ 1 file changed, 6 insertions(+)