| Message ID | 1401650018-31023-1-git-send-email-broonie@kernel.org |
|---|---|
| State | New |
| Headers | show |
Hi Mark, > From: Mark Brown <broonie@linaro.org> > > Signed-off-by: Mark Brown <broonie@linaro.org> > --- > sound/soc/intel/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig > index cd3498736e91..c30fedb3e149 100644 > --- a/sound/soc/intel/Kconfig > +++ b/sound/soc/intel/Kconfig > @@ -52,7 +52,7 @@ config SND_SOC_INTEL_BYT_RT5640_MACH > > config SND_SOC_INTEL_BYT_MAX98090_MACH > tristate "ASoC Audio driver for Intel Baytrail with MAX98090 codec" > - depends on SND_SOC_INTEL_SST && X86_INTEL_LPSS > + depends on SND_SOC_INTEL_SST && X86_INTEL_LPSS && I2C I think the dependency on I2C is specific to the MAX98090 codec. Can we add this to the codec config entry instead? Thanks, Kevin > select SND_SOC_INTEL_BAYTRAIL > select SND_SOC_MAX98090 > help > -- > 2.0.0.rc4 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >
On Sun, Jun 01, 2014 at 06:30:03PM -0700, kevin.strasser@linux.intel.com wrote: > > tristate "ASoC Audio driver for Intel Baytrail with MAX98090 codec" > > - depends on SND_SOC_INTEL_SST && X86_INTEL_LPSS > > + depends on SND_SOC_INTEL_SST && X86_INTEL_LPSS && I2C > I think the dependency on I2C is specific to the MAX98090 codec. > Can we add this to the codec config entry instead? No, selects ignore dependencies.
diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig index cd3498736e91..c30fedb3e149 100644 --- a/sound/soc/intel/Kconfig +++ b/sound/soc/intel/Kconfig @@ -52,7 +52,7 @@ config SND_SOC_INTEL_BYT_RT5640_MACH config SND_SOC_INTEL_BYT_MAX98090_MACH tristate "ASoC Audio driver for Intel Baytrail with MAX98090 codec" - depends on SND_SOC_INTEL_SST && X86_INTEL_LPSS + depends on SND_SOC_INTEL_SST && X86_INTEL_LPSS && I2C select SND_SOC_INTEL_BAYTRAIL select SND_SOC_MAX98090 help