diff mbox series

[net-next,v3] ne2k: Fix Typo in RW-Bugfix

Message ID 20201029143357.7008-1-W_Armin@gmx.de
State New
Headers show
Series [net-next,v3] ne2k: Fix Typo in RW-Bugfix | expand

Commit Message

Armin Wolf Oct. 29, 2020, 2:33 p.m. UTC 
Correct a typo in ne.c and ne2k-pci.c which
prevented activation of the RW-Bugfix.

Signed-off-by: Armin Wolf <W_Armin@gmx.de>
---
v3 changes:
- do not enable the Bugfix by default
- change patch name

The reason for activating the Bugfix by default
was that a RealTek 8029AS nic caused symptoms
described in the original 8390 Datasheet as
beeing caused by the Read/Write-Bug, such as
sudden crashs, when the nic was in use.
But after further investigation, it seems that
the PSU is to blame for those problems, so there
is indeed no reason for activating the Bugfix by
default. Sorry for not noticing this sooner.
Nonetheless the discovered typos should be fixed,
since they prevent correct activation of the Bugfix
in both ne and ne2k-pci (even if noone seems to use
the Bugfix).

v2 changes:
- change NE8390_RW_BUGFIX to NE_RW_BUGFIX
---
 drivers/net/ethernet/8390/ne.c       | 2 +-
 drivers/net/ethernet/8390/ne2k-pci.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

--
2.20.1

Comments

Jakub Kicinski Oct. 31, 2020, 11:18 p.m. UTC | #1 
On Thu, 29 Oct 2020 15:33:57 +0100 Armin Wolf wrote:
> Correct a typo in ne.c and ne2k-pci.c which

> prevented activation of the RW-Bugfix.

> 

> Signed-off-by: Armin Wolf <W_Armin@gmx.de>


Applied.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/8390/ne.c b/drivers/net/ethernet/8390/ne.c
index 1c97e39b478e..e9756d0ea5b8 100644
--- a/drivers/net/ethernet/8390/ne.c
+++ b/drivers/net/ethernet/8390/ne.c
@@ -710,7 +710,7 @@  static void ne_block_output(struct net_device *dev, int count,
 retry:
 #endif

-#ifdef NE8390_RW_BUGFIX
+#ifdef NE_RW_BUGFIX
 	/* Handle the read-before-write bug the same way as the
 	   Crynwr packet driver -- the NatSemi method doesn't work.
 	   Actually this doesn't always work either, but if you have
diff --git a/drivers/net/ethernet/8390/ne2k-pci.c b/drivers/net/ethernet/8390/ne2k-pci.c
index bc6edb3f1af3..d6715008e04d 100644
--- a/drivers/net/ethernet/8390/ne2k-pci.c
+++ b/drivers/net/ethernet/8390/ne2k-pci.c
@@ -610,7 +610,7 @@  static void ne2k_pci_block_output(struct net_device *dev, int count,
 	/* We should already be in page 0, but to be safe... */
 	outb(E8390_PAGE0+E8390_START+E8390_NODMA, nic_base + NE_CMD);

-#ifdef NE8390_RW_BUGFIX
+#ifdef NE_RW_BUGFIX
 	/* Handle the read-before-write bug the same way as the
 	 * Crynwr packet driver -- the NatSemi method doesn't work.
 	 * Actually this doesn't always work either, but if you have