[4.9,14/78] drm/radeon: fix multiple reference count leak

Message ID	20200901150925.450882452@linuxfoundation.org
State	New
Headers	show Return-Path: <SRS0=oSvm=CK=vger.kernel.org=stable-owner@kernel.org> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, stable@vger.kernel.org, Aditya Pakki <pakki001@umn.edu>, Alex Deucher <alexander.deucher@amd.com>, Sasha Levin <sashal@kernel.org> Subject: [PATCH 4.9 14/78] drm/radeon: fix multiple reference count leak Date: Tue, 1 Sep 2020 17:09:50 +0200 Message-Id: <20200901150925.450882452@linuxfoundation.org> In-Reply-To: <20200901150924.680106554@linuxfoundation.org> References: <20200901150924.680106554@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk
Series	None \| expand [4.9,02/78] bonding: show saner speed for broadcast mode [4.9,03/78] net: Fix potential wrong skb->protocol in skb_vlan_untag() [4.9,04/78] tipc: fix uninit skb->data in tipc_nl_compat_dumpit() [4.9,05/78] ipvlan: fix device features [4.9,06/78] gre6: Fix reception with IP6_TNL_F_RCV_DSCP_COPY [4.9,07/78] ALSA: pci: delete repeated words in comments [4.9,08/78] ASoC: tegra: Fix reference count leaks. [4.9,09/78] arm64: dts: qcom: msm8916: Pull down PDM GPIOs during sleep [4.9,10/78] media: pci: ttpci: av7110: fix possible buffer overflow caused by bad DMA value in de... [4.9,11/78] scsi: target: tcmu: Fix crash on ARM during cmd completion [4.9,12/78] iommu/iova: Dont BUG on invalid PFNs [4.9,13/78] drm/amdkfd: Fix reference count leaks. [4.9,14/78] drm/radeon: fix multiple reference count leak [4.9,15/78] drm/amdgpu: fix ref count leak in amdgpu_driver_open_kms [4.9,16/78] drm/amd/display: fix ref count leak in amdgpu_drm_ioctl [4.9,17/78] drm/amdgpu: fix ref count leak in amdgpu_display_crtc_set_config [4.9,18/78] drm/amdgpu/display: fix ref count leak when pm_runtime_get_sync fails [4.9,19/78] scsi: lpfc: Fix shost refcount mismatch when deleting vport [4.9,20/78] selftests/powerpc: Purge extra count_pmc() calls of ebb selftests [4.9,21/78] omapfb: fix multiple reference count leaks due to pm_runtime_get_sync [4.9,22/78] PCI: Fix pci_create_slot() reference count leak [4.9,23/78] rtlwifi: rtl8192cu: Prevent leaking urb [4.9,24/78] mips/vdso: Fix resource leaks in genvdso.c [4.9,25/78] cec-api: prevent leaking memory through hole in structure [4.9,26/78] drm/nouveau/drm/noveau: fix reference count leak in nouveau_fbcon_open [4.9,27/78] drm/nouveau: Fix reference count leak in nouveau_connector_detect [4.9,28/78] locking/lockdep: Fix overflow in presentation of average lock-time [4.9,29/78] scsi: iscsi: Do not put host in iscsi_set_flashnode_param() [4.9,30/78] ceph: fix potential mdsc use-after-free crash [4.9,31/78] scsi: fcoe: Memory leak fix in fcoe_sysfs_fcf_del() [4.9,32/78] EDAC/ie31200: Fallback if host bridge device is already initialized [4.9,33/78] media: davinci: vpif_capture: fix potential double free [4.9,34/78] KVM: arm64: Fix symbol dependency in __hyp_call_panic_nvhe [4.9,35/78] powerpc/spufs: add CONFIG_COREDUMP dependency [4.9,36/78] USB: sisusbvga: Fix a potential UB casued by left shifting a negative value [4.9,37/78] efi: provide empty efi_enter_virtual_mode implementation [4.9,38/78] Revert "ath10k: fix DMA related firmware crashes on multiple devices" [4.9,39/78] i2c: rcar: in slave mode, clear NACK earlier [4.9,40/78] usb: gadget: f_tcm: Fix some resource leaks in some error paths [4.9,41/78] jbd2: make sure jh have b_transaction set in refile/unfile_buffer [4.9,42/78] jbd2: abort journal if free a async write error metadata buffer [4.9,43/78] fs: prevent BUG_ON in submit_bh_wbc() [4.9,44/78] s390/cio: add cond_resched() in the slow_eval_known_fn() loop [4.9,45/78] scsi: ufs: Fix possible infinite loop in ufshcd_hold [4.9,46/78] scsi: ufs: Improve interrupt handling for shared interrupts [4.9,47/78] net: gianfar: Add of_node_put() before goto statement [4.9,48/78] powerpc/perf: Fix soft lockups due to missed interrupt accounting [4.9,49/78] HID: i2c-hid: Always sleep 60ms after I2C_HID_PWR_ON commands [4.9,50/78] btrfs: fix space cache memory leak after transaction abort [4.9,51/78] fbcon: prevent user font height or width change from causing potential out-of-bounds ... [4.9,52/78] USB: lvtest: return proper error code in probe [4.9,53/78] vt: defer kfree() of vc_screenbuf in vc_do_resize() [4.9,54/78] vt_ioctl: change VT_RESIZEX ioctl to check for error return from vc_resize() [4.9,55/78] serial: samsung: Removes the IRQ not found warning [4.9,56/78] serial: pl011: Fix oops on -EPROBE_DEFER [4.9,57/78] serial: pl011: Dont leak amba_ports entry on driver register error [4.9,58/78] serial: 8250: change lock order in serial8250_do_startup() [4.9,59/78] writeback: Protect inode->i_io_list with inode->i_lock [4.9,60/78] writeback: Avoid skipping inode writeback [4.9,61/78] writeback: Fix sync livelock due to b_dirty_time processing [4.9,62/78] XEN uses irqdesc::irq_data_common::handler_data to store a per interrupt XEN data poi... [4.9,63/78] xhci: Do warm-reset when both CAS and XDEV_RESUME are set [4.9,64/78] PM: sleep: core: Fix the handling of pending runtime resume requests [4.9,65/78] device property: Fix the secondary firmware node handling in set_primary_fwnode() [4.9,66/78] USB: yurex: Fix bad gfp argument [4.9,67/78] usb: uas: Add quirk for PNY Pro Elite [4.9,68/78] USB: quirks: Add no-lpm quirk for another Raydium touchscreen [4.9,69/78] USB: Ignore UAS for JMicron JMS567 ATA/ATAPI Bridge [4.9,70/78] usb: host: ohci-exynos: Fix error handling in exynos_ohci_probe() [4.9,71/78] overflow.h: Add allocation size calculation helpers [4.9,72/78] USB: gadget: u_f: add overflow checks to VLA macros [4.9,73/78] USB: gadget: f_ncm: add bounds checks to ncm_unwrap_ntb() [4.9,74/78] USB: gadget: u_f: Unbreak offset calculation in VLAs [4.9,75/78] usb: storage: Add unusual_uas entry for Sony PSZ drives [4.9,76/78] btrfs: check the right error variable in btrfs_del_dir_entries_in_log [4.9,77/78] HID: hiddev: Fix slab-out-of-bounds write in hiddev_ioctl_usage() [4.9,78/78] ALSA: usb-audio: Update documentation comment for MS2109 quirk

Message ID

20200901150925.450882452@linuxfoundation.org

State

New

Headers

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	stable@vger.kernel.org, Aditya Pakki <pakki001@umn.edu>,
	Alex Deucher <alexander.deucher@amd.com>, Sasha Levin <sashal@kernel.org>
Subject: [PATCH 4.9 14/78] drm/radeon: fix multiple reference count leak
Date: Tue,  1 Sep 2020 17:09:50 +0200
Message-Id: <20200901150925.450882452@linuxfoundation.org>
In-Reply-To: <20200901150924.680106554@linuxfoundation.org>
References: <20200901150924.680106554@linuxfoundation.org>
User-Agent: quilt/0.66
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: stable-owner@vger.kernel.org
Precedence: bulk

Series

None | expand

Commit Message

Greg KH Sept. 1, 2020, 3:09 p.m. UTC

From: Aditya Pakki <pakki001@umn.edu>

[ Upstream commit 6f2e8acdb48ed166b65d47837c31b177460491ec ]

On calling pm_runtime_get_sync() the reference count of the device
is incremented. In case of failure, decrement the
reference count before returning the error.

Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/gpu/drm/radeon/radeon_connectors.c | 20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/radeon/radeon_connectors.c
index efa875120071a..9e6c2be0cc7d4 100644
--- a/drivers/gpu/drm/radeon/radeon_connectors.c
+++ b/drivers/gpu/drm/radeon/radeon_connectors.c
@@ -892,8 +892,10 @@  radeon_lvds_detect(struct drm_connector *connector, bool force)
 
 	if (!drm_kms_helper_is_poll_worker()) {
 		r = pm_runtime_get_sync(connector->dev->dev);
-		if (r < 0)
+		if (r < 0) {
+			pm_runtime_put_autosuspend(connector->dev->dev);
 			return connector_status_disconnected;
+		}
 	}
 
 	if (encoder) {
@@ -1038,8 +1040,10 @@  radeon_vga_detect(struct drm_connector *connector, bool force)
 
 	if (!drm_kms_helper_is_poll_worker()) {
 		r = pm_runtime_get_sync(connector->dev->dev);
-		if (r < 0)
+		if (r < 0) {
+			pm_runtime_put_autosuspend(connector->dev->dev);
 			return connector_status_disconnected;
+		}
 	}
 
 	encoder = radeon_best_single_encoder(connector);
@@ -1176,8 +1180,10 @@  radeon_tv_detect(struct drm_connector *connector, bool force)
 
 	if (!drm_kms_helper_is_poll_worker()) {
 		r = pm_runtime_get_sync(connector->dev->dev);
-		if (r < 0)
+		if (r < 0) {
+			pm_runtime_put_autosuspend(connector->dev->dev);
 			return connector_status_disconnected;
+		}
 	}
 
 	encoder = radeon_best_single_encoder(connector);
@@ -1260,8 +1266,10 @@  radeon_dvi_detect(struct drm_connector *connector, bool force)
 
 	if (!drm_kms_helper_is_poll_worker()) {
 		r = pm_runtime_get_sync(connector->dev->dev);
-		if (r < 0)
+		if (r < 0) {
+			pm_runtime_put_autosuspend(connector->dev->dev);
 			return connector_status_disconnected;
+		}
 	}
 
 	if (radeon_connector->detected_hpd_without_ddc) {
@@ -1701,8 +1709,10 @@  radeon_dp_detect(struct drm_connector *connector, bool force)
 
 	if (!drm_kms_helper_is_poll_worker()) {
 		r = pm_runtime_get_sync(connector->dev->dev);
-		if (r < 0)
+		if (r < 0) {
+			pm_runtime_put_autosuspend(connector->dev->dev);
 			return connector_status_disconnected;
+		}
 	}
 
 	if (!force && radeon_check_hpd_status_unchanged(connector)) {

[4.9,14/78] drm/radeon: fix multiple reference count leak

Commit Message

Patch