diff mbox series

[v2,2/2] hw/ppc/ppc4xx_pci: Replace magic value by the PCI_NUM_PINS definition

Message ID 20200910072325.439344-3-f4bug@amsat.org
State New
Headers show
Series hw: Replace some impossible checks by assertions | expand

Commit Message

Philippe Mathieu-Daudé Sept. 10, 2020, 7:23 a.m. UTC 
Replace the magic '4' value by the PCI_NUM_PINS definition.

Suggested-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 hw/ppc/ppc4xx_pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Laurent Vivier Sept. 16, 2020, 8:45 a.m. UTC | #1 
Le 10/09/2020 à 09:23, Philippe Mathieu-Daudé a écrit :
> Replace the magic '4' value by the PCI_NUM_PINS definition.

> 

> Suggested-by: Cédric Le Goater <clg@kaod.org>

> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---

>  hw/ppc/ppc4xx_pci.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/hw/ppc/ppc4xx_pci.c b/hw/ppc/ppc4xx_pci.c

> index 503ef46b39a..930be78361d 100644

> --- a/hw/ppc/ppc4xx_pci.c

> +++ b/hw/ppc/ppc4xx_pci.c

> @@ -54,7 +54,7 @@ struct PPC4xxPCIState {

>  

>      struct PCIMasterMap pmm[PPC4xx_PCI_NR_PMMS];

>      struct PCITargetMap ptm[PPC4xx_PCI_NR_PTMS];

> -    qemu_irq irq[4];

> +    qemu_irq irq[PCI_NUM_PINS];

>  

>      MemoryRegion container;

>      MemoryRegion iomem;

> 


Applied to my trivial-patches branch.

Thanks,
Laurent
diff mbox series

Patch

diff --git a/hw/ppc/ppc4xx_pci.c b/hw/ppc/ppc4xx_pci.c
index 503ef46b39a..930be78361d 100644
--- a/hw/ppc/ppc4xx_pci.c
+++ b/hw/ppc/ppc4xx_pci.c
@@ -54,7 +54,7 @@  struct PPC4xxPCIState {
 
     struct PCIMasterMap pmm[PPC4xx_PCI_NR_PMMS];
     struct PCITargetMap ptm[PPC4xx_PCI_NR_PTMS];
-    qemu_irq irq[4];
+    qemu_irq irq[PCI_NUM_PINS];
 
     MemoryRegion container;
     MemoryRegion iomem;