| Message ID | 20200918143355.153522-1-f4bug@amsat.org |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] tests/acceptance: Skip slow quanta-gsj U-boot+Linux test | expand |
Patchew URL: https://patchew.org/QEMU/20200918143355.153522-1-f4bug@amsat.org/ Hi, This series seems to have some coding style problems. See output below for more information: N/A. Internal error while reading log file The full log is available at http://patchew.org/logs/20200918143355.153522-1-f4bug@amsat.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On Fri, Sep 18, 2020 at 11:35 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: > > The 'arm_quanta_gsj_initrd' test is timeouting on GitLab CI: > https://gitlab.com/philmd/qemu/-/jobs/745483978#L846 > and also sometimes on my workstation, so proceed as with > the other slow tests: do not run it by default. > The test can still be run setting the AVOCADO_TIMEOUT_EXPECTED > environment variable. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > Supersedes: <20200918142344.150749-1-f4bug@amsat.org> > --- > tests/acceptance/boot_linux_console.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py > index 4a366ce93e4..9b58f6f9003 100644 > --- a/tests/acceptance/boot_linux_console.py > +++ b/tests/acceptance/boot_linux_console.py > @@ -568,6 +568,7 @@ def test_arm_cubieboard_sata(self): > 'sda') > # cubieboard's reboot is not functioning; omit reboot test. > > + @skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout') > def test_arm_quanta_gsj(self): > """ > :avocado: tags=arch:arm > -- > 2.26.2 > > At least, this time, skipUnless is already there :D Reviewed-by: Willian Rampazzo <willianr@redhat.com>
On Fri, Sep 18, 2020 at 7:33 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: > > The 'arm_quanta_gsj_initrd' test is timeouting on GitLab CI: > https://gitlab.com/philmd/qemu/-/jobs/745483978#L846 > and also sometimes on my workstation, so proceed as with > the other slow tests: do not run it by default. > The test can still be run setting the AVOCADO_TIMEOUT_EXPECTED > environment variable. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Reviewed-by: Havard Skinnemoen <hskinnemoen@google.com> Tested-by: Havard Skinnemoen <hskinnemoen@google.com> Thanks! > --- > Supersedes: <20200918142344.150749-1-f4bug@amsat.org> > --- > tests/acceptance/boot_linux_console.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py > index 4a366ce93e4..9b58f6f9003 100644 > --- a/tests/acceptance/boot_linux_console.py > +++ b/tests/acceptance/boot_linux_console.py > @@ -568,6 +568,7 @@ def test_arm_cubieboard_sata(self): > 'sda') > # cubieboard's reboot is not functioning; omit reboot test. > > + @skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout') > def test_arm_quanta_gsj(self): > """ > :avocado: tags=arch:arm > -- > 2.26.2 >
On 9/18/20 4:33 PM, Philippe Mathieu-Daudé wrote: > The 'arm_quanta_gsj_initrd' test is timeouting on GitLab CI: > https://gitlab.com/philmd/qemu/-/jobs/745483978#L846 > and also sometimes on my workstation, so proceed as with > the other slow tests: do not run it by default. > The test can still be run setting the AVOCADO_TIMEOUT_EXPECTED > environment variable. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > Supersedes: <20200918142344.150749-1-f4bug@amsat.org> > --- > tests/acceptance/boot_linux_console.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py > index 4a366ce93e4..9b58f6f9003 100644 > --- a/tests/acceptance/boot_linux_console.py > +++ b/tests/acceptance/boot_linux_console.py > @@ -568,6 +568,7 @@ def test_arm_cubieboard_sata(self): > 'sda') > # cubieboard's reboot is not functioning; omit reboot test. > > + @skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout') > def test_arm_quanta_gsj(self): > """ > :avocado: tags=arch:arm > Thanks, applied to my acceptance-testing tree.
diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py index 4a366ce93e4..9b58f6f9003 100644 --- a/tests/acceptance/boot_linux_console.py +++ b/tests/acceptance/boot_linux_console.py @@ -568,6 +568,7 @@ def test_arm_cubieboard_sata(self): 'sda') # cubieboard's reboot is not functioning; omit reboot test. + @skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout') def test_arm_quanta_gsj(self): """ :avocado: tags=arch:arm
The 'arm_quanta_gsj_initrd' test is timeouting on GitLab CI: https://gitlab.com/philmd/qemu/-/jobs/745483978#L846 and also sometimes on my workstation, so proceed as with the other slow tests: do not run it by default. The test can still be run setting the AVOCADO_TIMEOUT_EXPECTED environment variable. Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- Supersedes: <20200918142344.150749-1-f4bug@amsat.org> --- tests/acceptance/boot_linux_console.py | 1 + 1 file changed, 1 insertion(+)