diff mbox series

[4/4] tests/qtest: Replace magic value by NANOSECONDS_PER_SECOND definition

Message ID 20201011194918.3219195-5-f4bug@amsat.org
State New
Headers show
Series hw: Replace some magic by definitions | expand

Commit Message

Philippe Mathieu-Daudé Oct. 11, 2020, 7:49 p.m. UTC 
Use self-explicit NANOSECONDS_PER_SECOND definition instead
of a magic value.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 tests/qtest/rtc-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Huth Oct. 12, 2020, 6:58 a.m. UTC | #1 
On 11/10/2020 21.49, Philippe Mathieu-Daudé wrote:
> Use self-explicit NANOSECONDS_PER_SECOND definition instead

> of a magic value.

> 

> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---

>  tests/qtest/rtc-test.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/tests/qtest/rtc-test.c b/tests/qtest/rtc-test.c

> index c7af34f6b1b..402ce2c6090 100644

> --- a/tests/qtest/rtc-test.c

> +++ b/tests/qtest/rtc-test.c

> @@ -292,7 +292,7 @@ static void alarm_time(void)

>              break;

>          }

>  

> -        clock_step(1000000000);

> +        clock_step(NANOSECONDS_PER_SECOND);

>      }

>  

>      g_assert(get_irq(RTC_ISA_IRQ));

> 


Reviewed-by: Thomas Huth <thuth@redhat.com>
diff mbox series

Patch

diff --git a/tests/qtest/rtc-test.c b/tests/qtest/rtc-test.c
index c7af34f6b1b..402ce2c6090 100644
--- a/tests/qtest/rtc-test.c
+++ b/tests/qtest/rtc-test.c
@@ -292,7 +292,7 @@  static void alarm_time(void)
             break;
         }
 
-        clock_step(1000000000);
+        clock_step(NANOSECONDS_PER_SECOND);
     }
 
     g_assert(get_irq(RTC_ISA_IRQ));