| Message ID | 20201012225831.72920-1-kherman@inbox.lv |
|---|---|
| State | New |
| Headers | show |
| Series | hw/core/qdev-properties: Fix pci bus range in set_pci_host_devaddr() | expand |
Patchew URL: https://patchew.org/QEMU/20201012225831.72920-1-kherman@inbox.lv/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201012225831.72920-1-kherman@inbox.lv Subject: [PATCH] hw/core/qdev-properties: Fix pci bus range in set_pci_host_devaddr() === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20201012124506.3406909-1-philmd@redhat.com -> patchew/20201012124506.3406909-1-philmd@redhat.com * [new tag] patchew/20201012225831.72920-1-kherman@inbox.lv -> patchew/20201012225831.72920-1-kherman@inbox.lv Switched to a new branch 'test' 2b88f0c hw/core/qdev-properties: Fix pci bus range in set_pci_host_devaddr() === OUTPUT BEGIN === ERROR: Missing Signed-off-by: line(s) total: 1 errors, 0 warnings, 8 lines checked Commit 2b88f0c41c07 (hw/core/qdev-properties: Fix pci bus range in set_pci_host_devaddr()) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20201012225831.72920-1-kherman@inbox.lv/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Hi Klaus,
On 10/13/20 12:58 AM, Klaus Herman wrote:
Please include:
Fixes: bccb20c49df ("hw/core/qdev-properties: Use qemu_strtoul() in
set_pci_host_devaddr()")
You forgot to sign your patch, see:
https://wiki.qemu.org/Contribute/SubmitAPatch#Patch_emails_must_include_a_Signed-off-by:_line
> ---
> hw/core/qdev-properties-system.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-system.c
> index 49bdd12..e3dca56 100644
> --- a/hw/core/qdev-properties-system.c
> +++ b/hw/core/qdev-properties-system.c
> @@ -903,7 +903,7 @@ static void set_pci_host_devaddr(Object *obj, Visitor *v, const char *name,
> bus = val;
>
> p = (char *)e + 1;
> - if (qemu_strtoul(p, &e, 16, &val) < 0 || val > 0x1f || e == p) {
> + if (qemu_strtoul(p, &e, 16, &val) < 0 || val > 0xff || e == p) {
> goto inval;
> }
> if (*e == ':') {
>
diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-system.c index 49bdd12..e3dca56 100644 --- a/hw/core/qdev-properties-system.c +++ b/hw/core/qdev-properties-system.c @@ -903,7 +903,7 @@ static void set_pci_host_devaddr(Object *obj, Visitor *v, const char *name, bus = val; p = (char *)e + 1; - if (qemu_strtoul(p, &e, 16, &val) < 0 || val > 0x1f || e == p) { + if (qemu_strtoul(p, &e, 16, &val) < 0 || val > 0xff || e == p) { goto inval; } if (*e == ':') {