| Message ID | 20201020094043.159935-1-stefanha@redhat.com |
|---|---|
| State | Accepted |
| Commit | 35e28cb0f210cae3d9c98113d519fe5a4bef5866 |
| Headers | show |
| Series | scripts/tracetool: silence SystemTap dtrace(1) long long warnings | expand |
On Tue, Oct 20, 2020 at 10:40:43AM +0100, Stefan Hajnoczi wrote: > SystemTap's dtrace(1) prints the following warning when it encounters > long long arguments: > > Warning: /usr/bin/dtrace:trace/trace-dtrace-hw_virtio.dtrace:76: syntax error near: > probe vhost_vdpa_dev_start > > Warning: Proceeding as if --no-pyparsing was given. > > Use the uint64_t and int64_t types, respectively. This works with all > host CPU 32- and 64-bit data models (ILP32, LP64, and LLP64) that QEMU > supports. > > Reported-by: Markus Armbruster <armbru@redhat.com> > Suggested-by: Daniel P. Berrangé <berrange@redhat.com> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> > --- > scripts/tracetool/format/d.py | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/scripts/tracetool/format/d.py b/scripts/tracetool/format/d.py > index 353722f89c..ebfb714200 100644 > --- a/scripts/tracetool/format/d.py > +++ b/scripts/tracetool/format/d.py > @@ -57,6 +57,12 @@ def generate(events, backend, group): > # Avoid it by changing probe type to signed char * beforehand. > if type_ == 'int8_t *': > type_ = 'signed char *' > + > + # SystemTap dtrace(1) emits a warning when long long is used > + type_ = type_.replace('unsigned long long', 'uint64_t') > + type_ = type_.replace('signed long long', 'int64_t') > + type_ = type_.replace('long long', 'int64_t') > + > if name in RESERVED_WORDS: > name += '_' > args.append(type_ + ' ' + name) Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
On 10/20/20 11:40 AM, Stefan Hajnoczi wrote: > SystemTap's dtrace(1) prints the following warning when it encounters > long long arguments: > > Warning: /usr/bin/dtrace:trace/trace-dtrace-hw_virtio.dtrace:76: syntax error near: > probe vhost_vdpa_dev_start > > Warning: Proceeding as if --no-pyparsing was given. > > Use the uint64_t and int64_t types, respectively. This works with all > host CPU 32- and 64-bit data models (ILP32, LP64, and LLP64) that QEMU > supports. > > Reported-by: Markus Armbruster <armbru@redhat.com> > Suggested-by: Daniel P. Berrangé <berrange@redhat.com> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> > --- > scripts/tracetool/format/d.py | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/scripts/tracetool/format/d.py b/scripts/tracetool/format/d.py > index 353722f89c..ebfb714200 100644 > --- a/scripts/tracetool/format/d.py > +++ b/scripts/tracetool/format/d.py > @@ -57,6 +57,12 @@ def generate(events, backend, group): > # Avoid it by changing probe type to signed char * beforehand. > if type_ == 'int8_t *': > type_ = 'signed char *' > + > + # SystemTap dtrace(1) emits a warning when long long is used > + type_ = type_.replace('unsigned long long', 'uint64_t') > + type_ = type_.replace('signed long long', 'int64_t') > + type_ = type_.replace('long long', 'int64_t') > + > if name in RESERVED_WORDS: > name += '_' > args.append(type_ + ' ' + name) > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
On Tue, Oct 20, 2020 at 10:40:43AM +0100, Stefan Hajnoczi wrote: > SystemTap's dtrace(1) prints the following warning when it encounters > long long arguments: > > Warning: /usr/bin/dtrace:trace/trace-dtrace-hw_virtio.dtrace:76: syntax error near: > probe vhost_vdpa_dev_start > > Warning: Proceeding as if --no-pyparsing was given. > > Use the uint64_t and int64_t types, respectively. This works with all > host CPU 32- and 64-bit data models (ILP32, LP64, and LLP64) that QEMU > supports. > > Reported-by: Markus Armbruster <armbru@redhat.com> > Suggested-by: Daniel P. Berrangé <berrange@redhat.com> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> > --- > scripts/tracetool/format/d.py | 6 ++++++ > 1 file changed, 6 insertions(+) Thanks, applied to my tracing tree: https://gitlab.com/stefanha/qemu/commits/tracing Stefan
diff --git a/scripts/tracetool/format/d.py b/scripts/tracetool/format/d.py index 353722f89c..ebfb714200 100644 --- a/scripts/tracetool/format/d.py +++ b/scripts/tracetool/format/d.py @@ -57,6 +57,12 @@ def generate(events, backend, group): # Avoid it by changing probe type to signed char * beforehand. if type_ == 'int8_t *': type_ = 'signed char *' + + # SystemTap dtrace(1) emits a warning when long long is used + type_ = type_.replace('unsigned long long', 'uint64_t') + type_ = type_.replace('signed long long', 'int64_t') + type_ = type_.replace('long long', 'int64_t') + if name in RESERVED_WORDS: name += '_' args.append(type_ + ' ' + name)
SystemTap's dtrace(1) prints the following warning when it encounters long long arguments: Warning: /usr/bin/dtrace:trace/trace-dtrace-hw_virtio.dtrace:76: syntax error near: probe vhost_vdpa_dev_start Warning: Proceeding as if --no-pyparsing was given. Use the uint64_t and int64_t types, respectively. This works with all host CPU 32- and 64-bit data models (ILP32, LP64, and LLP64) that QEMU supports. Reported-by: Markus Armbruster <armbru@redhat.com> Suggested-by: Daniel P. Berrangé <berrange@redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> --- scripts/tracetool/format/d.py | 6 ++++++ 1 file changed, 6 insertions(+)