diff mbox series

hw/arm/highbank: Silence warnings about missing fallthrough statements

Message ID 20201020105938.23209-1-thuth@redhat.com
State Superseded
Headers show
Series hw/arm/highbank: Silence warnings about missing fallthrough statements | expand

Commit Message

Thomas Huth Oct. 20, 2020, 10:59 a.m. UTC
When compiling with -Werror=implicit-fallthrough, gcc complains about
missing fallthrough annotations in this file. Looking at the code,
the fallthrough is very likely intended here, so add some comments
to silence the compiler warnings.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 hw/arm/highbank.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Peter Maydell Oct. 26, 2020, 11:38 a.m. UTC | #1
On Tue, 20 Oct 2020 at 11:59, Thomas Huth <thuth@redhat.com> wrote:
>

> When compiling with -Werror=implicit-fallthrough, gcc complains about

> missing fallthrough annotations in this file. Looking at the code,

> the fallthrough is very likely intended here, so add some comments

> to silence the compiler warnings.

>

> Signed-off-by: Thomas Huth <thuth@redhat.com>

> ---

>  hw/arm/highbank.c | 2 ++

>  1 file changed, 2 insertions(+)



Applied to target-arm.next, thanks.

-- PMM
diff mbox series

Patch

diff --git a/hw/arm/highbank.c b/hw/arm/highbank.c
index da0510d7ce..f71087860d 100644
--- a/hw/arm/highbank.c
+++ b/hw/arm/highbank.c
@@ -92,10 +92,12 @@  static void hb_reset_secondary(ARMCPU *cpu, const struct arm_boot_info *info)
         address_space_stl_notdirty(&address_space_memory,
                                    SMP_BOOT_REG + 0x30, 0,
                                    MEMTXATTRS_UNSPECIFIED, NULL);
+        /* fallthrough */
     case 3:
         address_space_stl_notdirty(&address_space_memory,
                                    SMP_BOOT_REG + 0x20, 0,
                                    MEMTXATTRS_UNSPECIFIED, NULL);
+        /* fallthrough */
     case 2:
         address_space_stl_notdirty(&address_space_memory,
                                    SMP_BOOT_REG + 0x10, 0,