| Message ID | 20201027081558.29904-1-zhangjiachen.jaycee@bytedance.com |
|---|---|
| State | Accepted |
| Commit | 0429eaf518be1d4742356056e6c886b7f9bc9712 |
| Headers | show |
| Series | virtiofsd: Fix the help message of posix lock | expand |
On 10/27/20 9:15 AM, Jiachen Zhang wrote: > The commit 88fc107956a5812649e5918e0c092d3f78bb28ad disabled remote > posix locks by default. But the --help message still says it is enabled > by default. So fix it to output no_posix_lock. > > Signed-off-by: Jiachen Zhang <zhangjiachen.jaycee@bytedance.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > tools/virtiofsd/helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/virtiofsd/helper.c b/tools/virtiofsd/helper.c > index 85770d63f1..574dd09e91 100644 > --- a/tools/virtiofsd/helper.c > +++ b/tools/virtiofsd/helper.c > @@ -161,7 +161,7 @@ void fuse_cmdline_help(void) > " allowed (default: 10)\n" > " -o posix_lock|no_posix_lock\n" > " enable/disable remote posix lock\n" > - " default: posix_lock\n" > + " default: no_posix_lock\n" > " -o readdirplus|no_readdirplus\n" > " enable/disable readirplus\n" > " default: readdirplus except with " >
* Jiachen Zhang (zhangjiachen.jaycee@bytedance.com) wrote: > The commit 88fc107956a5812649e5918e0c092d3f78bb28ad disabled remote > posix locks by default. But the --help message still says it is enabled > by default. So fix it to output no_posix_lock. > > Signed-off-by: Jiachen Zhang <zhangjiachen.jaycee@bytedance.com> Thanks! Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > --- > tools/virtiofsd/helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/virtiofsd/helper.c b/tools/virtiofsd/helper.c > index 85770d63f1..574dd09e91 100644 > --- a/tools/virtiofsd/helper.c > +++ b/tools/virtiofsd/helper.c > @@ -161,7 +161,7 @@ void fuse_cmdline_help(void) > " allowed (default: 10)\n" > " -o posix_lock|no_posix_lock\n" > " enable/disable remote posix lock\n" > - " default: posix_lock\n" > + " default: no_posix_lock\n" > " -o readdirplus|no_readdirplus\n" > " enable/disable readirplus\n" > " default: readdirplus except with " > -- > 2.20.1 >
* Jiachen Zhang (zhangjiachen.jaycee@bytedance.com) wrote: > The commit 88fc107956a5812649e5918e0c092d3f78bb28ad disabled remote > posix locks by default. But the --help message still says it is enabled > by default. So fix it to output no_posix_lock. > > Signed-off-by: Jiachen Zhang <zhangjiachen.jaycee@bytedance.com> Thanks, Queued > --- > tools/virtiofsd/helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/virtiofsd/helper.c b/tools/virtiofsd/helper.c > index 85770d63f1..574dd09e91 100644 > --- a/tools/virtiofsd/helper.c > +++ b/tools/virtiofsd/helper.c > @@ -161,7 +161,7 @@ void fuse_cmdline_help(void) > " allowed (default: 10)\n" > " -o posix_lock|no_posix_lock\n" > " enable/disable remote posix lock\n" > - " default: posix_lock\n" > + " default: no_posix_lock\n" > " -o readdirplus|no_readdirplus\n" > " enable/disable readirplus\n" > " default: readdirplus except with " > -- > 2.20.1 > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
diff --git a/tools/virtiofsd/helper.c b/tools/virtiofsd/helper.c index 85770d63f1..574dd09e91 100644 --- a/tools/virtiofsd/helper.c +++ b/tools/virtiofsd/helper.c @@ -161,7 +161,7 @@ void fuse_cmdline_help(void) " allowed (default: 10)\n" " -o posix_lock|no_posix_lock\n" " enable/disable remote posix lock\n" - " default: posix_lock\n" + " default: no_posix_lock\n" " -o readdirplus|no_readdirplus\n" " enable/disable readirplus\n" " default: readdirplus except with "
The commit 88fc107956a5812649e5918e0c092d3f78bb28ad disabled remote posix locks by default. But the --help message still says it is enabled by default. So fix it to output no_posix_lock. Signed-off-by: Jiachen Zhang <zhangjiachen.jaycee@bytedance.com> --- tools/virtiofsd/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)