diff mbox

[PULL,02/14] linux-user: Assert stack used for auxvec, envp, argv

Message ID 8c0f0a60d48a6f62c20f4ce77dceb82047d3d57f.1399057853.git.riku.voipio@linaro.org
State Accepted
Commit 8c0f0a60d48a6f62c20f4ce77dceb82047d3d57f
Headers show

Commit Message

Riku Voipio May 2, 2014, 7:15 p.m. UTC 
From: James Hogan <james.hogan@imgtec.com>

Assert that the amount of stack space used for auxvec, envp & argv
exactly matches the amount allocated. This catches if DLINFO_ITEMS isn't
updated when another NEW_AUX_ENT is added.

Signed-off-by: James Hogan <james.hogan@imgtec.com>
Cc: Riku Voipio <riku.voipio@iki.fi>
Cc: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
---
 linux-user/elfload.c | 2 ++
 1 file changed, 2 insertions(+)
diff mbox

Patch

diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index d2380b6..ecf6f35 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -1455,6 +1455,8 @@  static abi_ulong create_elf_tables(abi_ulong p, int argc, int envc,
     info->auxv_len = sp_auxv - sp;
 
     sp = loader_build_argptr(envc, argc, sp, p, 0);
+    /* Check the right amount of stack was allocated for auxvec, envp & argv. */
+    assert(sp_auxv - sp == size);
     return sp;
 }