diff mbox series

[09/42] mfd: da9150: use PLATFORM_DEVID_NONE

Message ID 20200921205016.20461-9-krzk@kernel.org
State Superseded
Headers show
Series [01/42] mfd: arizona: use PLATFORM_DEVID_NONE | expand

Commit Message

Krzysztof Kozlowski Sept. 21, 2020, 8:49 p.m. UTC 
Use PLATFORM_DEVID_NONE define instead of "-1" value because:
 - it brings some meaning,
 - it might point attention why auto device ID was not used.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 drivers/mfd/da9150-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Adam Thomson Sept. 22, 2020, 9:05 a.m. UTC | #1 
On 21 September 2020 21:50, Krzysztof Kozlowski wrote:

> Use PLATFORM_DEVID_NONE define instead of "-1" value because:

>  - it brings some meaning,

>  - it might point attention why auto device ID was not used.

> 

> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>


Acked-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
diff mbox series

Patch

diff --git a/drivers/mfd/da9150-core.c b/drivers/mfd/da9150-core.c
index 7f0aa1e8db96..e335cf718442 100644
--- a/drivers/mfd/da9150-core.c
+++ b/drivers/mfd/da9150-core.c
@@ -453,7 +453,7 @@  static int da9150_probe(struct i2c_client *client,
 
 	enable_irq_wake(da9150->irq);
 
-	ret = mfd_add_devices(da9150->dev, -1, da9150_devs,
+	ret = mfd_add_devices(da9150->dev, PLATFORM_DEVID_NONE, da9150_devs,
 			      ARRAY_SIZE(da9150_devs), NULL,
 			      da9150->irq_base, NULL);
 	if (ret) {